24 Sep, 2016
1 commit
-
Remove unneeded variables and assignments.
Signed-off-by: Masahiro Yamada
Reviewed-by: Minkyu Kang
Reviewed-by: Angelo Dureghello
23 Jul, 2016
1 commit
-
Signed-off-by: Ladislav Michl
25 May, 2016
6 commits
-
Now that we are using driver model, we can drop the weak functions and LCD
init in the board file.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin
Signed-off-by: Minkyu Kang -
Update several boards to use driver model for video. This involves changes
to the EDP and FIMD (frame buffer) drivers. Existing PWM, simple-panel and
pwm-backlight drivers are used. These work without additional configuration
since they use the device tree settings in the same way as Linux.Boards converted are:
- snow
- spring
- peach-pit
- peach-piAll have been tested. Not converted:
- MIPI display driver
- s5pc210_universal
- smdk5420
- smdk5250
- trats
- trats2Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin
Signed-off-by: Minkyu Kang -
This function controls enabling the EDP PHY. Rename it and drop the existing
weak functions, which are confusing.Signed-off-by: Simon Glass
Signed-off-by: Minkyu Kang -
Some boards have the LCD enabled but I cannot test operation for the driver
model conversion. Disable the LCD on these to avoid build errors.Signed-off-by: Simon Glass
Signed-off-by: Minkyu Kang -
This file currently requires LCD support. Adjust it so that it can still be
built without LCD support (even thought it won't work fully).Signed-off-by: Simon Glass
Signed-off-by: Minkyu Kang -
Espresso7420 is a development/evaluation board for Exynos7420 SoC. It
includes multiple onboard compoments (EMMC/Codec) and various
interconnects (USB/HDMI).Signed-off-by: Thomas Abraham
Reviewed-by: Simon Glass
Signed-off-by: Minkyu Kang
25 Feb, 2016
1 commit
-
Compiling the mkorigenspl tool on darwin complains about undefined ulong. Fix
this by using the unified way.Signed-off-by: Andreas Bießmann
15 Jan, 2016
1 commit
-
With format-security errors turned on, GCC picks up the use of sprintf with
a format parameter not being a string literal.Simple uses of sprintf are also converted to use strcpy.
Signed-off-by: Ben Whitten
Acked-by: Wolfgang Denk
Reviewed-by: Tom Rini
18 Dec, 2015
3 commits
-
The driver is actually for the Designware DWC2 controller.
This patch renames the global s3c_udc.h header to dwc2_udc.h.The rename is done automatically:
$ sed -i "s/s3c_udc\.h/dwc2_udc.h/g" \
`git grep "s3c_udc\.h" | cut -d : -f 1`Signed-off-by: Marek Vasut
-
The driver is actually for the Designware DWC2 controller.
This patch is the second and final to rename global symbol,
the s3c_udc_probe() function.The rename is done automatically:
$ sed -i "s/s3c_udc_probe/dwc2_udc_probe/g" \
`git grep s3c_udc_probe | cut -d : -f 1`Signed-off-by: Marek Vasut
-
The driver is actually for the Designware DWC2 controller.
This patch is the first to rename global symbol, the struct
s3c_plat_otg_data.The rename is done automatically:
$ sed -i "s/s3c_plat_otg_data/dwc2_plat_otg_data/g" \
`git grep s3c_plat_otg_data | cut -d : -f 1`Signed-off-by: Marek Vasut
02 Nov, 2015
6 commits
-
This patch will fix these checkpatch issues.
CHECK: Alignment should match open parenthesis
+ printf("Enter: %s %s\n", mode_name[mode][0],
+ mode_info[mode]);CHECK: Alignment should match open parenthesis
+ lcd_printf("\n\n\t%s %s\n", mode_name[mode][0],
+ mode_info[mode]);CHECK: Alignment should match open parenthesis
+ lcd_printf("\t%s %s - %s\n\n", selection[i],
+ mode_name[i][0],Signed-off-by: Minkyu Kang
-
This patch will fix these checkpatch issues.
+static const char *mmc_regulators[] = {
CHECK: Blank lines aren't necessary before a close brace '}'
+
+}Signed-off-by: Minkyu Kang
-
This patch will fix these checkpatch issues.
ERROR: spaces required around that '==' (ctx:VxV)
+#if FCLK_SPEED==0 /* Fout = 203MHz, Fin = 12MHz for Audio */ERROR: spaces required around that '==' (ctx:VxV)
+#elif FCLK_SPEED==1 /* Fout = 202.8MHz */ERROR: spaces required around that '==' (ctx:VxV)
+#if USB_CLOCK==0ERROR: spaces required around that '==' (ctx:VxV)
+#elif USB_CLOCK==1CHECK: spaces required around that ':' (ctx:VxV)
+ "bne 1b":"=r" (loops):"0" (loops));Signed-off-by: Minkyu Kang
-
This patch will fix these checkpatch issues.
WARNING: Avoid unnecessary line continuations
+ gd->bd->bi_dram[0].size = get_ram_size((long *)PHYS_SDRAM_1, \WARNING: Avoid unnecessary line continuations
+ gd->bd->bi_dram[1].size = get_ram_size((long *)PHYS_SDRAM_2, \WARNING: Avoid unnecessary line continuations
+ gd->bd->bi_dram[2].size = get_ram_size((long *)PHYS_SDRAM_3, \WARNING: Avoid unnecessary line continuations
+ gd->bd->bi_dram[3].size = get_ram_size((long *)PHYS_SDRAM_4, \Signed-off-by: Minkyu Kang
-
This commit adds additional file with implementation of board
detection code for Odroid-XU3/XU4.The detection depends on compatible found in fdt:
- "samsung,exynos5" - uses Exynos5 generic code
- "samsung,odroidxu3" - try detect XU3 revisionThere are few revisions of Odroid XU3/XU4, each can be detected
by checking the value of channel 9 of built-in ADC:
Rev ADC Board
0.1 0 XU3 0.1
0.2 372 XU3 0.2 | XU3L - no DISPLAYPORT
0.3 1280 XU4 0.1The detection code depends on the ADC+10% value.
Implementation of functions:
- set_board_type() - read ADC and set type
- get_board_rev() - returns board revision: 1..3
- get_board_type() - returns board type stringAdditional functions with return values of bool:
- board_is_generic() - true if found compatible "samsung,exynos5"
but not "samsung,odroidxu3"
- board_is_odroidxu3() - true if found compatible "samsung,odroidxu3"
and one of XU3 revision.
- board_is_odroidxu4() - true if found compatible "samsung,odroidxu3"
and XU4 revision.After I2C controller init, the get_board_type() can check
if the XU3 board is a "Lite" variant, by probing chip
0x40 on I2C0 (INA231 - exists only on non-lite).
This is useful for setting fdt file name at misc_init_r().Enabled configs:
- CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
- CONFIG_ODROID_REV_AIN
- CONFIG_REVISION_TAG
- CONFIG_BOARD_TYPESSigned-off-by: Przemyslaw Marczak
Cc: Minkyu Kang
Cc: Simon Glass
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang -
The function get_board_type() is called in two places by common code,
but the returned pointer was never check.This commit adds checking the returned pointer, before use it.
Signed-off-by: Przemyslaw Marczak
Cc: Minkyu Kang
Reviewed-by: Simon Glass
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang
25 Oct, 2015
1 commit
-
In the "Getting Started with Coccinelle - KVM edition" presentation that
has been held by Julia Lawall at the KVM forum 2015 (see the slides at
http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
she pointed out some bad return value checks in U-Boot that can be
detected with Coccinelle by using the following config file:@@
identifier x,y;
identifier f;
statement S;
@@
x = f(...);
(
if (x < 0) S
|
if (
- y
+ x
< 0) S
)This patch now fixes these issues.
Signed-off-by: Thomas Huth
12 Sep, 2015
1 commit
-
Now that we have a new header file for cache-aligned allocation, we should
move the stack-based allocation macro there also.Signed-off-by: Simon Glass
31 Aug, 2015
1 commit
-
If board uses downstream Chrome OS U-Boot as first stage
bootloader and upstream version is chained second stage,
1.1V is minimum voltage borderline.Signed-off-by: Misha Komarovskiy
Acked-by: Simon Glass
06 Aug, 2015
6 commits
-
Spring is the first ARM-based HP Chromebook 11. It is similar to snow
and it uses the same Samsung Exynos5250 chip. But has some unusual
features. Mainline support for it has lagged snow (both in kernel and
U-Boot). Now that the exynos5 code is common we can support spring just
by adding a device tree and a few lines of configuration.Signed-off-by: Simon Glass
-
Now that most exynos5250 boards can use the generic exynos5 code, switch
over to it and remove the old code.Signed-off-by: Simon Glass
-
Now that exynos5420 boards can use the generic exynos5 code, switch over to
it and remove the old code.Signed-off-by: Simon Glass
Acked-by: Przemyslaw Marczak -
Since device tree is used for all exynos5 boards, we can remove the #ifdef
and reduce confusion.Signed-off-by: Simon Glass
-
Enable PMICs, regulators and the like so that new drivers will be made
available.Signed-off-by: Simon Glass
-
Some boards use device tree for almost all board-specific configuration.
They therefore do not need their own separate board code, but can all use
the same version. Add a common version of the board code. It uses the
PMIC, regulator and video bridge uclasses. This will support smdk5250,
smdk5420, snow, spring, pit and pi.Signed-off-by: Simon Glass
22 Jul, 2015
1 commit
-
This introduces a coherent scheme for naming USB download gadget and functions
config options. The download USB gadget config option is moved to
CONFIG_USB_GADGET_DOWNLOAD for better consistency with other gadgets and each
function's config option is moved to a CONFIG_USB_FUNCTION_ prefix.Signed-off-by: Paul Kocialkowski
Tested-by: Lukasz MajewskiTest HW: Odroid_XU3 (Exynos5422), trats (Exynos4210)
10 Jul, 2015
1 commit
-
Adds the 'F:' entry for the board's defconfig
Signed-off-by: Minkyu Kang
19 Jun, 2015
1 commit
-
This fix is necessary to avoid booting the default ITB configuration.
Signed-off-by: Lukasz Majewski
08 Jun, 2015
3 commits
-
This commit adds example scripts of boot.scr:
- bootzimg.cmd - check if dtb exists and boot zImage
- autoboot.cmd - check which image exists: Image.itb, zImage or uImage
and optionally load fdt file for u/zImageThe blank spaces are added to improve readability and can be removed
before use mkimage.Required U-Boot environment variables: $boardname, $fdtfile, $console,
$mmcbootdev, $mmcbootpart, $mmcrootdev, $mmcrootpart, $rootfstype.Making boot.scr from file.cmd:
mkimage -C none -A arm -T script -d file.cmd boot.scrThe Odroid XU3 default environment is ready for those boot scripts and
the right script can be loaded by DFU.Signed-off-by: Przemyslaw Marczak
Cc: Minkyu Kang -
This commit extends SMDK5420 board's file by adding functions:
- get_dfu_alt_system()
- get_dfu_alt_boot()This allows setting the DFU environment by function set_dfu_alt_info()
from: board/samsung/common/misc.cSigned-off-by: Inha Song
Cc: Akshay Saraswat
Cc: Minkyu Kang -
This commit adds implementation of function calls:
- usb_gadget_handle_interrupts()
- board_usb_init()Which allow enable USB DWC3 gadget for this board.
Signed-off-by: Joonyoung Shim
Signed-off-by: Lukasz Majewski
Signed-off-by: Inha Song
Cc: Minkyu Kang
15 May, 2015
3 commits
-
This cleanup includes:
- remove of the preprocessor macros which pointed to long name functions
- update of the names of some regulator uclass driver functions
- cleanup of the function regulator_autoset()
- reword of some comments of regulator uclass header file
- regulator_get_by_platname: check error for uclass_find_* function calls
- add function: regulator_name_is_unique
- regulator post_bind(): check regulator name uniqueness
- fix mistakes in: regulator/Kconfig
- regulator.h: update comments
- odroid u3: cleanup the regulator callsSigned-off-by: Przemyslaw Marczak
Acked-by: Simon Glass
Tested on sandbox:
Tested-by: Simon Glass -
This change enables the configs required to init and setup max77686
regulator driver, using the new driver model pmic and regulator API.
And also changes the old pmic framework calls to the new ones.This commits enables:
- CONFIG_ERRNO_STR
- CONFIG_DM_PMIC
- CONFIG_DM_PMIC_CMD
- CONFIG_DM_PMIC_MAX77686
- CONFIG_DM_REGULATOR
- CONFIG_DM_REGULATOR_CMD
- CONFIG_DM_REGULATOR_MAX77686And removes the unused:
- CONFIG_DM_I2C_COMPAT
- CONFIG_POWER
- CONFIG_POWER_I2C
- CONFIG_POWER_MAX77686Signed-off-by: Przemyslaw Marczak
Acked-by: Simon Glass -
In the power_init_board function call, regulator driver init is called,
so before compile, make sure that any power framework is defined.Signed-off-by: Przemyslaw Marczak
Acked-by: Simon Glass
19 Apr, 2015
3 commits
-
As mentioned in the previous commit, adding default values in each
Kconfig causes problems because it does not co-exist with the
"depends on" syntax. (Please note this is not a bug of Kconfig.)
We should not do so unless we have a special reason. Actually,
for CONFIG_DM*, we have no good reason to do so.Generally, CONFIG_DM is not a user-configurable option. Once we
convert a driver into Driver Model, the board only works with Driver
Model, i.e. CONFIG_DM must be always enabled for that board.
So, using "select DM" is more suitable rather than allowing users to
modify it. Another good thing is, Kconfig warns unmet dependencies
for "select" syntax, so we easily notice bugs.Actually, CONFIG_DM and other related options have been added
without consistency: some into arch/*/Kconfig, some into
board/*/Kconfig, and some into configs/*_defconfig.This commit prefers "select" and cleans up the following issues.
[1] Never use "CONFIG_DM=n" in defconfig files
It is really rare to add "CONFIG_FOO=n" to disable CONFIG options.
It is more common to use "# CONFIG_FOO is not set". But here, we
do not even have to do it.
Less than half of OMAP3 boards have been converted to Driver Model.
Adding the default values to arch/arm/cpu/armv7/omap3/Kconfig is
weird. Instead, add "select DM" only to appropriate boards, which
eventually eliminates "CONFIG_DM=n", etc.[2] Delete redundant CONFIGs
Sandbox sets CONFIG_DM in arch/sandbox/Kconfig and defines it again
in configs/sandbox_defconfig.
Likewise, OMAP3 sets CONFIG_DM arch/arm/cpu/armv7/omap3/Kconfig and
defines it also in omap3_beagle_defconfig and devkit8000_defconfig.Signed-off-by: Masahiro Yamada
-
Since driver model will probe the EC when it is first used, we do not
need to init it explicitly.Signed-off-by: Simon Glass
-
Since all supported boards enable this option now, we can remove it along
with the old code.Signed-off-by: Simon Glass