Eric Lee / smarc-uboot

03 Dec, 2019

1 commit

21 Aug, 2018

3 commits

  • dbb148b22   cmd: efi: Clarify calculation precedence for '&' and '?' ... Browse Code »

    Fix cppcheck complaint:
    [cmd/efi.c:173]: (style) Clarify calculation precedence for '&' and '?'.

    Fixes: f1a0bafb5802 ("efi: Add a command to display the memory map")
    Signed-off-by: Eugeniu Rosca
    Reviewed-by: Heinrich Schuchardt
    Signed-off-by: Alexander Graf

    Eugeniu Rosca
     
  • c3a40cce2   efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes ... Browse Code »

    With this update, the memory attributes are in sync with Linux
    kernel v4.18-rc4. They also match page 190 of UEFI 2.7 spec [1].

    [1] http://www.uefi.org/sites/default/files/resources/UEFI_Spec_2_7.pdf

    Suggested-by: Heinrich Schuchardt
    Signed-off-by: Eugeniu Rosca
    Reviewed-by: Heinrich Schuchardt
    Signed-off-by: Alexander Graf

    Eugeniu Rosca
     
  • 9b89183b9   efi: Fix truncation of constant value ... Browse Code »

    Starting with commit 867a6ac86dd8 ("efi: Add start-up library code"),
    sparse constantly complains about truncated constant value in efi.h:

    include/efi.h:176:35: warning: cast truncates bits from constant value (8000000000000000 becomes 0)

    This can get quite noisy, preventing real issues to be noticed:

    $ make defconfig
    *** Default configuration is based on 'sandbox_defconfig'
    $ make C=2 -j12 2>&1 | grep truncates | wc -l
    441

    After the patch is applied:
    $ make C=2 -j12 2>&1 | grep truncates | wc -l
    0
    $ sparse --version
    v0.5.2

    Following the suggestion of Heinrich Schuchardt, instead of only
    fixing the root-cause, I replaced the whole enum of _SHIFT values
    by ULL defines. This matches both the UEFI 2.7 spec and the Linux
    kernel implementation.

    Some ELF size comparison before and after the patch (gcc 7.3.0):

    efi-x86_payload64_defconfig:
    text data bss dec hex filename
    407174 29432 278676 715282 aea12 u-boot.old
    407152 29464 278676 715292 aea1c u-boot.new
    -22 +32 0 +10

    efi-x86_payload32_defconfig:
    text data bss dec hex filename
    447075 30308 280076 757459 b8ed3 u-boot.old
    447053 30340 280076 757469 b8edd u-boot.new
    -22 +32 0 +10

    Fixes: 867a6ac86dd8 ("efi: Add start-up library code")
    Suggested-by: Heinrich Schuchardt
    Signed-off-by: Eugeniu Rosca
    Reviewed-by: Heinrich Schuchardt
    Reviewed-by: Heinrich Schuchardt
    Signed-off-by: Alexander Graf

    Eugeniu Rosca
     

24 Jun, 2018

1 commit

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    56

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

25 Jan, 2016

1 commit

  • 2e192b245   Remove the cmd_ prefix from command files ... Browse Code »

    Now that they are in their own directory, we can remove this prefix.
    This makes it easier to find a file since the prefix does not get in the
    way.

    Signed-off-by: Simon Glass
    Reviewed-by: Bin Meng
    Reviewed-by: Heiko Schocher
    Acked-by: Stefan Roese
    Acked-by: Przemyslaw Marczak

    Simon Glass