08 Nov, 2014
2 commits
-
run_command() returns success even if the command had a syntax error;
correct this behaviour.Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org) -
Attempting to run:
- an empty string
- a string with just spacesreturns different error codes, 1 for the empty string and 0
for the string with just spaces. Make both of them return
0 for consistency.Signed-off-by: Rabin Vincent
Acked-by: Simon Glass <sjg@chromium.org)
27 Oct, 2014
2 commits
-
These types are problematic because they are typically declared in a
non-standard way in U-Boot. For example, U-Boot uses 'long long' for
int64_t even on a 64-bit machine whereas stdint.h uses 'long'.
Similarly, U-Boot always uses 'long' for intptr_t whereas stdint.h mostly
uses 'int'.This simple test script runs a few toolchains on a few archs to check for
warnings.Signed-off-by: Simon Glass
-
The run command treats each argument an an environment variable. It gets the
value of each variable and executes it as a command. If an environment
variable contains a newline and the hush cli is used, it is supposed to
execute each line one after the other.Normally a newline signals to hush to exit - this is used in normal command
line entry - after a command is entered we want to return to allow the user
to enter the next one. But environment variables obviously need to execute
to completion.Add a special case for the execution of environment variables which
continues when a newline is seen, and add a few tests to check this
behaviour.Note: it's not impossible that this may cause regressions in other areas.
I can't think of a case but with any change of behaviour with limited test
coverage there is always a risk. From what I can tell this behaviour has
been around since at least U-Boot 2011.03, although this pre-dates sandbox
and I have not tested it on real hardware.Reported-by: Wolfgang Denk
Signed-off-by: Simon Glass
24 Oct, 2014
4 commits
-
Add tests for gpio_requestf() and for memory leaks.
Signed-off-by: Simon Glass
-
Check the state of the malloc() heap before each test is run, so that tests
can verify that all is well at the end. Provide helper functions to mark
the heap and to check that it returns to its initial state.Signed-off-by: Simon Glass
-
Add a helper which permits a printf()-style format string for the requester
string.Signed-off-by: Simon Glass
-
Now that gpio_request() is handled by the uclass, updates the tests
accordingly.Signed-off-by: Simon Glass
23 Oct, 2014
3 commits
-
Add a simple test for SPI that uses SPI flash. It operates by creating a
SPI flash file and using the 'sf test' command to test that all
operations work correctly.Signed-off-by: Simon Glass
Acked-by: Jagannadha Sutradharudu Teki -
These tests use SPI flash (and the sandbox emulation) to operate.
Signed-off-by: Simon Glass
Acked-by: Jagannadha Sutradharudu Teki -
Buses need to iterate through their children in some situations. Add a few
functions to make this easy.Signed-off-by: Simon Glass
Acked-by: Jagannadha Sutradharudu Teki
25 Sep, 2014
2 commits
-
This performs a command, then repeats it, and checks that the repeat
happens.Signed-off-by: Simon Glass
-
These cause U-Boot to print a list of available commands. It doesn't break
the test, but it is best to remove them from the output.Signed-off-by: Simon Glass
29 Aug, 2014
1 commit
-
The host filesystem name has changed, so update the tests. The tests now
run again correctly:$ make O=b/sandbox sandbox_defconfig all
...
$ test/image/test-fit.py -u b/sandbox/u-boot
FIT Tests=========
Kernel load
Kernel + FDT load
Kernel + FDT + Ramdisk loadTests passed
Caveat: this is only a sanity check - test coverage is poorSigned-off-by: Simon Glass
20 Aug, 2014
3 commits
-
This commit adds new test for UMS USB gadget to u-boot mainline tree.
It is similar in operation to the one already available in test/dfu
directory.Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren -
By mistake I've forgotten to add the SPDX license tags for the DFU testing
scripts.
This commit fixes that and also provides some other relevant information.Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren -
It is now possible to pass to the dfu_gadget_test_init.sh script the sizes
of files to be generated.This feature is required by UMS tests which reuse this code.
Signed-off-by: Lukasz Majewski
Acked-by: Stephen Warren
09 Aug, 2014
6 commits
-
Remove the verified boot limitation that only allows a single
RSA public exponent of 65537 (F4). This change allows use with
existing PKI infrastructure and has been tested with HSM-based
PKI.Change the configuration OF tree format to store the RSA public
exponent as a 64 bit integer and implement backward compatibility
for verified boot configuration trees without this extra field.Parameterise vboot_test.sh to test different public exponents.
Mathematics and other hard work by Andrew Bott.
Tested with the following public exponents: 3, 5, 17, 257, 39981,
50457, 65537 and 4294967297.Signed-off-by: Andrew Bott
Signed-off-by: Andrew Wishart
Signed-off-by: Neil Piercy
Signed-off-by: Michael van der Westhuizen
Cc: Simon Glass -
On Tegra, the DFU buffer size is 1M. Consequently, the 8M test always
fails. Add tests for the 1M size, and one byte less as a corner case,
so that some large tests are executed and expected to pass.Signed-off-by: Stephen Warren
-
Call cleanup() before running tests too. If a previous test was CTRL-C'd
some stale files may have been left around. dfu-util refuses to receive
a file to a filename that already exists, which results in false test
failures if the files aren't cleaned up first.Signed-off-by: Stephen Warren
-
Signed-off-by: Lukasz Majewski
-
Various misc enhancements to dfu_gadget_test.sh:
* After every write (download), perform a write to a different file
with different data. This ensures that the DFU buffer's content is
replaced, so that if the read (upload) succeeds, we know that the
correct data was actually read from the storage device, rather than
simply being left over in the DFU buffer. This requires two alt
setting names to be passed to the script, and a dummy data file to
be generated by dfu_gadget_test_init.sh.* Fix the assumption that dfu_gadget_test.sh is run from the directory
that contains it, by cd'ing to that directory before invoking
./dfu_gadget_test_init.sh.* Use $DIR$RCV_DIR consistently, rather than using plain $RCV_DIR in
some places.* Add 959, 961 test file sizes, to be consistent with having one
more than and one less than all the other "round" sizes 64, 128, and
4096.* Remove references to $BKP_DIR from dfu_gadget_test_init.sh, since it
isn't used.Signed-off-by: Stephen Warren
-
This commit adds test scripts for testing if any commit has introduced
regression to the DFU subsystem.It uses md5 to test if sent and received file is correct.
The test detailed description is available at README file.Signed-off-by: Lukasz Majewski
23 Jul, 2014
13 commits
-
Some devices (particularly bus devices) must track their children, knowing
when a new child is added so that it can be set up for communication on the
bus.Add a child_pre_probe() method to provide this feature, and a corresponding
child_post_remove() method.Signed-off-by: Simon Glass
-
Some device types can have child devices and want to store information
about them. For example a USB flash stick attached to a USB host
controller would likely use this space. The controller can hold
information about the USB state of each of its children.The data is stored attached to the child device in the 'parent_priv'
member. It can be auto-allocated by dm when the child is probed. To
do this, add a per_child_auto_alloc_size value to the parent driver.Signed-off-by: Simon Glass
-
Devices can have childen that can be addressed by a simple index, the
sequence number or a device tree offset. Add functions to access a child
in each of these ways.The index is typically used as a fallback when the sequence number is not
available. For example we may use a serial UART with sequence number 0 as
the console, but if no UART has sequence number 0, then we can fall back
to just using the first UART (index 0).The device tree offset function is useful for buses, where they want to
locate one of their children. The device tree can be scanned to find the
offset of each child, and that offset can then find the device.Signed-off-by: Simon Glass
-
At present only root nodes in the device tree are scanned for devices.
But some devices can have children. For example a SPI bus may have
several children for each of its chip selects.Add a function which scans subnodes and binds devices for each one. This
can be used for the root node scan also, so change it.A device can call this function in its bind() or probe() methods to bind
its children.Signed-off-by: Simon Glass
-
Don't allow access to uclasses before they have been initialised.
Signed-off-by: Simon Glass
-
Each device that was bound from a device tree has an node that caused it to
be bound. Add functions that find and return a device based on a device tree
offset.Signed-off-by: Simon Glass
-
Add this information to 'dm tree' and 'dm uclass' commands.
Signed-off-by: Simon Glass
-
In U-Boot it is pretty common to number devices from 0 and access them
on the command line using this numbering. While it may come to pass that
we will move away from this numbering, the possibility seems remote at
present.Given that devices within a uclass will have an implied numbering, it
makes sense to build this into driver model as a core feature. The cost
is fairly small in terms of code and data space.With each uclass having numbered devices we can ask for SPI port 0 or
serial port 1 and receive a single device.Devices typically request a sequence number using aliases in the device
tree. These are resolved when the device is probed, to deal with conflicts.
Sequence numbers need not be sequential and holes are permitted.At present there is no support for sequence numbers using static platform
data. It could easily be added to 'struct driver_info' if needed, but it
seems better to add features as we find a use for them, and the use of -1
to mean 'no sequence' makes the default value somewhat painful.Signed-off-by: Simon Glass
-
This command currently activates devices as it lists them. This is not
desirable since it changes the system state. Fix it and avoid printing
a newline if there are no devices in a uclass.Signed-off-by: Simon Glass
-
The device display for 'dm tree' and 'dm uclass' is mostly the same, so
move it into a common function.Signed-off-by: Simon Glass
-
Driver model currently only operates after relocation is complete. In this
state U-Boot typically has a small amount of memory available. In adding
support for driver model prior to relocation we must try to use as little
memory as possible.In addition, on some machines the memory has not be inited and/or the CPU
is not running at full speed or the data cache is off. These can reduce
execution performance, so the less initialisation that is done before
relocation the better.An immediately-obvious improvement is to only initialise drivers which are
actually going to be used before relocation. On many boards the only such
driver is a serial UART, so this provides a very large potential benefit.Allow drivers to mark themselves as 'pre-reloc' which means that they will
be initialised prior to relocation. This can be done either with a driver
flag or with a 'dm,pre-reloc' device tree property.To support this, the various dm scanning function now take a 'pre_reloc_only'
parameter which indicates that only drivers marked pre-reloc should be
bound.Signed-off-by: Simon Glass
-
The root device should be probed just like any other device. The effect of
this is to mark the device as activated, so that it can be removed (along
with its children) if required.Signed-off-by: Simon Glass
Acked-by: Marek Vasut -
Rather than reusing the 'reg' property, use an explicit property for the
expected ping value used in testing.Signed-off-by: Simon Glass
25 Jun, 2014
1 commit
24 Jun, 2014
1 commit
-
Commit 95fac6ab4589 "sandbox: Use os functions to read host device tree"
removed the ability for get_device_and_partition() to handle the "host"
device type, and redirect accesses to it to the host filesystem. This
broke some unit tests that use this feature. So, revert that change. The
code added back by this patch is slightly different to pacify checkpatch.However, we're then left with "host" being both:
- A pseudo device that accesses the hosts real filesystem.
- An emulated block device, which accesses "sectors" inside a file stored
on the host.In order to resolve this discrepancy, rename the pseudo device from host
to hostfs, and adjust the unit-tests for this change.The "help sb" output is modified to reflect this rename, and state where
the host and hostfs devices should be used.Signed-off-by: Stephen Warren
Tested-by: Josh Wu
Acked-by: Simon Glass
Tested-by: Simon Glass
22 Jun, 2014
1 commit
-
Make both dm enumeration commands support showing whether a driver is active
or not, and use a consistent indicator (an asterisk).Signed-off-by: Simon Glass
Acked-by: Marek Vasut
21 Jun, 2014
1 commit
-
The values here are int, but the map_to_sysmem() call can return a long.
Add a cast to deal with this.Signed-off-by: Simon Glass