07 Mar, 2012
1 commit
-
Change all files in common/ to use CMD_RET_USAGE instead of calling
cmd_usage() directly. I'm not completely sure about this patch since
the code since impact is small (100 byte or so on ARM) and it might
need splitting into smaller patches. But for now here it is.Signed-off-by: Simon Glass
22 Nov, 2011
1 commit
-
Extract all extern declarations for console_buffer[] out of c files into
the common.h header.Signed-off-by: Igor Grinberg
Cc: Frank Gottschling
Cc: Murray Jensen
08 Nov, 2011
1 commit
-
Fix:
cmd_i2c.c: In function 'do_i2c_add_bus':
cmd_i2c.c:1212:19: warning: variable 'dev' set but not used
[-Wunused-but-set-variable]Signed-off-by: Wolfgang Denk
Cc: Heiko Schocher
28 Jul, 2011
1 commit
-
Signed-off-by: Michael Jones
Acked-by: Detlev Zundel
28 Apr, 2011
1 commit
-
To make sure that the mux can be configured a deblocking sequence
is done before the mux configuration. After the mux switch the new leaf
of, the i2c tree must be again deblocked.Signed-off-by: Stefan Bigler
Acked-by: Heiko Schocher
cc: Wolfgang Denk
cc: Detlev Zundel
cc: Prafulla Wadaskar
cc: Valentin Longchamp
cc: Holger Brunck
Signed-off-by: Valentin Longchamp
30 Oct, 2010
1 commit
-
By now, the majority of architectures have working relocation
support, so the few remaining architectures have become exceptions.
To make this more obvious, we make working relocation now the default
case, and flag the remaining cases with CONFIG_NEEDS_MANUAL_RELOC.Signed-off-by: Wolfgang Denk
Tested-by: Heiko Schocher
Tested-by: Reinhard Meyer
20 Sep, 2010
2 commits
-
!! This breaks support for all arm boards !!
To compile in old style, you must define
CONFIG_SYS_ARM_WITHOUT_RELOC or you can compile
with "CONFIG_SYS_ARM_WITHOUT_RELOC=1 ./MAKEALL board"!! This define will be removed soon, so convert your
board to use relocation supportPortions of this work were supported by funding from
the CE Linux Forum.Signed-off-by: Heiko Schocher
Fix boot from NAND for non-ARM systems
Signed-off-by: Wolfgang Denk -
Portions of this work were supported by funding from
the CE Linux Forum.Signed-off-by: Heiko Schocher
26 Aug, 2010
1 commit
-
Signed-off-by: Reinhard Meyer
25 Jul, 2010
1 commit
-
Lots of code use this construct:
cmd_usage(cmdtp);
return 1;Change cmd_usage() let it return 1 - then we can replace all these
ocurrances byreturn cmd_usage(cmdtp);
This fixes a few places with incorrect return code handling, too.
Signed-off-by: Wolfgang Denk
05 Jul, 2010
1 commit
-
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands. Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:int main (int argc, char **argv)
{
while (--argc > 0 && **++argv == '-') {
/* ====> */ while (*++*argv) {
switch (**argv) {
case 'd':
debug++;
break;
...
default:
usage ();
}
}
}
...
}The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell. With the modification, the compiler will prevent this with
an
error: increment of read-only location '*argv'N.B.: The code above can be trivially rewritten like this:
while (--argc > 0 && **++argv == '-') {
char *arg = *argv;
while (*++arg) {
switch (*arg) {
...Signed-off-by: Wolfgang Denk
Acked-by: Mike Frysinger
29 Mar, 2010
5 commits
-
and removed it from the .h file
Signed-off-by: Frans Meulenbroeks
-
The code to parse alen appeared 6 times in the function.
Factored this out in a small helper functionSigned-off-by: Frans Meulenbroeks
-
Signed-off-by: Frans Meulenbroeks
-
Signed-off-by: Frans Meulenbroeks
-
Declared all functions that were not called outside the file as static
Signed-off-by: Frans Meulenbroeks
22 Mar, 2010
4 commits
-
Signed-off-by: Frans Meulenbroeks
-
Signed-off-by: Frans Meulenbroeks
-
Signed-off-by: Frans Meulenbroeks
-
according to some of the comments the subaddress length is 1 or 2, but we are being
prepared for the case it becomes 3. However the code also accepted 4.
This repairs this by changing the constand 4 to 3.Signed-off-by: Frans Meulenbroeks
08 Dec, 2009
1 commit
-
commit bd3784df94bfeca43fbf34094df9cb1bd3ecca3b deleted some unused
code in do_i2c_mw(), but missed to also remove the respective
commment. This patch fixes this.Signed-off-by: Heiko Schocher
03 Dec, 2009
1 commit
-
There is some dead code enclosed by #if 0 .... #endif in the file
common/cmd_i2c.c
This patch removes the dead code.Signed-off-by: Pratap Chandu
18 Jul, 2009
1 commit
-
The sub-command parser missed a brace, so "return 0;" is always
taken and no error message is diplayed if you say "i2c scan"
instead of "i2c probe", for example.Proper brace is added. Also, a misleading and unneeded else
is removed.Signed-off-by: Alessandro Rubini
13 Jun, 2009
7 commits
-
Many of the help messages were not really helpful; for example, many
commands that take no arguments would not print a correct synopsis
line, but "No additional help available." which is not exactly wrong,
but not helpful either.Commit ``Make "usage" messages more helpful.'' changed this
partially. But it also became clear that lots of "Usage" and "Help"
messages (fields "usage" and "help" in struct cmd_tbl_s respective)
were actually redundant.This patch cleans this up - for example:
Before:
=> help dtt
dtt - Digital Thermometer and ThermostatUsage:
dtt - Read temperature from digital thermometer and thermostat.After:
=> help dtt
dtt - Read temperature from Digital Thermometer and ThermostatUsage:
dttSigned-off-by: Wolfgang Denk
-
When CONFIG_I2C_MUX was defined the output of 'help i2c' was not
correct, eg:=> help i2c
i2c bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes.
speed [speed] - show or set I2C bus speed
i2c dev [dev] - show or set current I2C bus
...It has been changed to:
i2c speed [speed] - show or set I2C bus speed
i2c bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes
i2c dev [dev] - show or set current I2C bus
...Signed-off-by: Peter Tyser
-
Signed-off-by: Peter Tyser
-
argc and argv should only be modified once instead of once for
every i2c sub-commandSigned-off-by: Peter Tyser
-
The individual i2c commands imd, imm, inm, imw, icrc32, iprobe, iloop,
and isdram are no longer available so all references to them have been
updated to the new form of "i2c ".Signed-off-by: Peter Tyser
-
The following individual I2C commands have been removed: imd, imm, inm,
imw, icrc32, iprobe, iloop, isdram.The functionality of the individual commands is still available via
the 'i2c' command.This change only has an impact on those boards which did not have
CONFIG_I2C_CMD_TREE defined.Signed-off-by: Peter Tyser
-
New default, weak i2c_get_bus_speed() and i2c_set_bus_speed() functions
replace a number of architecture-specific implementations.Also, providing default functions will allow all boards to enable
CONFIG_I2C_CMD_TREE. This was previously not possible since the
tree-form of the i2c command provides the ability to display and modify
the i2c bus speed which requires i2c_[set|get]_bus_speed() to be
present.Signed-off-by: Peter Tyser
28 Jan, 2009
2 commits
-
Remove command name from all command "usage" fields and update
common/command.c to display "name - usage" instead of
just "usage". Also remove newlines from command usage fields.Signed-off-by: Peter Tyser
-
Signed-off-by: Peter Tyser
02 Nov, 2008
1 commit
-
Signed-off-by: Wolfgang Denk
19 Oct, 2008
3 commits
-
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
-
With this Command it is possible to add new I2C Busses,
which are behind 1 .. n I2C Muxes. Details see README.Signed-off-by: Heiko Schocher
-
If I2C Bus is blocked (see doc/I2C_Edge_Conditions),
it is not possible to get out of this, until the
complete Hardware gets a reset. This new commando
calls again i2c_init (and that calls i2c_init_board
if defined), which will deblock the I2C Bus.Signed-off-by: Heiko Schocher
Signed-off-by: Wolfgang Denk
15 Oct, 2008
1 commit
-
Original code displayed:
=> help i2c
i2c i2c speed [speed] - show or set I2C bus speed
i2c md chip address[.0, .1, .2] [# of objects] - read from I2C device
...Signed-off-by: Peter Tyser
11 Sep, 2008
1 commit
-
add CMD_DATA_SIZE macro to enable it
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
21 Aug, 2008
1 commit
-
The last used chip, address, and address length were not being
stored for the imm and imn commands.Signed-off-by: Peter Tyser
21 May, 2008
1 commit
-
This commit gets rid of a huge amount of silly white-space issues.
Especially, all sequences of SPACEs followed by TAB characters get
removed (unless they appear in print statements).Also remove all embedded "vim:" and "vi:" statements which hide
indentation problems.Signed-off-by: Wolfgang Denk