Eric Lee / smarc-uboot

15 Oct, 2013

1 commit

24 Jul, 2013

1 commit

17 Nov, 2011

1 commit

13 Oct, 2010

1 commit

  • 076f1be8e   TSI148: Fix argument parsing ... Browse Code »

    This patch does 2 things:
    - Fix the argument number assigned to the vdw (VME data width) value.
    Previously, a nonexistent 7th arument was read as the vdw variable.

    - Reduce the size of the argument array for the tsi148 command from
    8 to 7. The tsi148 command itself is argument index 0, and the
    maximum number arguments passed to the command is 6, making a total
    of 7 for the array.

    Signed-off-by: Brent Darley
    Signed-off-by: Peter Tyser

    Brent Darley
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

24 Jul, 2009

1 commit

19 Jul, 2009

1 commit