23 Nov, 2013
2 commits
-
NetServerEther was not being cleared in the tftp server code, so the
destination MAC address would be whatever the last destination MAC
address was.Scenario:
U-Boot:
dhcp
tftpsrv
Host:
Send device WRQ
Device:
Responds with ACK to dhcp server mac address with
host ip addressBy clearing NetServerEther, we force a lookup of the host MAC address
to go with the associated host IP.Signed-off-by: Andrew Ruder
-
When the block 0 store to the memory of client and timeout at this
moment. Because of no ACK packet, the server will send block 0 again,
if this client reconnect to the server at this time,
TftpBlockWrapOffset will become larger than it should be.Signed-off-by: Rockly
Patch: 264417
25 Jun, 2013
1 commit
-
tftp.c:464:17: warning: cast to restricted __be16
tftp.c:552:29: warning: cast to restricted __be16
tftp.c:640:33: warning: cast to restricted __be16
tftp.c:642:25: warning: cast to restricted __be16Signed-off-by: Kim Phillips
Cc: Joe Hershberger
16 Dec, 2012
1 commit
-
This prints a tftp speed indication after the download completes. This
is the 3.6 MiB/s indicator below.Tegra2 (SeaBoard) # tftp ...
Using asx0 device
TFTP from server 172.22.72.144; our IP address is 172.22.73.81
Filename '/tftpboot/uImage-user-seaboard-1'.
Load address: 0x408000
Loading: #################################################
3.6 MiB/s
doneSigned-off-by: Simon Glass
Acked-by: Igor Grinberg
12 Jul, 2012
1 commit
-
The block argument for store_block can be -1 when the tftp sequence
number rolls over (i.e TftpBlock == 0), so the first argument to
store_block has to be of type 'int' instead of 'unsigned'.In our environment (gcc 4.4.5 mips toolchain), this causes incorrect
'offset' to be generated for storing the block, and the tftp block
with number 0 will be written elsewhere, resulting in a bad block in
the downloaded file and a memory corruption.Signed-off-by: Jayachandran Chandrasekharan Nair
24 May, 2012
3 commits
-
Call a built-in dummy if none is registered... don't require
protocols to register a handler (eliminating dummies)
NetConsole now uses the ARP handler when waiting on arp
(instead of needing a #define hack in arp.c)
Clear handlers at the end of net loopSigned-off-by: Joe Hershberger
Acked-by: Simon Glass -
Changes to NetState now go through an accessor function called
net_set_state()Signed-off-by: Joe Hershberger
-
Rename IP header related things to IP_UDP. The existing definition
of IP_t includes UDP header, so name it to accurately describe the
structure.Signed-off-by: Joe Hershberger
16 May, 2012
2 commits
-
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
07 Dec, 2011
1 commit
-
When building u-boot as 64 bit application (e.g. sandbox) ulong might be
64 bits in size. This breaks network code as IPaddr_t is 64 bytes in
size then and an IPv4 address is 32 bits in size. This patch makes sure
that IPaddr_t is always 32 bits in size. Also some warnings introduced
by this patch are fixed.Signed-off-by: Matthias Weisser
Acked-by: Mike Frysinger
28 Oct, 2011
3 commits
-
If CONFIG_CMD_TFTPPUT is not enabled, we want minimal code size impact
on the tftp code. This introduces a few more #ifdefs.Signed-off-by: Simon Glass
-
This should be a static function so it can be inlined.
Signed-off-by: Simon Glass
Acked-by: Mike Frysinger -
This commit reduces code size a little by making the ICMP handler only
available to tftpput. This is reasonable since it is the only user at
present (ping just uses the normal handler).Signed-off-by: Simon Glass
27 Oct, 2011
4 commits
-
This adds logic to tftp.c to implement the tftp 'put' command, and
updates the README.Signed-off-by: Simon Glass
-
TftpStart should support starting either a get or a put.
Signed-off-by: Simon Glass
-
This code is required for tftpput, so move it into separate functions.
Signed-off-by: Simon Glass
-
We want to show block markers on completion of get and put, so
move this common code into separate functions.Signed-off-by: Simon Glass
06 Oct, 2011
1 commit
-
This is long over due. All but two net drivers have been converted, but
those have now been dropped.The only thing left to do is actually delete all references to NET_MULTI
and code that is compiled when that is not defined. So here we scrub the
core code.Signed-off-by: Mike Frysinger
20 May, 2011
12 commits
-
Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
Acked-by: Detlev Zundel -
Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
Acked-by: Detlev Zundel -
With the upcoming TFTP server implementation, requests can be either
outgoing or incoming, so avoid ambiguities.Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
Acked-by: Detlev Zundel -
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
Acked-by: Detlev Zundel -
This removes the following checkpatch issue:
- ERROR: do not initialise statics to 0 or NULLSigned-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issue:
- WARNING: suspect code indent for conditional statementsSigned-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issue:
- ERROR: trailing statements should be on next lineSigned-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issues:
- WARNING: braces {} are not necessary for single statement blocks
- WARNING: braces {} are not necessary for any arm of this statementSigned-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issue:
- ERROR: do not use assignment in if condition.There is one such error left:
ERROR: do not use assignment in if condition
#239: FILE: tftp.c:239:
+ if (!ProhibitMcast
+ && (Bitmap = malloc(Mapsize))
+ && eth_get_dev()->mcast) {which would require an additional nested if to be fixed, resulting in longer
and less readable code.Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issues:
- ERROR: "foo * bar" should be "foo *bar"
- ERROR: "(foo*)" should be "(foo *)"Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk -
This removes the following checkpatch issues:
- ERROR: space prohibited before that close parenthesis ')'
- ERROR: space required after that ';' (ctx:BxV)
- ERROR: space required after that ',' (ctx:VxV)
- ERROR: space required after that ';' (ctx:VxV)
- ERROR: spaces required around that '<
Cc: Wolfgang Denk -
Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
13 May, 2011
1 commit
-
This is needed for the upcoming TFTP server implementation.
This also simplifies PingHandler() and fixes rxhand_f documentation.
Signed-off-by: Luca Ceresoli
Cc: Wolfgang Denk
Acked-by: Detlev Zundel
22 Mar, 2010
1 commit
-
So far, TFTP negotiated a fixed retransmission timeout of 5 seconds.
In some cases (busy networks, slow TFTP servers) this caused very
slow transfers. A new environment variable "tftptimeout" allows to
set this timeout. Lowering this value may make downloads succeed
faster in networks with high packet loss rates or with unreliable
TFTP servers.Signed-off-by: Wolfgang Denk
Cc: Ben Warren
Signed-off-by: Ben Warren
14 Dec, 2009
2 commits
-
Signed-off-by: Remy Bohmer
Signed-off-by: Ben Warren -
Signed-off-by: Mike Frysinger
Signed-off-by: Ben Warren
26 Aug, 2009
2 commits
-
Optionally add RFC 2349 "Transfer Size Option", so we can minimize the
time spent sending data over the UART (now print a single line during a
tftp transfer).- If turned on (CONFIG_TFTP_TSIZE), U-Boot asks for the size of the file.
- if receives the file size, a single line (50 chars) are printed.
one hash mark == 2% of the file downloaded.
- if it doesn't receive the file size (the server doesn't support RFC
2349, prints standard hash marks (one mark for each UDP frame).Signed-off-by: Robin Getz
Signed-off-by: Ben Warren -
Increasing the block size is useful if CONFIG_IP_DEFRAG is
used. Howerver, the last fragments in a burst may overflow the
receiving ethernet, so the default is left at 1468, with thre new
CONFIG_TFTP_BLOCKSIZE for config files. Further, "tftpblocksize"
can be set in the environment.Signed-off-by: Alessandro Rubini
Signed-off-by: Ben Warren
10 Aug, 2009
1 commit
-
tftp.c:294: warning: pointer targets in passing argument 1 of 'strlen'
differ in signednessThis was only visible for the utx8245 board which seems to have DEBUG
enabled.Signed-off-by: Wolfgang Denk
08 Aug, 2009
1 commit
-
Minor ./net cleanups - no functional changes
- change #ifdef DEBUG printf(); #endif to just debug()
- changed __FUNCTION__ to __func__
- got rid of extra whitespace between function and opening brace
- removed unnecessary braces on if statementsgcc dead code elimination should make this functionally/size equivalent
when DEBUG is not defined. (confirmed on Blackfin, with gcc 4.3.3).Signed-off-by: Robin Getz
Signed-off-by: Ben Warren
21 Mar, 2009
1 commit
-
Now that our printf functions support the %pI4 modifier like the kernel,
let's drop the inflexible print_IPaddr() function and covert over to the
%pI4 modifier.Signed-off-by: Mike Frysinger
CC: Ben Warren