14 Nov, 2018
1 commit
-
Fix coverity issue CID 18031: Resource leak (RESOURCE_LEAK)
leaked_storage: Variable fill_buf going out of scope leaks the storage it points toShould free the fill_buf before function return.
Signed-off-by: Ye Li
18 Oct, 2018
1 commit
-
chunk_data_sz = sparse_header->blk_sz * chunk_header->chunk_sz;
All is uint32. chunk_data_sz may be bigger than 4G.Change chunk_data_sz to 64bit.
force chunk_header->chunk_sz and sparse_header->blk_sz to 64bit.Signed-off-by: Frank Li
Acked-by: Ye Li
28 Jun, 2016
5 commits
-
- increase the size of the fill buffer
- testing has shown a 10x improvement when the sparse image
has large CHUNK_TYPE_FILL chunksSigned-off-by: Steve Rae
-
In order to process the CHUNK_TYPE_DONT_CARE properly, there is
a requirement to be able to 'reserve' a specified number of blocks
in the storage media. Because of the special handling of "bad blocks"
in NAND devices, this is implemented in a storage abstraction function.Signed-off-by: Steve Rae
Reviewed-by: Maxime Ripard -
- update fastboot_okay() and fastboot_fail()
This file originally came from upstream code.
While retaining the storage abstraction feature, this is the second
set of the changes required to resync with the
cmd_flash_mmc_sparse_img()
in the file
aboot.c
from
https://us.codeaurora.org/cgit/quic/la/kernel/lk/plain/app/aboot/aboot.c?h=LE.BR.1.2.1Signed-off-by: Steve Rae
-
This file originally came from upstream code.
While retaining the storage abstraction feature, this is the first
set of the changes required to resync with the
cmd_flash_mmc_sparse_img()
in the file
aboot.c
from
https://us.codeaurora.org/cgit/quic/la/kernel/lk/plain/app/aboot/aboot.c?h=LE.BR.1.2.1Signed-off-by: Steve Rae
-
This "session-id" alogrithm is not required, and currently corrupts
the stored image whenever more the one "session" is required.Signed-off-by: Steve Rae
12 Apr, 2016
3 commits
-
remove logging of the 'skipped' blocks
Signed-off-by: Steve Rae
Acked-by: Maxime Ripard -
When 7bfc3b1 (sparse: Refactor chunk parsing function) was implemented,
it dropped 9981945 (aboot: fix block addressing for don't care chunk type).This re-implements the required fix for the "don't care chunk type"...
Signed-off-by: Steve Rae
Acked-by: Maxime Ripard -
It may overflow in sparse_block_size_to_storage, use uint64_t instead in
the calculation.Signed-off-by: Jeffy Chen
13 Nov, 2015
1 commit
-
The Android sparse image format is currently supported through a file
called aboot, which isn't really such a great name, since the sparse image
format is only used for transferring data with fastboot.Rename the file and header to a file called "sparse", which also makes it
consistent with the header defining the image structures.Signed-off-by: Maxime Ripard
Reviewed-by: Tom Rini
