14 Nov, 2018
1 commit
-
Fix coverity issue CID 43665: Free of address-of expression (BAD_FREE)
incorrect_free: free frees incorrect pointer pp.pp points the port array field of struct ahci_uc_priv, should not free it.
Signed-off-by: Ye Li
Acked-by: Peng Fan
13 Nov, 2018
2 commits
-
Fix coverity issue CID 3261683: Wrong operator used (CONSTANT_EXPRESSION_RESULT)
operator_confusion: ({...; __v;}) | 67108864 is always 1/true regardless of the values
of its operand. This occurs as the logical operand of !When DIAG_X is set, the PHY COMINIT signal is detected, so should use '&' to check
whether it is set.Signed-off-by: Ye Li
-
Fix coverity issue CID 3606684: Resource leak (RESOURCE_LEAK)
leaked_storage: Variable uc_priv going out of scope leaks the storage it points toSigned-off-by: Ye Li
27 Apr, 2018
1 commit
-
The reset_sata should reset the sata device info and free the probe_ent
memory. Otherwise, it will cause memory leak if we init the sata again.Signed-off-by: Ye Li
17 Aug, 2017
13 commits
-
Update this driver to support driver model. This involves implementing the
AHCI operations and reusing existing common code.Signed-off-by: Simon Glass
-
Driver model wants to use the core functions in this file but accesses the
uclass-private data in a different way. Move the code into new 'common'
functions and set up stubs to call these.Signed-off-by: Simon Glass
-
This function will not be used with driver model and it relates to the
other exported functions. Move it down next to them.Signed-off-by: Simon Glass
-
This variable is set but never used. Drop it.
Signed-off-by: Simon Glass
-
Rename dwc_ahsata.h to indicate that it is a private header file. We plan
to create another header with some public functions.Signed-off-by: Simon Glass
-
Sort the header file inclusions into the correct order.
Signed-off-by: Simon Glass
-
There is a strange &(var) coding style in this driver. Adjust it to use
&var instead, which is more usual.Signed-off-by: Simon Glass
-
With driver model sata_dev_desc[] does not exist. We still want to use the
common code of this driver so update it to pass struct ahci_uc_priv * to
each of these functions, instead of an integer which must be looked up in
sata_dev_desc[].Signed-off-by: Simon Glass
-
Most of the casts in this driver are not necessary. With driver model we
do not cast from void *. Update the driver to follow this rule.Signed-off-by: Simon Glass
-
With driver model this becomes uclass-private data. Rename the parameter
varable to reflect this.With the driver model conversion we will not have any exported functions.
Move all exported functions to be together at the end of the file so that
we can deal with them in one #ifdef block.Signed-off-by: Simon Glass
-
With the driver model conversion we will not have any exported functions.
Move all exported functions to be together at the end of the file so that
we can deal with them in one #ifdef block.Signed-off-by: Simon Glass
-
This function is not called from anywhere. Drop it.
Signed-off-by: Simon Glass
-
Some functions are not called from outside this file. Make these static
to make that obvious.Signed-off-by: Simon Glass
12 Jul, 2017
2 commits
-
This is not a very useful name since once it is probed it still hangs
around. With driver model we will use uclass data for this, so rename the
struct.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng -
At present we have the SATA and PATA drivers mixed up in the drivers/block
directory. It is better to split them out into their own place. Use
drivers/ata which is what Linux does.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng