Eric Lee / smarc-uboot

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    60

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

22 Feb, 2018

2 commits

  • bb4059a53   dfu: Rename _FUNCTION_DFU to DFU_OVER_ ... Browse Code »

    Do the following to make the symbol names less confusing.

    sed -i "s/\([TU][^_]\+\)_FUNCTION_DFU/DFU_OVER_\1/g" \
    `git grep _FUNCTION_DFU | cut -d ":" -f 1 | sort -u`

    Signed-off-by: Marek Vasut
    Cc: Lukasz Majewski

    Marek Vasut
     
  • 0f44d3353   dfu: Fix up the Kconfig mess ... Browse Code »
    13

    Clean up the screaming mess of configuration options that DFU is.
    It was impossible to configure DFU such that TFTP is enabled and
    USB is not, this patch fixes that and assures that DFU TFTP and
    DFU USB can be enabled separatelly and that the correct pieces
    of code are compiled in.

    Signed-off-by: Marek Vasut
    Cc: Lukasz Majewski

    Marek Vasut
     

28 Sep, 2016

1 commit

25 Feb, 2016

1 commit

  • fc18f8d17   dfu: usb: f_dfu: Set deferred call for dfu_flush() function ... Browse Code »

    This patch fixes situation when one would like to write large file into
    medium with the file system (fat, ext4, etc).
    This change sets file size limitation to the DFU internal buffer size.

    Since u-boot is not supporting interrupts and seek on file systems, it
    becomes challenging to store large file appropriately.

    To reproduce this error - create large file (around 26 MiB) and sent it
    to the target board.

    Lets examine the flow of USB transactions:

    0. DFU uses EP0 with 64B MPS [Max Packet Size]

    1. Send file - OUT (PC->target) - dat_26MiB.img is sent with 4096 B transactions

    2. Get status - OUT (PC->target) - wait for DFU_STATE_dfuDNLOAD_IDLE (0x05) sent
    from target board - IN transaction
    (target->PC)

    3. The whole file content is sent to target - OUT (PC->target) with ZLP [Zero
    Length Packet]

    Now the interesting part starts:

    4. OUT (PC->target) Setup transaction (request to share DFU state)

    5. IN (target->PC) - reply the current DFU state
    - In the UDC driver the req->completion (with dfu_flush) is called
    after successful IN transfer.
    - The dfu_flush() (called from req->completion callback) saves the
    whole file at once (u-boot doesn't support seek on fs).
    Such operation takes considerable time. When the file
    is large - e.g. 26MiB - this time may be more than 5 seconds.

    6. OUT (PC->target) - ZLP, is send in the same time when dfu_flush()
    writes data to eMMC memory.
    The dfu-util application has hard coded timeout on USB transaction
    completion set to 5 seconds (it uses libusb calls).

    When the file to store is large (e.g. 26 MiB) the time needed to write it
    may excess the dfu-util timeout and following error message will be displayed:
    "unable to read DFU status" on the HOST PC console.

    This change is supposed to leverage DFU's part responsible for storing files
    on file systems. Other DFU operations - i.e. raw/partition write to NAND and
    eMMC should work as before.

    The only functional change is the error reporting. When dfu_flush() fails
    the u-boot prompt will exit with error information and dfu-util application
    exits afterwards as well.

    Test HW:
    - Odroid XU3 (Exynos5433) - test with large file
    - Trats (Exynos4210) - test for regression - eMMC, raw,

    Signed-off-by: Lukasz Majewski
    Reported-by: Alex Gdalevich
    Tested-by: Stephen Warren
    Tested-by: Heiko Schocher

    Lukasz Majewski
     

25 Jan, 2016

1 commit

  • 2e192b245   Remove the cmd_ prefix from command files ... Browse Code »

    Now that they are in their own directory, we can remove this prefix.
    This makes it easier to find a file since the prefix does not get in the
    way.

    Signed-off-by: Simon Glass
    Reviewed-by: Bin Meng
    Reviewed-by: Heiko Schocher
    Acked-by: Stefan Roese
    Acked-by: Przemyslaw Marczak

    Simon Glass