19 Jun, 2018
30 commits
-
The current code might succeed on the first allocation and fail on the
second. Separate the checks to avoid this problem.Of course, free() will never fail and the chances that (when allocating
two small areas) one will succeed and one will fail are just as remote.
But this keeps coverity happy.Reported-by: Coverity (CID: 131226)
Signed-off-by: Simon Glass
-
This loop never actually exits, but the way the code is written this is
not obvious. Add an explicit error check.Reported-by: Coverity (CID: 131280)
Signed-off-by: Simon Glass
[trini: Add explicit init of region to NULL per LLVM warning]
Signed-off-by: Tom Rini -
Both putc() and puts() can be called before global_data is set up. Some of
the code paths don't handle this correctly. Add an explicit test before
any member is accessed.Reported-by: Coverity (CID: 169030)
Signed-off-by: Simon Glass
Reviewed-by: Heinrich Schuchardt -
This allows access to an element after the end of the array. Fix it.
Reported-by: Coverity (CID: 173279)
Signed-off-by: Simon Glass -
There are multiple GPIO banks with up to 32 pins / bank. When
using 'gpio status -a' to read the pins, this patch displays
both GPIO_ similar to how the device trees
display in addition to displaying gpio_#Signed-off-by: Adam Ford
-
When CMD_GPIO is enabled the command 'gpio status -a' can cause
a hang or reboot if GPIO banks are not enabled, because it scans
all banks. This patch enables all GPIO banks so 'gpio status -a'
can fully execute.Signed-off-by: Adam Ford
-
When enabling BLOCK_CACHE on devices with limited RAM during SPL,
some devices may not boot. This creates an option to enable
block caching in SPL by defaults off. It is dependent on SPL_BLKFixes: 46960ad6d09b ("block: Have BLOCK_CACHE default to y in some cases")
Signed-off-by: Adam Ford
-
When an exception or interrupt occurs the link register (LR) may
contain the source of the exception, although we do not print the
value it may still be extracted with a debugger. When in SPL we
loop on getting and exception, but use a linking branch, which
over-writes the LR value, use a regular branch instruction here.Signed-off-by: Andrew F. Davis
-
When the `mmc hwpartition` command is disabled, remove the associated help
text.Signed-off-by: Alex Kiernan
-
This is the case when reading freshly created filesystem.
The error message is like the following:
btrfs_read_superblock: No valid root_backup found!Since the data from super_roots/root_backups is not actually used -
decided to rework btrfs_newest_root_backup() into
btrfs_check_super_roots() that will only check if super_roots
array is valid and correctly handle empty scenario.As a result:
* btrfs_read_superblock() now only checks if super_roots array is valid;
the case when it is empty is considered OK.
* removed root_backup pointer from btrfs_info,
which would be NULL in case of empty super_roots.
* btrfs_read_superblock() verifies number of devices from the superblock
itself, not newest root_backup.Signed-off-by: Yevgeny Popovych
Cc: Marek Behun
Cc: Sergey Struzh -
Follow Linux commit 10b62a2f785a (".gitignore: move *.dtb and *.dtb.S
patterns to the top-level .gitignore").Signed-off-by: Masahiro Yamada
-
Follow Linux commit 1377dd3e2987 (".gitignore: sort normal pattern
rules alphabetically").This would allow us to easily catch duplicated patterns if any.
Signed-off-by: Masahiro Yamada
-
This adds DM_GPIO support for the davinici GPIO driver with
DT support.Signed-off-by: Adam Ford
-
Replace Mateusz as Maintainer for ARM Snapdragon arch.
Signed-off-by: Ramon Fried
Acked-by: Mateusz Kulikowski -
Alignment was wrong, missing one tab. fix it.
Signed-off-by: Ramon Fried
-
Don't continue updating the offset when buffer is full.
When the buffer size exhausts and there's no space left to write
warn the user and update only the needed size and not both the
offset and needed size.Add needed buffer size information in the iotrace command.
Signed-off-by: Ramon Fried
-
Add dump trace command which dump all trace
buffer content in a much more readable fashion
than md.Signed-off-by: Ramon Fried
Reviewed-by: Simon Glass -
The header definitions are needed for reading
record information in cmd/iotrace.cSigned-off-by: Ramon Fried
Reviewed-by: Simon Glass -
Whatever code this was guarding has been removed so remove the guards
too.Signed-off-by: Chris Packham
-
Whatever code this was guarding has been removed so remove the guards
too.Signed-off-by: Chris Packham
-
Remove empty #ifdef/#ifndef..#endif blocks where the configuration they
guarded has been completely removed.Signed-off-by: Chris Packham
-
Contains:
1. Overview of Android Verified Boot 2.0
2. Description of avb subset of commands
3. Examples of errors when boot/vendor/system/vbmeta partitions
are tampered
4. Examples of enabling AVB2.0 on your setupSigned-off-by: Igor Opaniuk
-
1. Run AVB 2.0 full verification chain, avb verify
2. Check if 'avb get_uuid' works, compare results with
'part list mmc 1' output
3. Test `avb read` commands, which reads N bytes from a partition
identified by a nameSigned-off-by: Igor Opaniuk
-
1. Add vbmeta partition info to android partition layout for TI
platforms.
2. Add support of AVB 2.0 (including avb subset of commands) for am57xx HSSigned-off-by: Igor Opaniuk
[trini: Move to include/environment/ti/boot.h, reword commit slightly]
Signed-off-by: Tom Rini -
1. Add initial support of boot states mode (red, green, yellow)
2. Add functions for enforcing dm-verity configurationsSigned-off-by: Igor Opaniuk
-
Enable a "avb" command to execute Android Verified
Boot 2.0 operations. It includes such subcommands:
avb init - initialize avb2 subsystem
avb read_rb - read rollback index
avb write_rb - write rollback index
avb is_unlocked - check device lock state
avb get_uuid - read and print uuid of a partition
avb read_part - read data from partition
avb read_part_hex - read data from partition and output to stdout
avb write_part - write data to partition
avb verify - run full verification chainSigned-off-by: Igor Opaniuk
-
Implement AVB ops on top of existing mmc subsystem API. Currently there
is a full implementation of such operations, defined by [1]
AVB2.0 specification:.read_from_partition() - reads N bytes from a partition identified by
a name.
.write_to_partition() - Writes N bytes to a partition identified by a name.
.validate_vbmeta_public_key() - checks if the given public ‘vbmeta’
partition is trusted.
.get_unique_guid_for_partition() - Gets the GUID for a partition identified
by a string name.As [1] specification recommends to use tamper-evident storage for storing
rollback indexes and device state (LOCKED/UNLOCKED),
currently are only stubs instead of full implementation for these ops:
.read_rollback_index() - Gets the rollback index for a given index location
.write_rollback_index() - Sets the rollback index to a given location
.read_is_device_unlocked() - Gets where the device is unlocked[1] https://android.googlesource.com/platform/external/avb/+/master/README.md
Signed-off-by: Igor Opaniuk
-
Integrate libavb into the build system. Introduce CONFIG_LIBAVB
build option.Signed-off-by: Igor Opaniuk
-
Add libavb lib (3rd party library from AOSP), that implements support of
AVB 2.0. This library is used for integrity checking of Android partitions
on eMMC.libavb was added as it is and minimal changes were introduced to reduce
maintenance cost, because it will be deviated from AOSP upstream in the future.Changes:
- license headers changed to conform SPDX-style
- avb_crc32.c dropped
- updates in avb_sysdeps_posix.c/avb_sysdeps.hFor additional details check [1] AVB 2.0 README.
[1] https://android.googlesource.com/platform/external/avb/+/master/README.md
Signed-off-by: Igor Opaniuk
17 Jun, 2018
10 commits
-
Currently when EFI application boots, it says:
CPU: x86_64, vendor , device 0h
Fix this by calling x86_cpu_init_f() in arch_cpu_init().
Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
To avoid confusion, let's rename the efi-x86 target to efi-x86_app.
Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
This turns on the EFI framebuffer driver support so that a graphics
console can be of additional help.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
This adds a DM video driver for U-Boot as the EFI payload. The driver
makes use of all necessary information from the passed EFI GOP info
to create a linear framebuffer device, as if it were initialized by
U-Boot itself.Signed-off-by: Bin Meng
Reviewed-by: Anatolij Gustschin -
If UEFI BIOS has the graphics output protocol (GOP), let's pass its
information to U-Boot payload so that U-Boot can utilize it (eg:
an EFI framebuffer driver).Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
Now that we have generic EFI payload support, drop EFI-specific test
logics in BayTrail Kconfig and codes, and all BayTrail boards too.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
Now that we have generic EFI payload support for all x86 boards,
drop the QEMU-specific one.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
It is possible to create a generic EFI payload for all x86 boards.
The payload is configured to include as many generic drivers as
possible. All stuff that touches low-level initialization are not
allowed as such is the EFI BIOS's responsibility. Platform specific
drivers (like gpio, spi, etc) are not included.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
This adds arch_cpu_init() to the payload codes, in preparation for
supporting a generic efi payload.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass -
At present the EFI application and payload support codes in the x86
directory is distributed in a hybrid way. For example, the Kconfig
options for both app and payload are in arch/x86/lib/efi/Kconfig,
but the source codes in the same directory get built only for
CONFIG_EFI_STUB.This refactors the codes by consolidating all the EFI support codes
into arch/x86/cpu/efi, just like other x86 targets.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass
