24 Feb, 2018
1 commit
-
This patch fixes the below warning by typecasting it properly
fs/ubifs/ubifs.c: In function 'ubifs_load':
fs/ubifs/ubifs.c:942:29: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
err = ubifs_read(filename, (void *)addr, 0, size, &actread);Signed-off-by: Siva Durga Prasad Paladugu
Signed-off-by: Michal Simek
Reviewed-by: Heiko Schocher
(cherry picked from commit 34cc30af27165696a36274394f6ff019ed762ce6)
13 Feb, 2017
1 commit
-
We repeated partial moves for CONFIG_SYS_NO_FLASH, but this is
not completed. Finish this work by the tool.During this move, let's rename it to CONFIG_MTD_NOR_FLASH.
Actually, we have more instances of "#ifndef CONFIG_SYS_NO_FLASH"
than those of "#ifdef CONFIG_SYS_NO_FLASH". Flipping the logic will
make the code more readable. Besides, negative meaning symbols do
not fit in obj-$(CONFIG_...) style Makefiles.This commit was created as follows:
[1] Edit "default n" to "default y" in the config entry in
common/Kconfig.[2] Run "tools/moveconfig.py -y -r HEAD SYS_NO_FLASH"
[3] Rename the instances in defconfigs by the following:
find . -path './configs/*_defconfig' | xargs sed -i \
-e '/CONFIG_SYS_NO_FLASH=y/d' \
-e 's/# CONFIG_SYS_NO_FLASH is not set/CONFIG_MTD_NOR_FLASH=y/'[4] Change the conditionals by the following:
find . -name '*.[ch]' | xargs sed -i \
-e 's/ifndef CONFIG_SYS_NO_FLASH/ifdef CONFIG_MTD_NOR_FLASH/' \
-e 's/ifdef CONFIG_SYS_NO_FLASH/ifndef CONFIG_MTD_NOR_FLASH/' \
-e 's/!defined(CONFIG_SYS_NO_FLASH)/defined(CONFIG_MTD_NOR_FLASH)/' \
-e 's/defined(CONFIG_SYS_NO_FLASH)/!defined(CONFIG_MTD_NOR_FLASH)/'[5] Modify the following manually
- Rename the rest of instances
- Remove the description from README
- Create the new Kconfig entry in drivers/mtd/Kconfig
- Remove the old Kconfig entry from common/Kconfig
- Remove the garbage comments from include/configs/*.hSigned-off-by: Masahiro Yamada
29 Jan, 2017
1 commit
-
Doing unaligned reads is not supported on all architectures, use
byte sized reads of the little endian buffer.
Rename off16 to off8, as it reflects the buffer offset in byte
granularity (offset is in entry, i.e. 12 bit, granularity).
Fix a regression introduced in 8d48c92b45aea91e2a2be90f2ed93677e85526f1Reported-by: Oleksandr Tymoshenko
Signed-off-by: Stefan Brüns
Tested-by: Oleksandr Tymoshenko
28 Jan, 2017
1 commit
-
We convert CONFIG_PARTITION_UUIDS to Kconfig first. But in order to cleanly
update all of the config files we must also update CMD_PART and CMD_GPT to also
be in Kconfig in order to avoid complex logic elsewhere to update all of the
config files.Signed-off-by: Patrick Delaunay
Signed-off-by: Patrick Delaunay
Signed-off-by: Tom Rini
28 Dec, 2016
5 commits
-
genext2fs creates revision level 0 filesystems, which are not readable
by u-boot due to the initialized group descriptor size field.
f798b1dda1c5de818b806189e523d1b75db7e72dReported-by: Kever Yang
Reported-by: FrostyBytes@protonmail.com
Signed-off-by: Stefan Brüns
Tested-by: Kever Yang -
Instead of shuffling bits from two adjacent 16 bit words, use one 16 bit
word with the appropriate byte offset in the buffer.Signed-off-by: Stefan Brüns
-
get_fatent_value(...) flushes changed FAT entries to disk when fetching
the next FAT blocks, in every other aspect it is identical to
get_fatent(...).Provide a stub implementation for flush_dirty_fat_buffer if
CONFIG_FAT_WRITE is not set. Calling flush_dirty_fat_buffer during read
only operation is fine as it checks if any buffers needs flushing.Signed-off-by: Stefan Brüns
Reviewed-by: Benoît Thébaudeau -
The FAT is read/flushed in segments of 6 (FATBUFBLOCKS) disk sectors. The
last segment may be less than 6 sectors, cap the length.Signed-off-by: Stefan Brüns
Reviewed-by: Benoît Thébaudeau -
The u-boot command fatwrite empties FAT clusters from the beginning
till the end of the file.
Specifically for FAT12 it fails to detect the end of the file and goes
beyond the file bounds thus corrupting the file system.Additionally, FAT entry chaining-up into a file is not implemented
for FAT12.The users normally workaround this by re-formatting the partition as
FAT16/FAT32, like here:
https://github.com/FEDEVEL/openrex-uboot-v2015.10/issues/1The patch fixes the bounds of a file and FAT12 entries chaining into
a file, including EOF markup.Signed-off-by: Philipp Skadorov
03 Dec, 2016
1 commit
-
Now that we free resources in sandbox_fs_ls Coverity is letting us know
that in some cases we might leak. So in case of error we should still
let os_dirent_free free anything that was allocated.Fixes: 86167089b71c ("sandbox/fs: Free memory allocated by os_dirent_ls")
Reported-by: Coverity (CID: 153450)
Cc: Stefan Brüns
Cc: Simon Glass
Signed-off-by: Tom Rini
Reviewed-by: Simon Glass
29 Nov, 2016
1 commit
-
fill_dir_slot use get_contents_vfatname_block as a temporary buffer for
constructing a list of dir_slot entries. To save the memory and providing
correct type of memory for above usage, a local buffer with accurate size
declaration is introduced.The local array size 640 is used because for long file name entry,
each entry use 32 bytes, one entry can store up to 13 characters.
The maximum number of entry possible is 20. So, total size is
32*20=640bytes.Signed-off-by: Genevieve Chan
Signed-off-by: Tien Fong Chee
22 Nov, 2016
2 commits
-
Support was already implemented, but not hooked up. This fixes several
fails in the test cases.Signed-off-by: Stefan Brüns
Acked-by: Stephen Warren -
A sparse file may have regions not mapped by any extents, at the start
or at the end of the file, or anywhere between, thus not finding a
matching extent region is never an error.Found by python filesystem tests.
Signed-off-by: Stefan Brüns
31 Oct, 2016
1 commit
-
Signed-off-by: Vagrant Cascadian
Reviewed-by: Simon Glass
24 Oct, 2016
3 commits
-
Instead of creating a journal entry for each directory block, even
if the block is unmodified, only log the modified block.Signed-off-by: Stefan Brüns
Reviewed-by: Tom Rini
Reviewed-by: Lukasz Majewski -
The direntlen checks were quite bogus, i.e. the loop termination used
"len + offset == blocksize" (exact match only), and checked for a
direntlen less than 0. The latter can never happen as the len is
unsigned, this has been reported by Coverity, CID 153384.Use the same code as in search_dir for directory traversal. This code
has the correct checks for direntlen >= sizeof(struct dirent), and
offset < blocksize.Signed-off-by: Stefan Brüns
Reported-by: Coverity (CID: 153383, 153384)
Reviewed-by: Tom Rini
Reviewed-by: Lukasz Majewski -
Use the same variable names as in search_dir, to make purpose of variables
more obvious.Signed-off-by: Stefan Brüns
Reviewed-by: Tom Rini
12 Oct, 2016
1 commit
-
Signed-off-by: Stefan Brüns
Acked-by: Simon Glass
24 Sep, 2016
2 commits
-
Now, arch/${ARCH}/include/asm/errno.h and include/linux/errno.h have
the same content. (both just wrap )Replace all include directives for with .
Signed-off-by: Masahiro Yamada
[trini: Fixup include/clk.]
Signed-off-by: Tom Rini -
We are supposed to use #include to include headers in the
public include paths. We should use #include "..." only for headers
in local directories.Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
23 Sep, 2016
20 commits
-
Enable mounting of ext4 fs with 64bit feature, as it is supported now.
These had been disabled in 6f94ab6656ceffb3f2a972c8de4c554502b6f2b7.Signed-off-by: Stefan Brüns
-
Also adjust high 16/32 bits when free inode/block counts are modified.
Signed-off-by: Stefan Brüns
-
The descriptor size is variable, thus array indices are not generically
applicable. The larger group descriptors also contain e.g. high parts
of block numbers, which have to be read and written.Signed-off-by: Stefan Brüns
-
The correct descriptor size must be used when calculating offsets, and
also to read the correct amount of data.Signed-off-by: Stefan Brüns
-
The helper functions encapsulate access of the block group descriptors,
independent of group descriptor size. The helpers also deal with the
endianess of the fields, and with split fields like free_blocks/
free_blocks_high.Signed-off-by: Stefan Brüns
-
If EXT4_FEATURE_INCOMPAT_64BIT is set, the descriptor can be read from
the superblocks, otherwise it defaults to 32.Signed-off-by: Stefan Brüns
-
If the same block is updated multiple times in a row during a single
file system operation, gd_index is decremented to use the same journal
entry again. Avoid loosing the already allocated buffer.Signed-off-by: Stefan Brüns
-
read_allocated block may return block number 0, which is just an indicator
a chunk of the file is not backed by a block, i.e. it is sparse.During file deletions, just continue with the next logical block, for other
operations treat blocknumber -
The data blocks are identical for files using traditional direct/indirect
block allocation scheme and extent trees, thus this code part can be
common. Only the code to deallocate the indirect blocks to record the
used blocks has to be seperate, respectively the code to release extent
tree index blocks.Actually the code to release the extent tree index blocks is still missing,
but at least add a FIXME at the appropriate place.Signed-off-by: Stefan Brüns
-
Make sure the the extra_isize field (offset 128) is initialized to 0, to
mark any extra data as invalid.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
fs->inodesz is already correctly (i.e. dependent on fs revision)
initialized in ext4fs_mount.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
temp_ptr should always be freed, even if the function is left via
goto fail.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
If the blocksize is 1024, count is initialized with 1. Incrementing count
by 8 will never match (count == fs->blksz * 8), and ptr may be
incremented beyond the buffer end if the bitmap is filled. Add the
startblock offset after the loop.Remove the second loop, as only the first iteration will be done.
Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
The last free block of a block group may be in its middle. After it has
been allocated, the next block group should be scanned from its beginning.The following command triggers the bad behaviour (on a blocksize 1024 fs):
./sandbox/u-boot -c 'i=0; host bind 0 ./disk.raw ;
while test $i -lt 260 ; do echo $i; setexpr i $i + 1;
ext4write host 0:2 0 /X${i} 0x1450; done ;
ext4write host 0:2 0 /X240 0x2000 ; 'When 'X240' is extended from 5200 byte to 8192 byte, the new blocks should
start from the first free block (8811), but it uses the blocks 8098-8103
and 16296-16297 -- 8103 + 1 + 8192 = 16296. This can be shown with
debugfs, commands 'ffb' and 'stat X240'.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
zero_buffer is never written, thus clearing it is pointless.
journal_buffer is completely initialized by ext4fs_devread (or in case
of failure, not used).Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
e2fsck warns about "Group descriptor 0 marked uninitialized without
feature set."
The bg_itable_unused field is only defined if FEATURE_RO_COMPAT_GDT_CSUM
is set, and should be set (kept) zero otherwise.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
Scanning only the direct blocks of the directory file may falsely report
an existing file as nonexisting, and worse can also lead to creation
of a duplicate entry on file creation.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
While directories can be read using the old linear scan method, adding a
new file would require updating the index tree (alternatively, the whole
tree could be removed).Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
Previously, only the last directory block was scanned for available space.
Instead, scan all blocks back to front, and if no sufficient space is
found, eventually append a new block.
Blocks are only appended if the directory does not use extents or the new
block would require insertion of indirect blocks, as the old code does.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski -
The following command crashes u-boot:
./sandbox/u-boot -c 'i=0; host bind 0 ./sandbox/test/fs/3GB.ext4.img ;
while test $i -lt 200 ; do echo $i; setexpr i $i + 1;
ext4write host 0 0 /foobar${i} 0; done'Previously, the code updated the direct_block even for extents, and
fortunately crashed before pushing garbage to the disk.Signed-off-by: Stefan Brüns
Reviewed-by: Lukasz Majewski