28 Jan, 2020
1 commit
-
XOM pins provide information for iROM bootloader about the boot device.
Those pins are mapped to lower bits of OP_MODE register (0x10000008),
which is common for all Exynos SoC variants. Set the default MMC device id
to reflect the boot device selected by XOM[7:5] pins (2 for the SD or 0 for
the eMMC).Signed-off-by: Marek Szyprowski
Signed-off-by: Minkyu Kang
23 Jan, 2020
2 commits
-
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by
name") one has to provide full name to get requested object. Fix the code
used to detect enable power regulators on the supported Exynos boards to
use proper PMIC device device name then.Signed-off-by: Marek Szyprowski
Reviewed-by: Anand Moon
Reviewed-by: Lukasz Majewski
Signed-off-by: Minkyu Kang -
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by
name") one has to provide full name to get requested object. Fix the code
used to detect Odroid board revision to use proper ADC device name then.Signed-off-by: Marek Szyprowski
Reviewed-by: Anand Moon
Signed-off-by: Minkyu Kang
18 Jan, 2020
2 commits
-
At present panic() is in the vsprintf.h header file. That does not seem
like an obvious choice for hang(), even though it relates to panic(). So
let's put hang() in its own header.Signed-off-by: Simon Glass
[trini: Migrate a few more files]
Signed-off-by: Tom Rini -
These functions relate to memory init so move them into the init
header.Signed-off-by: Simon Glass
03 Dec, 2019
3 commits
-
A number of board function belong in init.h with the others. Move them.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
Move these functions into the command.h header file which is a better fit.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
These functions belong in cpu_func.h so move them over.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
12 Aug, 2019
2 commits
-
Move env_get() over to the new header file.
Acked-by: Joe Hershberger
Signed-off-by: Simon Glass -
Move env_set() over to the new header file.
Acked-by: Joe Hershberger
Signed-off-by: Simon Glass
14 Mar, 2019
1 commit
-
set status to Maintained
Signed-off-by: Minkyu Kang
Cc: Krzysztof Kozlowski
11 Mar, 2019
6 commits
-
CONFIG_BOARD_TYPES is necessary for Odroid X/X2/U3 boards to detect
proper revision. However building should succeed even without it.
While moving code around, document also the reference clock selection.This fixes the build error without CONFIG_BOARD_TYPES:
board/samsung/odroid/odroid.c: In function 'board_usb_init':
board/samsung/odroid/odroid.c:473:8: error: 'gd_t' {aka 'volatile struct global_data'} has no member named 'board_type'
if (gd->board_type == ODROID_TYPE_U3)
^~Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Minkyu Kang -
Various places in the code set "boardname" env property. It was used
for booting from ITB images and choosing proper DTB file name. Instead
of duplicating it, use existing U-Boot wide - "board_name".Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Signed-off-by: Minkyu Kang -
Last activity from Arndale (Exynos5250) board maintainer Chander Kashyap
was in January 2014 (Signed-off). Recently his samsung.com email
bounces with 550 (5.1.1 Recipient address rejected: User unknown).Add Krzysztof Kozlowski as odd fixer for this board.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Minkyu Kang -
Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled
the LDO4/VDD_ADC regulator.The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on
AIN9 will rise slowly, so use delay of 5 milliseconds instead of
timers-based loop to wait for voltage stabilization.First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308
(reference value is 1309).Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang -
Printing the "Type" of board requires proper detection of revision which
can happen only late because regulators are needed.Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang -
Detection of board revision is done early - before power setup. In case of
Odroid XU3/XU4/HC1 family, the detection is done using ADC which
is supplied by LDO4/VDD_ADC regulator. This regulator could be turned
off (e.g. by kernel before reboot). If ADC is used early, the
regulators are not yet available and the detection won't work.Split the revision detection out of set_board_type() into separate
function called later - either when displaying board info (in late mode)
or during misc_init_r. The idea is that set_board_type() will be called
early so its method of detection are limited to flattened device tree
(exynos5-dt-types.c for Exynos5) or GPIO (odroid.c for Exynos4412). The
newly added set_board_revision() can be called only later, when
resources like regulator are available.This is necessary to fix the detection of Odroid HC1 after reboot, if
kernel turned off the LDO4 regulator.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang
10 Feb, 2019
3 commits
-
Now that these boards use driver model we can drop the old code. At
present s5p_mmc_init() is still used by goni and smdkv310 so cannot be
removed unless we remove those boards.Signed-off-by: Simon Glass
Reviewed-by: Lukasz Majewski
Reviewed-by: Minkyu Kang -
This function is not needed now since the audio codecs have been converted
to proper drivers. The codec-enable GPIO is handled there.Signed-off-by: Simon Glass
Reviewed-by: Lukasz Majewski
Reviewed-by: Minkyu Kang -
At present the model is shown twice, once in the generic code and once
in the exynos code. Drop the latter.Signed-off-by: Simon Glass
Reviewed-by: Lukasz Majewski
Reviewed-by: Minkyu Kang
27 Jan, 2019
1 commit
-
Make use of "IMAGE_MAX_SIZE" and "IMAGE_TEXT_BASE" rather than
CONFIG_SPL_MAX_SIZE and CONFIG_SPL_TEXT_BASE. This lets us re-use the
same script for both SPL and TPL. Add logic to scripts/Makefile.spl to
pass in the right value when preprocessing the script.Cc: Stefano Babic
Cc: Fabio Estevam
Cc: Jagan Teki
Cc: Maxime Ripard
Cc: Andreas Bießmann
Cc: Philipp Tomsich
Cc: Michal Simek
Cc: Daniel Schwierzeck
Cc: York Sun
Cc: Bin Meng
Cc: Heiko Schocher
Cc: Adam Ford
Signed-off-by: Tom Rini
Reviewed-by: Daniel Schwierzeck
Tested-by: Daniel Schwierzeck
Tested-by: Adam Ford #da850evm & omap3_logic_somlv
Reviewed-by: Simon Goldschmidt
21 Nov, 2018
1 commit
-
This function is really just a call to uclass_get_device() and there is no
reason why the caller cannot do it. Update sandbox and snow accordingly.Signed-off-by: Simon Glass
Acked-by: Minkyu Kang
23 Oct, 2018
1 commit
-
Odroid HC2 board is based on Odroid XU4 board, like the Odroid HC1.
The linux kernel does not provide a hc2 DTB so the hc1 DTB is also used
for the Odroid HC2.Resend because MUA changed whitespace.
Signed-off-by: Dirk Meul
Acked-by: Marek Szyprowski
Reviewed-by: Lukasz Majewski
Signed-off-by: Minkyu Kang
06 Aug, 2018
2 commits
-
Signed-off-by: Lukasz Majewski
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang -
This commit adjusts the autoboot.cmd file to use ${mmcbootdev} instead of
hardcoded value 0.This is necessary to allow booting this board from the SD card.
Signed-off-by: Lukasz Majewski
Tested-by: Anand Moon
Signed-off-by: Minkyu Kang
08 Jun, 2018
1 commit
-
After the commit 9b643e312d52 ("treewide: replace with error() with
pr_err()"), there are some pr_err() with no line break. Add missing
line breaks.Signed-off-by: Seung-Woo Kim
Reviewed-by: Minkyu Kang
07 May, 2018
1 commit
-
When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from. So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry. Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents. There's also a few places where I found we did not have a tag
and have introduced one.Signed-off-by: Tom Rini
02 May, 2018
1 commit
-
Exynos5422 board has s2mps11 pmic.
If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and Regulators
during booting time.Signed-off-by: Jaehoon Chung
Tested-by: Anand Moon
28 Apr, 2018
1 commit
-
We have a large number of places where while we historically referenced
gd in the code we no longer do, as well as cases where the code added
that line "just in case" during development and never dropped it.Signed-off-by: Tom Rini
10 Jan, 2018
1 commit
-
Given gcc-6.1 and later we can now safely have strings discarded when
the functions are unused. This lets us drop certain cases of not
building something so that we don't have the strings brought in when the
code was discarded. Simplify the code now by dropping guards we don't
need now.Cc: Stefano Babic
Cc: Fabio Estevam
Cc: Chander Kashyap
Cc: Thomas Abraham
Cc: Vipin Kumar
Cc: Wenyou Yang
Signed-off-by: Tom Rini
05 Dec, 2017
1 commit
-
Odroid HC1 board is based on Odroid XU4 board, but it has no HDMI,
no eMMC, no build-in USB3.0 hub, no extension port pins, and no GPIO
button. USB3.0 ports are used for build-in JMicron USB to SATA bridge
and Gigabit R8152 ethernet chips. HC1 uses only passive cooling.This patch also updates Odroid's ADCmax array and reduces ADC tolerance
to 1% to ensure that XU4 and HC1 revisions are properly detected.I've tested this with XU3, XU3-lite, XU4 and HC1 boards. In case of my test
boards I got following values from ADC register: 372, 370, 1281 and 1313.Signed-off-by: Marek Szyprowski
Reviewed-by: Lukasz Majewski
Tested-by: Krzysztof Kozlowski
Signed-off-by: Minkyu Kang
06 Nov, 2017
1 commit
-
As part of my usual round of build testing, output about missing
MAINTAINERS information was not logged, and thus often overlooked.
Correct that mistake by ensuring that I log the output of
genboardscfg.py every time. As part of that, address a number of
missing MAINTAINERS entires. In the case of a missing file, I have put
the original submitter down. In the rest of the cases I have added the
config (and sometimes relevant header file) to the existing set of file
globs.Signed-off-by: Tom Rini
05 Oct, 2017
1 commit
04 Oct, 2017
2 commits
-
U-Boot widely uses error() as a bit noisier variant of printf().
This macro causes name conflict with the following line in
include/linux/compiler-gcc.h:# define __compiletime_error(message) __attribute__((error(message)))
This prevents us from using __compiletime_error(), and makes it
difficult to fully sync BUILD_BUG macros with Linux. (Notice
Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)Let's convert error() into now treewide-available pr_err().
Done with the help of Coccinelle, excluing tools/ directory.
The semantic patch I used is as follows:
//
@@@@
-error
+pr_err
(...)
//Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
[trini: Re-run Coccinelle]
Signed-off-by: Tom Rini -
The g_dnl USB settings for the vendor ID, product ID and manufacturer are
actually common settings that can and should be shared by all the gadgets.Make them common by renaming them, and convert all the users.
Reviewed-by: Simon Glass
Reviewed-by: Lukasz Majewski
Signed-off-by: Maxime Ripard
16 Aug, 2017
2 commits
-
We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename setenv()
for consistency. Also add function comments in common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass
05 Jun, 2017
1 commit
-
Rather than relying on common.h to provide this include, which is going
away at some point, include it explicitly in each file.Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
01 Jun, 2017
2 commits
-
We should not be including a PMIC header file in the board config. Move it
to a C file.Signed-off-by: Simon Glass
-
Add support for requesting GPIOs with a live device tree.
This involves adjusting the function signature for the legacy function
gpio_request_by_name_nodev(), so fix up all callers.Signed-off-by: Simon Glass
Fixes to stm32f746-disco.c:
Signed-off-by: Tom Rini