Eric Lee / smarc-uboot

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    56

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

20 Jan, 2018

1 commit

06 Dec, 2017

1 commit

  • c8e1ca3eb   tools: omapimage: fix corner-case in byteswap path ... Browse Code »

    Since commit 2614a208471e ("common: command: tempory buffer should
    have size of command line buf"), there have been consistent Travis CI
    failures on my builds (interestingly not for Tom, even though building
    the same commit id) due to a SEGV in building the byteswapped
    omapimage:
    arm: pcm051_rev3
    make[2]: *** [MLO.byteswap] Error 139
    ^^^ error code for a SEGV

    Turns out that the word-based byte-swapping loop in omapimage.c is to
    blame. With the loop condition
    while (swapped st_size / sizeof(uint32_t)))
    there had been one-too-many iterations for all file sizes divisible by
    the sizeof(uint32_t). I.e. we had 1 iteration for 0 bytes (and also 1
    through 3 bytes) and 2 iterations at 4 bytes... clearly overshooting
    on 0 and 4 bytes.

    This commit fixes the calculation of an up-rounded word-count and
    makes sure to keep the zero-based loop-counter below the number of
    words to be processed.

    References: 2614a20 ("common: command: tempory buffer should have size of command line buf")
    Fixes: 79b9ebb ("omapimage: Add support for byteswapped SPI images")
    Signed-off-by: Philipp Tomsich
    Reviewed-by: Martin Elshuber

    Philipp Tomsich
     

15 Mar, 2017

1 commit

30 Jan, 2015

1 commit

18 Apr, 2014

1 commit

13 Dec, 2013

1 commit

  • f86ed6a8d   tools: moved code common to all image tools to a separated module. ... Browse Code »
    43

    In order to avoid duplicating code and keep only one point of modification,
    the functions, structs and defines useful for "dumpimage" were moved from
    "mkimage" to a common module called "imagetool".

    This modification also weakens the coupling between image types (FIT, IMX, MXS,
    and so on) and image tools (mkimage and dumpimage). Any tool may initialize the
    "imagetool" through register_image_tool() function, while the image types
    register themselves within an image tool using the register_image_type()
    function:

    +---------------+
    +------| fit_image |
    +--------------+ +-----------+ | +---------------+
    | mkimage |--------> | | | |
    Signed-off-by: Simon Glass

    Guilherme Maciel Ferreira
     

15 Oct, 2013

1 commit

17 Aug, 2013

1 commit

  • 2db1c3fc6   tools/Makefile: Move _GNU_SOURCE to Makefile ... Browse Code »

    Commit 669dfc2e adds libfdt_env.h to HOSTCPPFLAGS. It causes stdio.h
    to be included before _GNU_SOURCE is defined in C files. On some old hosts
    some prototypes are protected by #ifdef __USE_GNU, which is set when
    _GNU_SOURCE is defined.

    Signed-off-by: York Sun
    Acked-by: Simon Glass

    York Sun
     

24 Jul, 2013

1 commit

26 Oct, 2012

1 commit

04 Sep, 2011

1 commit

  • 8fcf5959a   mkimage: Fix 'Unknown OMAP image type - 5' ... Browse Code »

    Using mkimage with e.g.

    tools/mkimage -A arm -T firmware -O u-boot -d u-boot.bin foo.img

    gives a warning

    "Unknown OMAP image type - 5"

    while it seems that the image itself is created successfully.

    This does come from the patch "mkimage: Add OMAP boot image support".

    The method check_image_type in image_type_params is supposed to just
    return success or failure. However, for omap it also calls fprintf:

    static int omapimage_check_image_types(uint8_t type)
    {
    if (type == IH_TYPE_OMAPIMAGE)
    return EXIT_SUCCESS;
    else {
    fprintf(stderr, "Unknown OMAP image type - %x", type);
    return EXIT_FAILURE;
    }
    }

    All the other image checkers and no others have this, so the fix is to
    simply remove the fprintf.

    Signed-off-by: Dirk Behme
    CC: John Rigby
    CC: Aneesh V
    CC: Sandeep Paulraj

    Dirk Behme
     

03 Aug, 2011

1 commit