27 Jul, 2018
28 commits
-
Because some phy wants to export some functions [1], export.h was
including the whole phy subsystem which pulls in lots of stuff that
causes some ordering and redefinition issues. Split out the only part
that is actually needed in export.h and include it there and in phy.h.[1] commit 95279315076c ("board/ls2085rdb: Export functions for
standalone AQ FW load apps")Signed-off-by: Joe Hershberger
-
The include/phy.h will start including dm.h, which pulls in
linux/compat.h after the attempted redefinition in
arch/arm/include/asm/armv8/mmu.h, so move this include to allow
redefinition.Signed-off-by: Joe Hershberger
-
Switch to use more generic ofnode API instead of FDT API.
Signed-off-by: Grygorii Strashko
Acked-by: Joe Hershberger
Tested-by: Siva Durga Prasad Paladugu -
The data manual for DP83867IR/CR, SNLS484E[1], revised march 2017,
advises that strapping RX_DV/RX_CTRL pin in mode 1 and 2 is not
supported (see note below Table 5 (4-Level Strap Pins)).It further advises that if a board has this pin strapped in mode 1 and
mode 2, then bit[7] of Configuration Register 4 (address 0x0031) must
be cleared to 0. This is to ensure proper operation of PHY.Since it is not possible to detect in software if RX_DV/RX_CTRL pin is
incorrectly strapped, add a device-tree property to advertise this and
allow corrective action in software.
[1] http://www.ti.com/lit/ds/snls484e/snls484e.pdfSigned-off-by: Murali Karicheri
Reviewed-by: Hannes Schmelzer
Acked-by: Joe Hershberger
Tested-by: Siva Durga Prasad Paladugu -
Add driver model support to the mvgbe driver. As a temporary measure
both DM and non-DM uses are supported. Once all the users have been
converted the non-DM support can be dropped.Signed-off-by: Chris Packham
Tested-by: Michael Walle
Acked-by: Joe Hershberger -
Extract some function bodies to helper functions that can be reused in
the DM/non-DM implementations.Signed-off-by: Chris Packham
Acked-by: Joe Hershberger -
if_type is not correctly initialized
Failure to initialize if_type means that grub2/efinet sends
a bogus arp request. It therefore gets no response. On Raspberry Pi 3B+
this leads to a pause at:lan78xx_eth Waiting for PHY auto negotiation to complete....... done
lan78xx_eth Waiting for PHY auto negotiation to complete....... doneSigned-off-by: Andrew Thomas
Acked-by: Joe Hershberger -
The same basic parsing was implemented in tftp and nfs, so add a helper
function to do the work once.Signed-off-by: Joe Hershberger
-
Instead of depending on a env callback for bootfile, read it explicitly.
We do this because the bootfile can be specified on the command line and
if it is, we will overwrite the internal variable. If a netboot_common()
is called again with no bootfile parameter, we want to use the one in
the environment.Signed-off-by: Joe Hershberger
-
Rather than crashing, check the src ptr and set dst to empty string.
Signed-off-by: Joe Hershberger
-
With net autoload, we check the prerequisites for the initial command,
but the greater prerequisites when autoloading are not checked.If we would attempt to autoload, check those prerequisites too.
If we are not expecting a serverip from the server, then don't worry
about it not being set, but don't attempt to load if it isn't.Signed-off-by: Joe Hershberger
-
For net_boot_common, we allow the serverip to be specified as part of
the boot file name. For net commands that require serverip, include that
source as a valid specification of serverip.Signed-off-by: Joe Hershberger
Reviewed-by: Alexander Graf -
nfs was only printing basic info about the transfer in the case of a
DEBUG build. Print the same level of detail as tftp always.Signed-off-by: Joe Hershberger
-
The check for sending to the gateway was not using the correct variable
for comparison, so it was reporting that packets are sent to the gateway
when they were not.Signed-off-by: Joe Hershberger
-
Reported-by: Coverity (CID: 152888)
Signed-off-by: Joe Hershberger -
Ask the OS for each of its interfaces and for each one, bind a U-Boot
device and then probe it. This will allocate the priv data structure
that is then populated.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
We don't necessarily know how many MAC addresses we'll need, so implement
a ROM read so we always have something valid.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
With systemd stable interface names, eth0 will almost never exist.
Instead of using that name in the sandbox.dts, use an index.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Instead of doing a simple string compare against "lo", look for the flag
that indicates a localhost interface.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Use the dev_ functions to access DT properties.
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
If we let descriptors equal 0, we can end up closing STDIN. Make sure
they start out as -1.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
With driver model, we were not checking if the state of the device was
marked as active before calling the halt function. Check that the device
is probed and also marked as active. This avoids the case where we were
calling halt on the first device in net_init() and the driver would
operate on bogus data structures causing problems. In this case, the
priv was all 0, so halt() would close STDIN.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
test.dts specified the fake MAC address as a u32 array. Instead it
should be a u8 array.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
In open, the socket is correctly checked to be -1 in the error case.
In send and recv, we checked for 0, but that is a valid socket number.Correct this by checking for -1 as a bad socket everywhere.
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
In raw mode, handle ctrl-c as normal. This allows normal ctrl-c behavior
such as aborting a command that is timing out without completely
terminating the sandbox executable.In [1], Simon disabled this. His reason for it was that it interferes
with piping test scripts. Piping should be done in cooked mode, so this
change should still not interfere.[1] commit 8969ea3e9f2db04a6b3675 ("sandbox: Disable Ctrl-C")
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
We don't necessarily want to re-enable ctrl-c if it was already disabled
when calling tstc().Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
26 Jul, 2018
1 commit
-
Now that we have removed the DocBook files we need to not try and clean
that directory.Reported-by: ericywl
Reported-by: Jagan Teki
Fixes: 78a88f7930be ("doc: Replace DocBook with sphinx-based docs")
Signed-off-by: Tom Rini
25 Jul, 2018
10 commits
-
Switch to the distro boot for UniPhier platform.
- Remove the environment vairalbes used to load images from raw
block devices.- Keep the command to download images via tftp. This will be
useful to boot the kernel when no valid kernel image is ready
yet in the file system.- Use root.cpio.gz instead of root.cpio.uboot because we always know
the file size of the init ramdisk; it is loaded via either a file
system or network.- Rename fit_addr_r to kernel_addr_r, which the distro command
checks to get the load address of FIT image.Signed-off-by: Masahiro Yamada
-
Enable "mtdparts" and "ubi" commands for uniphier_v8_defconfig to
use UBI on NAND devices.Enable only "mtdparts" for uniphier_{v7,ld4_sld8}_defconfig because
enabling UBI would increase 170KB, which would be memory footprint
problem.Signed-off-by: Masahiro Yamada
-
Propagate the "mtdparts" environment variable to the DT passed
in to OS.Signed-off-by: Masahiro Yamada
-
Prepare to add more fdt fixup code.
Signed-off-by: Masahiro Yamada
-
The 'bd' is passed in ft_board_setup() as the second argument.
Replace 'gd->bd' with 'bd'.Signed-off-by: Masahiro Yamada
-
Add 'const' (also 'static' in some places) to struct node_info
arrays to save memory footprint.Signed-off-by: Masahiro Yamada
-
The second argument of fdt_fixup_mtdparts() is an opaque pointer,
'void *node_info', hence callers can pass any pointer.Obviously, fdt_fixup_mtdparts() expects 'struct node_info *'
otherwise, it crashes run-time.Change the prototype so that it is compile-time checked.
Also, add 'const' qualifier to it so that callers can constify
the struct node_info arrays.Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass -
The NAND framework makes sure to pass in the buffer with at least
chip->buf_align alignment. Currently, the Denali NAND driver only
requests 16 byte alignment. This causes unaligned cache operations
for the DMA transfer.[Error Example]
=> nand read 81000010 0 1000
NAND read: device 0 offset 0x0, size 0x1000
CACHE: Misaligned operation at range [81000010, 81001010]
CACHE: Misaligned operation at range [81000010, 81001010]
CACHE: Misaligned operation at range [81000010, 81001010]
CACHE: Misaligned operation at range [81000010, 81001010]
4096 bytes read: OKReported-by: Marek Vasut
Signed-off-by: Masahiro Yamada -
cherry-pick kernel commit 2ae89c7 (2018-06-05)
to avoid warnings when compiling with GCC 8.1In file included from scripts/kconfig/zconf.tab.c:2486:
scripts/kconfig/confdata.c: In function ‘conf_write’:
scripts/kconfig/confdata.c:771:22: warning: ‘%s’ directive writing likely 7 or more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
sprintf(newname, "%s%s", dirname, basename);
^~
scripts/kconfig/confdata.c:771:19: note: assuming directive output of 7 bytes
sprintf(newname, "%s%s", dirname, basename);
^~~~~~
scripts/kconfig/confdata.c:771:2: note: ‘sprintf’ output 1 or more bytes (assuming 4104) into a destination of size 4097
sprintf(newname, "%s%s", dirname, basename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
scripts/kconfig/confdata.c:774:23: warning: ‘.tmpconfig.’ directive writing 11 bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
^~~~~~~~~~~
scripts/kconfig/confdata.c:774:3: note: ‘sprintf’ output between 13 and 4119 bytes into a destination of size 4097
sprintf(tmpname, "%s.tmpconfig.%d", dirname, (int)getpid());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Signed-off-by: Luis Araneda
Signed-off-by: Masahiro Yamada
24 Jul, 2018
1 commit
-
The patch
"tools/mkimage: Fix DTC run command to handle file names with space"
(sha1: a6e9810495bc929b6beafb88f557cdaadf87fc83) contains comma in name
which is confusing patman. Fix it by defining Mirza's email in mailmap.Signed-off-by: Michal Simek
