Eric Lee / smarc-uboot

02 Apr, 2013

1 commit

  • 472d54605   Consolidate bool type ... Browse Code »

    'bool' is defined in random places. This patch consolidates them into a
    single header file include/linux/types.h, using stdbool.h introduced in C99.

    All other #define, typedef and enum are removed. They are all consistent with
    true = 1, false = 0.

    Replace FALSE, False with false. Replace TRUE, True with true.
    Skip *.py, *.php, lib/* files.

    Signed-off-by: York Sun

    York Sun
     

07 Mar, 2012

3 commits

  • 4c12eeb8b   Convert cmd_usage() calls in common to use a return value ... Browse Code »

    Change all files in common/ to use CMD_RET_USAGE instead of calling
    cmd_usage() directly. I'm not completely sure about this patch since
    the code since impact is small (100 byte or so on ARM) and it might
    need splitting into smaller patches. But for now here it is.

    Signed-off-by: Simon Glass

    Simon Glass
     
  • 530715323   Stop using builtin_run_command() ... Browse Code »

    Boards can select either the 'built-in' parser or the hush parser. We
    should not call builtin_run_command() if we are using the hush parser.
    We use run_command() instead, since it knows how to call the correct
    parser.

    Signed-off-by: Simon Glass
    Acked-by: Mike Frysinger

    Simon Glass
     
  • f47360a74   Rename run_command() to builtin_run_command() ... Browse Code »

    The current run_command() is only one of the parsing options - the other
    is hush. We should not call run_command() when the hush parser is being
    used. So we rename this function to better explain its purpose.

    Signed-off-by: Simon Glass
    Acked-by: Mike Frysinger

    Simon Glass
     

22 Nov, 2011

1 commit

25 Jul, 2010

1 commit

  • 47e26b1bf   cmd_usage(): simplify return code handling ... Browse Code »

    Lots of code use this construct:

    cmd_usage(cmdtp);
    return 1;

    Change cmd_usage() let it return 1 - then we can replace all these
    ocurrances by

    return cmd_usage(cmdtp);

    This fixes a few places with incorrect return code handling, too.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

28 Jan, 2009

2 commits

02 Nov, 2008

1 commit

19 Oct, 2008

1 commit

21 Nov, 2007

1 commit

11 Jul, 2007

1 commit

09 Jul, 2007

1 commit

04 Jul, 2007

1 commit

01 Apr, 2006

1 commit

02 Jul, 2003

1 commit

28 Jun, 2003

1 commit

  • 8bde7f776   * Code cleanup: ... Browse Code »
    46

    - remove trailing white space, trailing empty lines, C++ comments, etc.
    - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)

    * Patches by Kenneth Johansson, 25 Jun 2003:
    - major rework of command structure
    (work done mostly by Michal Cendrowski and Joakim Kristiansen)

    wdenk
     

10 Apr, 2003

1 commit

03 Nov, 2002

1 commit