Eric Lee / smarc-uboot

24 Jul, 2013

1 commit

10 Aug, 2012

1 commit

07 Oct, 2010

1 commit

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

28 Jan, 2009

1 commit

  • 2fb2604d5   Command usage cleanup ... Browse Code »

    Remove command name from all command "usage" fields and update
    common/command.c to display "name - usage" instead of
    just "usage". Also remove newlines from command usage fields.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

14 Oct, 2008

1 commit

04 Jun, 2008

1 commit

  • d255bb0e7   SPI API improvements ... Browse Code »

    This patch gets rid of the spi_chipsel table and adds a handful of new
    functions that makes the SPI layer cleaner and more flexible.

    Instead of the spi_chipsel table, each board that wants to use SPI
    gets to implement three hooks:
    * spi_cs_activate(): Activates the chipselect for a given slave
    * spi_cs_deactivate(): Deactivates the chipselect for a given slave
    * spi_cs_is_valid(): Determines if the given bus/chipselect
    combination can be activated.

    Not all drivers may need those extra functions however. If that's the
    case, the board code may just leave them out (assuming they know what
    the driver needs) or rely on the linker to strip them out (assuming
    --gc-sections is being used.)

    To set up communication parameters for a given slave, the driver needs
    to call spi_setup_slave(). This returns a pointer to an opaque
    spi_slave struct which must be passed as a parameter to subsequent SPI
    calls. This struct can be freed by calling spi_free_slave(), but most
    driver probably don't want to do this.

    Before starting one or more SPI transfers, the driver must call
    spi_claim_bus() to gain exclusive access to the SPI bus and initialize
    the hardware. When all transfers are done, the driver must call
    spi_release_bus() to make the bus available to others, and possibly
    shut down the SPI controller hardware.

    spi_xfer() behaves mostly the same as before, but it now takes a
    spi_slave parameter instead of a spi_chipsel function pointer. It also
    got a new parameter, flags, which is used to specify chip select
    behaviour. This may be extended with other flags in the future.

    This patch has been build-tested on all powerpc and arm boards
    involved. I have not tested NIOS since I don't have a toolchain for it
    installed, so I expect some breakage there even though I've tried
    fixing up everything I could find by visual inspection.

    I have run-time tested this on AVR32 ATNGW100 using the atmel_spi and
    DataFlash drivers posted as a follow-up. I'd like some help testing
    other boards that use the existing SPI API.

    But most of all, I'd like some comments on the new API. Is this stuff
    usable for everyone? If not, why?

    Changed in v4:
    - Build fixes for various boards, drivers and commands
    - Provide common struct spi_slave definition that can be extended by
    drivers
    - Pass a struct spi_slave * to spi_cs_activate and spi_cs_deactivate
    - Make default bus and mode build-time configurable
    - Override default SPI bus ID and mode on mx32ads and imx31_litekit.

    Changed in v3:
    - Add opaque struct spi_slave for controller-specific data associated
    with a slave.
    - Add spi_claim_bus() and spi_release_bus()
    - Add spi_free_slave()
    - spi_setup() is now called spi_setup_slave() and returns a
    struct spi_slave
    - soft_spi now supports four SPI modes (CPOL|CPHA)
    - Add bus parameter to spi_setup_slave()
    - Convert the new i.MX32 SPI driver
    - Convert the new MC13783 RTC driver

    Changed in v2:
    - Convert the mpc8xxx_spi driver and the mpc8349emds board to the
    new API.

    Signed-off-by: Haavard Skinnemoen
    Tested-by: Guennadi Liakhovetski

    Haavard Skinnemoen
     

21 Nov, 2007

1 commit

11 Jul, 2007

1 commit

09 Jul, 2007

1 commit

04 Jul, 2007

1 commit

13 Oct, 2005

1 commit

18 Sep, 2003

1 commit

02 Jul, 2003

1 commit

28 Jun, 2003

1 commit

  • 8bde7f776   * Code cleanup: ... Browse Code »
    46

    - remove trailing white space, trailing empty lines, C++ comments, etc.
    - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)

    * Patches by Kenneth Johansson, 25 Jun 2003:
    - major rework of command structure
    (work done mostly by Michal Cendrowski and Joakim Kristiansen)

    wdenk
     

11 Nov, 2002

1 commit

  • eb9401e3e   * Patch by Andreas Oberritter, 09 Nov 2002: ... Browse Code »

    Change behaviour of NetLoop(): return -1 for errors, filesize
    otherwise; return code 0 is valid an means no file loaded - in this
    case the environment still gets updated!

    * Patches by Jon Diekema, 9 Nov 2002:
    - improve ADC/DAC clocking on the SACSng board to align
    the failing edges of LRCLK and SCLK
    - sbc8260 configuration tweaks
    - add status LED support for 82xx systems
    - wire sspi/sspo commands into command handler; improved error
    handlering
    - add timestamp support and alternate memory test to the
    SACSng configuration

    wdenk
     

01 Oct, 2002

1 commit