Eric Lee / smarc-uboot

24 Feb, 2014

1 commit

  • 61fcc7d27   part_efi: fix protective mbr struct allocation ... Browse Code »

    The calloc() call was allocating space for the sizeof the struct
    pointer rather than for the struct contents.
    Besides, since this buffer is passed to mmc for writing and some
    platforms may use cache, the legacy_mbr struct should be cache-aligned.

    Signed-off-by: Hector Palacios
    Tested-by: Lukasz Majewski

    Hector Palacios
     

20 Feb, 2014

1 commit

  • 6825a95b0   kbuild: use Linux Kernel build scripts ... Browse Code »

    Now we are ready to switch over to real Kbuild.

    This commit disables temporary scripts:
    scripts/{Makefile.build.tmp, Makefile.host.tmp}
    and enables real Kbuild scripts:
    scripts/{Makefile.build,Makefile.host,Makefile.lib}.

    This switch is triggered by the line in scripts/Kbuild.include
    -build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build.tmp obj
    +build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj

    We need to adjust some build scripts for U-Boot.
    But smaller amount of modification is preferable.

    Additionally, we need to fix compiler flags which are
    locally added or removed.

    In Kbuild, it is not allowed to change CFLAGS locally.
    Instead, ccflags-y, asflags-y, cppflags-y,
    CFLAGS_$(basetarget).o, CFLAGS_REMOVE_$(basetarget).o
    are prepared for that purpose.

    Signed-off-by: Masahiro Yamada
    Tested-by: Gerhard Sittig

    Masahiro Yamada
     

09 Jan, 2014

1 commit

  • f4d8de48f   sandbox: block driver using host file/device as backing store ... Browse Code »

    Provide a way to use any host file or device as a block device in U-Boot.
    This can be used to provide filesystem access within U-Boot to an ext2
    image file on the host, for example.

    The support is plumbed into the filesystem and partition interfaces.

    We don't want to print a message in the driver every time we find a missing
    device. Pass the information back to the caller where a message can be printed
    if desired.

    Signed-off-by: Henrik Nordström
    Signed-off-by: Simon Glass
    - Removed change to part.c get_device_and_partition()

    Signed-off-by: Simon Glass
    Reviewed-by: Simon Glass

    Henrik Nordström
     

01 Nov, 2013

1 commit

15 Oct, 2013

1 commit

20 Sep, 2013

1 commit

  • 6d2ee5a33   part_efi: make sure the gpt_pte is freed ... Browse Code »

    the gpt_pte wasn't being freed if it was checked against an invalid
    partition. The resulting memory leakage could make it impossible
    to repeatedly attempt to load non-existent files in a script.

    Also, downgrade the message for not finding an invalid partition
    from a printf() to a debug() so as to minimize message spam in
    perfectly normal situations.

    Signed-off-by: Mark Langsdorf

    Mark Langsdorf
     

24 Jul, 2013

1 commit

22 Jul, 2013

1 commit

  • 50ffc3b64   fs/ext4: fix log2blksz un-initialized error, by cacaulating its value from blksz ... Browse Code »

    The problem here is that uboot can't mount ext4 filesystem with
    commit "50ce4c07df1" applied. We use hard-coded "SECTOR_SIZE"(512)
    before this commit, now we introduce (block_dev_desc_t *)->log2blksz
    to replace this macro. And after we calling do_ls()->fs_set_blk_dev(),
    the variable log2blksz is not initialized, which it's not correct.

    And this patch try to solve the problem by caculating the value of
    log2blksz from variable blksz.

    Lan Yixun (dlan)
     

16 Jul, 2013

1 commit

  • 04735e9c5   Fix ext2/ext4 filesystem accesses beyond 2TiB ... Browse Code »

    With CONFIG_SYS_64BIT_LBA, lbaint_t gets defined as a 64-bit type,
    which is required to represent block numbers for storage devices that
    exceed 2TiB (the block size usually is 512B), e.g. recent hard drives

    We now use lbaint_t for partition offset to reflect the lbaint_t change,
    and access partitions beyond or crossing the 2.1TiB limit.
    This required changes to signature of ext4fs_devread(), and type of all
    variables relatives to block sector.

    ext2/ext4 fs uses logical block represented by a 32 bit value. Logical
    block is a multiple of device block sector. To avoid overflow problem
    when calling ext4fs_devread(), we need to cast the sector parameter.

    Signed-off-by: Frédéric Leroy

    Frederic Leroy
     

05 Jun, 2013

1 commit

  • 67cd4a634   disk: Fix possible out-of-bounds access in part_efi.c ... Browse Code »

    Make sure to never access beyond bounds of either EFI partition name
    or DOS partition name. This situation is happening:

    part.h: disk_partition_t->name is 32-byte long
    part_efi.h: gpt_entry->partition_name is 36-bytes long

    The loop in part_efi.c copies over 36 bytes and thus accesses beyond
    the disk_partition_t->name .

    Fix this by picking the shortest of source and destination arrays and
    make sure the destination array is cleared so the trailing bytes are
    zeroed-out and don't cause issues with string manipulation.

    Signed-off-by: Marek Vasut
    Cc: Tom Rini
    Cc: Simon Glass

    Marek Vasut
     

02 May, 2013

3 commits

  • d7ea4d4d4   disk/iso: Add Support for block sizes > 512 byte to ISO partition support ... Browse Code »

    For ISO we check the block size of the device if this is != the CD sector
    size we assume that the device has no ISO partition.

    Signed-off-by: Egbert Eich

    Egbert Eich
     
  • ae1768a72   disk/gpt: Fix GPT partition handling for blocksize != 512 ... Browse Code »

    Disks beyond 2T in size use blocksizes of 4096 bytes. However a lot of
    code in u-boot still assumes a 512 byte blocksize.
    This patch fixes the handling of GPTs.

    Signed-off-by: Egbert Eich

    Egbert Eich
     
  • 9d956e0fe   disk/part_dos: check harder for partition table ... Browse Code »

    Devices that used to have a whole disk FAT filesystem but got then
    partitioned will most likely still have a FAT or FAT32 signature
    in the first sector as this sector does not get overwritten by
    a partitioning tool (otherwise the tool would risk to kill the mbr).

    The current partition search algorithm will erronously detects such
    a device as a raw FAT device.

    Instead of looking for the FAT or FAT32 signatures immediately we
    use the same algorithm as used by the Linux kernel and first check
    for a valid boot indicator flag on each of the 4 partitions.
    If the value of this flag is invalid for the first entry we then
    do the raw partition check.
    If the flag for any higher partition is wrong we assume the device
    is neiter a MBR nor PBR device.

    Signed-off-by: Egbert Eich

    Egbert Eich
     

03 Apr, 2013

1 commit

15 Mar, 2013

1 commit

05 Mar, 2013

1 commit

14 Dec, 2012

3 commits

07 Dec, 2012

1 commit

  • 33699df12   part: check each variable for capability calculation ... Browse Code »

    In order to calculate the capability, we use the below expression to check:
    ((dev_desc->lba * dev_desc->blksz)>0L)
    If the capability is greater than 4GB (e.g. 8GB = 8 * 1024 * 104 * 1024),
    the result will overflow, the low 32bit may be zero.

    Therefore, change to check each variable to fix this potential issue.

    Signed-off-by: Jerry Huang

    Jerry Huang
     

22 Oct, 2012

2 commits

  • 9936be31f   disk: Address cast and format errors ... Browse Code »

    This change addresses a few printf-formatting errors, and a typecast
    error.

    Signed-off-by: Taylor Hutt
    Signed-off-by: Simon Glass

    Taylor Hutt
     
  • 0c9c8fb5e   disk: Make the disk partition code work with no specific partition types ... Browse Code »

    Currently, if the disk partition code is compiled with all of the parition
    types compiled out, it hits an #error which stops the build. This change
    adjusts that file so that those functions will fall through to their defaults
    in those cases instead of breaking the build. These functions are needed
    because other code calls them, and that code is needed because other config
    options are overly broad and bring in support we don't need along with
    support we do.

    Also reduce repetition of the 6-term #ifdef throughout the file.

    Signed-off-by: Gabe Black
    Signed-off-by: Simon Glass

    Gabe Black
     

20 Oct, 2012

1 commit

  • 6ab6a650a   disk: initialize name/part fields when returning a whole disk ... Browse Code »

    When get_device_and_partition() finds a disk without a partition table,
    under some conditions, it "returns" a disk_partition_t that describes
    the entire raw disk. Make sure to initialize all fields in the partition
    descriptor in that case.

    The value chosen for name is just some arbitrary descriptive string.

    The value chosen for info matches the check at the end of
    get_device_and_partition(). However, it's probably not that important;
    it's not obvious that the value is really used.

    Reported-by: Benoît Thébaudeau
    Signed-off-by: Stephen Warren
    Reviewed-by: Benoît Thébaudeau
    Signed-off-by: Tom Rini

    Stephen Warren
     

17 Oct, 2012

9 commits

09 Oct, 2012

1 commit

  • d1efb6442   disk: part_dos: don't claim whole-disk FAT filesystems ... Browse Code »

    Logically, a disk that contains a raw FAT filesystem does not in fact
    have a partition table. However, test_part_dos() was claiming that such
    disks did in fact have a DOS-style partition table. This caused
    get_device_and_partition() not to return a whole-disk disk_partition_t,
    since part_type != PART_TYPE_UNKNOWN.

    part_dos.c's print_partition_extended() detected the raw FAT filesystem
    condition and printed a fake partition table that encompassed the whole
    disk.

    However, part_dos.c's get_partition_info_extended() did not return any
    valid partitions in this case. This combination caused
    get_device_and_partition() not to find any valid partitions, and hence
    to return an error.

    Fix test_part_dos() not to claim that raw FAT filesystems are DOS
    partition tables. In turn, this causes get_device_and_partition() to
    return a whole-disk disk_partition_t, and hence the following commands
    work:

    fatls mmc 0 /
    fatls mmc 0:auto /

    An alternative would be to modify print_partition_extended() to detect
    raw FAT filesystems, just like print_partition_extended() does, and to
    return a fake partition in this case. However, this seems logically
    incorrect, and also duplicates code, since get_device_and_partition()
    falls back to returning a whole-disk partition when there is no partition
    table on the device.

    Signed-off-by: Stephen Warren

    Stephen Warren
     

29 Sep, 2012

1 commit

  • a10973e7f   disk: allow - or empty string to fall back to $bootdevice ... Browse Code »

    Commit 10a37fd "disk: get_device_and_partition() "auto" partition"
    prevented the use of "-" on the command-line to request fallback to the
    $bootdevice environment variable instead. This patch allows that, or an
    empty string "" to be used.

    Tested:
    setenv bootfile /boot/zImage
    setenv bootdevice 0:1
    ext2load mmc 0:1
    ext2load mmc -
    ext2load mmc ""

    Signed-off-by: Stephen Warren

    Stephen Warren
     

26 Sep, 2012

6 commits

  • d27b5f939   disk: part_msdos: parse and store partition UUID ... Browse Code »

    The MSDOS/MBR partition table includes a 32-bit unique ID, often referred
    to as the NT disk signature. When combined with a partition number within
    the table, this can form a unique ID similar in concept to EFI/GPT's
    partition UUID.

    This patch generates UUIDs in the format 0002dd75-01, which matches the
    format expected by the Linux kernel.

    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • 894bfbbfb   disk: part_efi: parse and store partition UUID ... Browse Code »

    Each EFI partition table entry contains a UUID. Extend U-Boot's struct
    disk_partition to be able to store this information, and modify
    get_partition_info_efi() to fill it in.

    The implementation of uuid_string() was derived from the Linux kernel,
    tag v3.6-rc4 file lib/vsprintf.c function uuid_string().

    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • c04d68c69   disk: part_efi: range-check partition number ... Browse Code »

    Enhance get_partition_info_efi() to range-check the partition number.
    This prevents invalid partitions being accessed, and prevents access
    beyond the end of the gpt_pte[] array.

    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • 10a37fd7a   disk: get_device_and_partition() "auto" partition and cleanup ... Browse Code »
    46

    Rework get_device_and_partition() to:
    a) Implement a new partition ID of "auto", which requests that U-Boot
    search for the first "bootable" partition, and fall back to the first
    valid partition if none is found. This way, users don't need to
    specify an explicit partition in their commands.
    b) Make use of get_device().
    c) Add parameter to indicate whether returning a whole device is
    acceptable, or whether a partition is mandatory.
    d) Make error-checking of the user's device-/partition-specification
    more complete. In particular, if strtoul() doesn't convert all
    characters, it's an error rather than just ignored.

    The resultant device/partition returned by the function will be as
    follows, based on whether the disk has a partition table (ptable) or not,
    and whether the calling command allows the whole device to be returned
    or not.

    (D and P are integers, P >= 1)

    D
    D:
    No ptable:
    !allow_whole_dev: error
    allow_whole_dev: device D
    ptable:
    device D partition 1
    D:0
    !allow_whole_dev: error
    allow_whole_dev: device D
    D:P
    No ptable: error
    ptable: device D partition P
    D:auto
    No ptable:
    !allow_whole_dev: error
    allow_whole_dev: device D
    ptable:
    first partition in device D with bootable flag set.
    If none, first valid paratition in device D.

    Note: In order to review this patch, it's probably easiest to simply
    look at the file contents post-application, rather than reading the
    patch itself.

    Signed-off-by: Rob Herring
    [swarren: Rob implemented scanning for bootable partitions. I fixed a
    couple of issues there, switched the syntax to ":auto", added the
    error-checking rework, and ":0" syntax for the whole device]
    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • 2023e6086   disk: introduce get_device() ... Browse Code »

    This patch introduces function get_device(). This looks up a
    block_dev_desc_t from an interface name (e.g. mmc) and device number
    (e.g. 0). This function is essentially the non-partition-specific
    prefix of get_device_and_partition().

    Signed-off-by: Stephen Warren

    Stephen Warren
     
  • 99d2c205d   disk/part: introduce get_device_and_partition ... Browse Code »

    All block device related commands (scsiboot, fatload, ext2ls, etc.) have
    simliar duplicated device and partition parsing and selection code. This
    adds a common function to replace various implementations.

    The new function has an enhancement over current versions. If no device
    or partition is specified on the command line, the bootdevice env variable
    will be used (scsiboot does this).

    Signed-off-by: Rob Herring

    Rob Herring