16 Oct, 2017

1 commit

• 59ee8f83b   cmd/pxe.c: Rework bootargs construction to clarify string checks ... Browse Code »

  As the code currently stands, we first check that the length of the
  given command line, along with ip_str/mac_str along with an additional 1
  for the NULL termination will fit within the buffer we have, and if not,
  we return an error. The way this code was originally written however
  left Coverity "unhappy" due to using strcat rather than strncat.
  Switching this to strncat however causes clang to be unhappy that we
  aren't enforcing the "1" portion within strncat. Rather than further
  re-work the code to include a "- 1" in this case as well, make the
  strcat code only be done within the else side of the length test. This
  keeps both clang and Coverity happy.

  Fixes: 48ee0a87bc46 ("cmd/pxe.c: Rework initrd and bootargs handling slightly")
  Signed-off-by: Tom Rini

  Tom Rini

  2017-10-16 21:42:51 +0800  

06 Oct, 2017

1 commit

• 48ee0a87b   cmd/pxe.c: Rework initrd and bootargs handling slightly ... Browse Code »

  20

  For the initrd portion of handling our bootm arguments we do not have a
  sufficiently long enough buffer for some improbable 64bit cases. Expand
  this buffer to allow for a 64bit address and almost 256MB initrd to be
  used. Make use of strncpy/strncat when constructing the values here
  since we know what the worst case valid values are, length wise.

  Similarly for bootargs themselves, we need to make use of strlen/sizeof
  and strncpy/strncat to ensure that we don't overflow bootargs itself.

  Cc: Simon Glass
  Cc: Alexander Graf
  Reported-by: Coverity (CID: 131256)
  Signed-off-by: Tom Rini

  Tom Rini

  2017-10-06 23:28:21 +0800  

16 Aug, 2017

3 commits

• 35affd7a2   env: Rename eth_getenv_enetaddr() to eth_env_get_enetaddr() ... Browse Code »

  Rename this function for consistency with env_get().

  Signed-off-by: Simon Glass

  Simon Glass

  2017-08-16 20:30:44 +0800  
• 00caae6d4   env: Rename getenv/_f() to env_get() ... Browse Code »

  We are now using an env_ prefix for environment functions. Rename these
  two functions for consistency. Also add function comments in common.h.

  Quite a few places use getenv() in a condition context, provoking a
  warning from checkpatch. These are fixed up in this patch also.

  Suggested-by: Wolfgang Denk
  Signed-off-by: Simon Glass

  Simon Glass

  2017-08-16 20:30:24 +0800  
• 382bee57f   env: Rename setenv() to env_set() ... Browse Code »

  We are now using an env_ prefix for environment functions. Rename setenv()
  for consistency. Also add function comments in common.h.

  Suggested-by: Wolfgang Denk
  Signed-off-by: Simon Glass

  Simon Glass

  2017-08-16 20:22:18 +0800  

07 Sep, 2016

1 commit

• f63963f04   pxe: Fix pxe boot with FIT image ... Browse Code »

  When FIT image is used, a single image provides kernel, device
  tree and optionally ramdisk. Argc and argv need to be adjusted
  to support this.

  Test cases:
  1. Booting with legacy images
  2. Booting with legacy images without initrd
  3. Booting with FIT image
  Test commands:
  1. pxe get && pxe boot
  2. sysboot

  Signed-off-by: York Sun
  Signed-off-by: Wenbin Song

  York Sun

  2016-09-07 20:49:02 +0800  

06 Feb, 2016

1 commit

• a187559e3   Use correct spelling of "U-Boot" ... Browse Code »

  Correct spelling of "U-Boot" shall be used in all written text
  (documentation, comments in source files etc.).

  Signed-off-by: Bin Meng
  Reviewed-by: Heiko Schocher
  Reviewed-by: Simon Glass
  Reviewed-by: Minkyu Kang

  Bin Meng

  2016-02-06 19:00:59 +0800  

25 Jan, 2016

1 commit

• 2e192b245   Remove the cmd_ prefix from command files ... Browse Code »

  Now that they are in their own directory, we can remove this prefix.
  This makes it easier to find a file since the prefix does not get in the
  way.

  Signed-off-by: Simon Glass
  Reviewed-by: Bin Meng
  Reviewed-by: Heiko Schocher
  Acked-by: Stefan Roese
  Acked-by: Przemyslaw Marczak

  Simon Glass

  2016-01-25 23:39:43 +0800