10 Mar, 2018
1 commit
-
The system call used by mkimage to run dtc redirects stdout to a
temporary file. This can cause problems on Windows (with a MinGW
cross-compiled version). Using the "-o" dtc parameter avoids
this problem.Signed-off-by: Stefan Theil
Reviewed-by: Tom Rini
16 Jan, 2018
1 commit
-
The DT spec demands a unit-address in a node name to match the "reg"
property in that node. Newer dtc versions will throw warnings if this is
not the case.
Correct the generated unit names when U-Boot's mkimage creates a FIT
image.Signed-off-by: Andre Przywara
16 Oct, 2017
1 commit
-
fit_handle_file function does not quote input and output files while preparing
command to run DTC to convert .its to .itb. This results in a failure if input
or output files contain spaces in their names. Quote input and output files in
DTC command to avoid this failure.Signed-off-by: Mirza, Taimoor
07 Oct, 2017
1 commit
-
The recent changes to these files did not completely fix the previous
issues, or introduced different (minor) issues. In cmd/gpt.c we need to
dereference str_disk_guid to be sure that malloc worked. In
cmd/nvedit.c we need to be careful that we can also fit in that leading
space when adding to the string. And in tools/fit_image.c we need to
re-work the error handling slightly in fit_import_data() so that we only
call munmap() once. We have two error paths here, one where we have an
fd to close and one where we do not. Adjust labels to match this.Reported-by: Coverity (CID: 167366, 167367, 167370)
Signed-off-by: Tom Rini
06 Oct, 2017
1 commit
-
Coverity has found some problems with the return paths in parts of this
code. We have a case where we were going to the wrong part of the
unwind (open() failed so we cannot close the fd), a case where we were
only free()ing our buf on the error path and finally a case where we did
not munmap in the failure path.Reported-by: Coverity (CID: 138492, 138495, 143064)
Signed-off-by: Tom Rini
15 Jan, 2017
1 commit
-
Add support for signing with the pkcs11 engine. This allows FIT images
to be signed with keys securely stored on a smartcard, hardware security
module, etc without exposing the keys.Support for other engines can be added in the future by modifying
rsa_engine_get_pub_key() and rsa_engine_get_priv_key() to construct
correct key_id strings.Signed-off-by: George McCollister
06 Nov, 2016
1 commit
-
Adds -i option that allows specifying a ramdisk file to be added to the
FIT image when we are using the automatic FIT mode (no ITS file).This makes adding Depthcharge support to LAVA much more convenient, as
no additional configuration files need to be kept around in the machine
that dispatches jobs to the boards.Signed-off-by: Tomeu Vizoso
Cc: Simon Glass
Cc: Matt Hart
Cc: Neil Williams
Reviewed-by: Simon Glass
15 Jul, 2016
2 commits
-
The error code may provide useful information for debugging. Add it to the
error string.Signed-off-by: Simon Glass
Reviewed-by: Teddy Reed -
The fit_write_images() function incorrectly uses the long name for the
architecture. This cannot be parsed with the FIT is read. Fix this by using
the short name instead.Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
25 Jun, 2016
2 commits
-
Embedding timestamps in FIT images results in unreproducible builds
for targets that generate a fit image, such as dra7xx_evm.This patch uses the SOURCE_DATE_EPOCH environment variable, when set,
to use specified value for the date.Thanks to HW42 for debugging the issue and providing the patch:
https://lists.alioth.debian.org/pipermail/reproducible-builds/Week-of-Mon-20160606/005722.html
For more information about reproducible builds and the
SOURCE_DATE_EPOCH specification:https://reproducible-builds.org/specs/source-date-epoch/
https://reproducible-builds.org/Signed-off-by: Vagrant Cascadian
Reviewed-by: Simon Glass -
When building a FIT with external data (-E), U-Boot proper may require
absolute positioning for executing the external firmware. To acheive this
use the (-p) switch, which will replace the amended 'data-offset' with
'data-position' indicating the absolute position of external data.It is considered an error if the requested absolute position overlaps with the
initial data required for the compact FIT.Signed-off-by: Teddy Reed
03 May, 2016
1 commit
-
There is an extra close() call which is not needed.
Reported-by: Coverity (CID: 143065)
Signed-off-by: Simon Glass
23 Mar, 2016
9 commits
-
The error path for fit_import_data() is incorrect if the second open() call
fails.Reported-by: Coverity (CID: 138489)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The file that is opened is not closed in all cases. Fix it.
Reported-by: Coverity (CID: 138490)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
Make sure that both the error path and normal return free the buffer and
close the file.Reported-by: Coverity (CID: 138491)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The 'buf' variable is not freed. Fix it.
Reported-by: Coverity (CID: 138492)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The 'fdt' variable is not unmapped in all error cases. Fix this.
Reported-by: Coverity (CID: 138493)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The space allocated to fdt is not freed on error. Fix it.
Reported-by: Coverity (CID: 138494)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The code flows through to the end of the function, so we don't need another
close() before this. Remove it.Reported-by: Coverity (CID: 138503)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The code flows through to the end of the function, so we don't need another
close() before this. Remove it.Reported-by: Coverity (CID: 138504)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
The munmap() call unmaps the wrong memory buffer. Fix it.
Reported-by: Coverity (CID: 138505)
Reported-by: Coverity (CID: 138495)
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
15 Mar, 2016
4 commits
-
Since we now support data outside the FIT image, bring it into the FIT image
first before we do any processing. This avoids adding new functionality to
the core FIT code for now.Signed-off-by: Simon Glass
-
One limitation of FIT is that all the data is 'inline' within it, using a
'data' property in each image node. This means that to find out what is in
the FIT it is necessary to scan the entire file. Once loaded it can be
scanned and then the images can be copied to the correct place in memory.In SPL it can take a significant amount of time to copy images around in
memory. Also loading data that does not end up being used is wasteful. It
would be useful if the FIT were small, acting as a directory, with the
actual data stored elsewhere.This allows SPL to load the entire FIT, without the images, then load the
images it wants later.Add a -E option to mkimage to request that it output an 'external' FIT.
Signed-off-by: Simon Glass
-
To make the auto-FIT feature useful we need to be able to provide a list of
device tree files on the command line for mkimage to add into the FIT. Add
support for this feature.So far there is no support for hashing or verified boot using this method.
For those cases, a .its file must still be provided.Signed-off-by: Simon Glass
-
At present, when generating a FIT, mkimage requires a .its file containing
the structure of the FIT and referring to the images to be included.Creating the .its file is a separate step that makes it harder to use FIT.
This is not required for creating legacy images.Often the FIT is pretty standard, consisting of an OS image, some device
tree files and a single configuration. We can handle this case automatically
and avoid needing a .its file at all.To start with, support automatically generate the FIT using a new '-f auto'
option. Initially this only supports adding a single image (e.g. a linux
kernel) and a single configuration.Signed-off-by: Simon Glass
30 Jan, 2015
2 commits
-
The dumpimage is able to extract components contained in a FIT image:
$ ./dumpimage -T flat_dt -i CONTAINER.ITB -p INDEX FILE
The CONTAINER.ITB is a regular FIT container file. The INDEX is the poisition
of the sub-image to be retrieved, and FILE is the file (path+name) to save the
extracted sub-image.For example, given the following kernel.its to build a kernel.itb:
/dts-v1/;
/ {
...
images {
kernel@1 {
description = "Kernel 2.6.32-34";
data = /incbin/("/boot/vmlinuz-2.6.32-34-generic");
type = "kernel";
arch = "ppc";
os = "linux";
compression = "gzip";
load = ;
entry = ;
hash@1 {
algo = "md5";
};
};
...
};
...
};The dumpimage can extract the 'kernel@1' node through the following command:
$ ./dumpimage -T flat_dt -i kernel.itb -p 0 kernel
Extracted:
Image 0 (kernel@1)
Description: Kernel 2.6.32-34
Created: Wed Oct 22 15:50:26 2014
Type: Kernel Image
Compression: gzip compressed
Data Size: 4040128 Bytes = 3945.44 kB = 3.85 MB
Architecture: PowerPC
OS: Linux
Load Address: 0x00000000
Entry Point: 0x00000000
Hash algo: md5
Hash value: 22352ad39bdc03e2e50f9cc28c1c3652Which results in the file 'kernel' being exactly the same as '/boot/vmlinuz-2.6.32-34-generic'.
Signed-off-by: Guilherme Maciel Ferreira
-
The registration was introduced in commit f86ed6a8d52c99bb2d17d3cac1647edca0c4399c
This commit also removes all registration functions, and the member "next"
from image_type_params structSigned-off-by: Guilherme Maciel Ferreira
12 Jun, 2014
1 commit
-
When adding hashes or signatures, the target FDT may be full. Detect this
and automatically try again after making 1KB of space.Signed-off-by: Simon Glass
22 Mar, 2014
1 commit
-
add fit_info command to the host tools. This command prints
the name, offset and the len from a property from a node in
a fit file. This info can be used to extract a properties
data with linux tools, for example "dd".Signed-off-by: Heiko Schocher
Acked-by: Simon Glass
13 Dec, 2013
1 commit
-
In order to avoid duplicating code and keep only one point of modification,
the functions, structs and defines useful for "dumpimage" were moved from
"mkimage" to a common module called "imagetool".This modification also weakens the coupling between image types (FIT, IMX, MXS,
and so on) and image tools (mkimage and dumpimage). Any tool may initialize the
"imagetool" through register_image_tool() function, while the image types
register themselves within an image tool using the register_image_type()
function:+---------------+
+------| fit_image |
+--------------+ +-----------+ | +---------------+
| mkimage |--------> | | | |
Signed-off-by: Simon Glass
20 Sep, 2013
1 commit
-
Becuase fdt_check_header function takes (const void *)
type argument, the argument should be passed to it
without being casted to (char *).Signed-off-by: Masahiro Yamada
24 Jul, 2013
1 commit
-
Signed-off-by: Wolfgang Denk
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini
26 Jun, 2013
6 commits
-
Normally, multiple public keys can be provided and U-Boot is not
required to use all of them for verification. This is because some
images may not be signed, or may be optionally signed.But we still need a mechanism to determine when a key must be used.
This feature cannot be implemented in the FIT itself, since anyone
could change it to mark a key as optional. The requirement for
key verification must go in with the public keys, in a place that
is protected from modification.Add a -r option which tells mkimage to mark all keys that it uses
for signing as 'required'.If some keys are optional and some are required, run mkimage several
times (perhaps with different key directories if some keys are very
secret) using the -F flag to update an existing FIT.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut -
When signing an image, it is useful to add some details about which tool
or person is authorising the signing. Add a comment field which can take
care of miscellaneous requirements.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut -
When signing images it is sometimes necessary to sign with different keys
at different times, or make the signer entirely separate from the FIT
creation to avoid needing the private keys to be publicly available in
the system.Add a -F option so that key signing can be a separate step, and possibly
done multiple times as different keys are avaiable.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut -
FIT image verification requires public keys. Add a convenient option to
mkimage to write the public keys to an FDT blob when it uses then for
signing an image. This allows us to use:mkimage -f test.its -K dest.dtb -k keys test.fit
and have the signatures written to test.fit and the corresponding public
keys written to dest.dtb. Then dest.dtb can be used as the control FDT
for U-Boot (CONFIG_OF_CONTROL), thus providing U-Boot with access to the
public keys it needs.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut -
Keys required for signing images will be in a specific directory. Add a
-k option to specify that directory.Also update the mkimage man page with this information and a clearer list
of available commands.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut (v1) -
Add support for signing images using a new signature node. The process
is handled by fdt_add_verification_data() which now takes parameters to
provide the keys and related information.Signed-off-by: Simon Glass
15 May, 2013
2 commits
-
The fit_handle_file() function is quite long - split out the part that
loads and checks a FIT into its own function. We will use this
function for storing public keys into a destination FDT file.The error handling is currently a bit repetitive - tidy it.
Signed-off-by: Simon Glass
-
We intend to add signatures to FITs also, so rename this function so that
it is not specific to hashing. Also rename fit_image_set_hashes() and
make it static since it is not used outside this file.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut