Eric Lee / smarc-uboot

27 Apr, 2018

1 commit

  • 9bccfd01c   MLK-14930-1 cmd: sata: Fix sata init and stop issue ... Browse Code »
    14

    When sata stop is executed, the sata_curr_device is not reset to -1, so
    any following sata commands will not initialize the sata again and cause
    problem.

    Additional, in sata init implementation, the sata_curr_device should be updated,
    otherwise sata will be initialized again when doing other sata commands like
    read/write/info/part/device.

    Signed-off-by: Ye Li

    Ye Li
     

17 Aug, 2017

2 commits

15 Jan, 2017

1 commit

  • 8547f45bc   cmd: sata: fix init command return value ... Browse Code »

    Since commit aa6ab905b2, sata_initialize returns -1 if init_sata or
    scan_sata fails. But this return value becomes the do_sata return
    value which is equivalent to CMD_RET_USAGE.

    In case one issues 'sata init' and that the hardware fails to
    initialize, there's no need to display the command usage. Instead
    the command shoud just return the CMD_RET_FAILURE value.

    Fixes: aa6ab905b2 (sata: fix sata command can not being executed bug)

    Signed-off-by: Gary Bisson
    Reviewed-by: Eric Nelson
    Reviewed-by: Simon Glass

    Gary Bisson
     

29 Nov, 2016

1 commit

  • aa6ab905b   sata: fix sata command can not being executed bug ... Browse Code »
    52

    Commit d97dc8a0 separated the non-command code into its own file
    which caused variable sata_curr_device can not be set to a correct
    value.

    Before commit d97dc8a0, variable sata_curr_device can be set
    correctly in sata_initialize().
    After commit d97dc8a0, sata_initialize() is moved out to its own file.
    Accordingly, variable sata_curr_device is removed from sata_initialize()
    too. This caused sata_curr_device never gets a chance to be set properly
    which prevent other commands from being executed.

    This patch sets variable sata_curr_device properly.

    Fixes: d97dc8a0 (dm: sata: Separate the non-command code into its
    own file)

    Signed-off-by: Tang Yuantian
    Reviewed-by: Simon Glass

    Tang Yuantian
     

17 May, 2016

2 commits

  • d97dc8a0e   dm: sata: Separate the non-command code into its own file ... Browse Code »
    116

    At present the SATA command code includes both the command-processing code
    and the core SATA functions and data structures.

    Separate the latter into its own file, adding functions as needed to avoid
    the command code accessing data structures directly.

    With this commit:
    - All CONFIG option are referenced from the non-command code
    - The concept of a 'current SATA device' is confined to the command code

    This will make it easier to convert this code to driver model.

    Signed-off-by: Simon Glass

    Simon Glass
     
  • 2765c4d14   dm: sata: Fix code style problems in cmd/sata.c ... Browse Code »

    This file has a few coding style problems. Fix these to make future updates
    easier.

    Signed-off-by: Simon Glass

    Simon Glass
     

02 Apr, 2016

1 commit

15 Mar, 2016

3 commits

25 Jan, 2016

1 commit

  • 2e192b245   Remove the cmd_ prefix from command files ... Browse Code »

    Now that they are in their own directory, we can remove this prefix.
    This makes it easier to find a file since the prefix does not get in the
    way.

    Signed-off-by: Simon Glass
    Reviewed-by: Bin Meng
    Reviewed-by: Heiko Schocher
    Acked-by: Stefan Roese
    Acked-by: Przemyslaw Marczak

    Simon Glass