24 Feb, 2018
2 commits
-
This migrates rk_vop (the shared functions used by multiple VOP
mini-drivers) to be compatible with a live tree.Unfortunately, there's
(i) a lot of tree traversal needed for a VOP (as each active VOP
vnode references back to the endpoints in the encoders and vice
versa) to configure the connection between VOPs and encoders;
(ii) the DTS binding is not too sane and one needs to walk a node's
parents (the original code just assumed that the device would
live 3 levels above the property linked through a phandle) until
a UCLASS_DISPLAY device can be found.As part of the migration, the code for finding the enclosing display
device has been changed to not assume a specific depth of nesting
(i.e. we walk until we reach the root or find a matching device) and
to use the newly introduced (in the same series) ofnode_get_parent()
function.Signed-off-by: Philipp Tomsich
Tested-by: Klaus Goger
Reviewed-by: Anatolij Gustschin -
The rk_hdmi (shared functions for multiple HDMI mini-drivers) has been
using devfdt_get_addr() to read the HDMI controller's IO base address.
This will cause a failure with a live tree.This changes the driver to use dev_read_addr() which is safe both for
flat trees and live trees.Signed-off-by: Philipp Tomsich
Tested-by: Klaus Goger
Reviewed-by: Anatolij Gustschin
08 Aug, 2017
4 commits
-
Signed-off-by: Eric Gao
Acked-by: Philipp Tomsich
Reviewed-by: Philipp Tomsich -
Add rk3288 soc specific driver for mipi dsi.
Signed-off-by: Eric Gao
Reviewed-by: Simon Glass
Acked-by: Philipp Tomsich -
Add Makefile item for soc specific driver for rk3399 mipi dsi.
Signed-off-by: Eric Gao
Acked-by: Philipp Tomsich
Reviewed-by: Philipp Tomsich -
To compatible with different rockchip soc, we split the mipi dirver into
common and soc specific parts, and all the soc share the common
functions from common driver part.Signed-off-by: Eric Gao
Acked-by: Philipp Tomsich
[agust: fix build breakage and warnings]
Signed-off-by: Anatolij Gustschin
11 Jul, 2017
2 commits
-
Modify format type for debug message.
Signed-off-by: Eric Gao
-
Some address relevant varibable is defined originally as u64. To
compatible with arm32, this patch change them to uintptr_t type.Signed-off-by: Eric Gao
Reviewed-by: Simon Glass
11 Jun, 2017
1 commit
10 Jun, 2017
2 commits
-
On reset the standby bit is clear, but if U-Boot is chain-loaded from
another boot loader it may be set. Clear it before starting up video so
that it works correctly.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin
Squashed in 'rockchip: video: fix taking the VOP device out of standby':
Signed-off-by: Philipp Tomsich -
Add remove() methods for EDP and VOP so that U-Boot can shut down the
video on exit. This avoids leaving DMA running while booting Linux which
can cause problems if Linux uses the frame buffer for something else.It also makes it clear what is needed to shut down video.
While we are here, make rkvop_enable() static.
Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin
Squashed in 'rockchip: video: fix taking the VOP device out of standby':
Signed-off-by: Philipp Tomsich
09 Jun, 2017
2 commits
-
Documents the externally visible functions shared between the VOP
drivers for the RK3288 and RK3399.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
Documents the externally visible functions shared between the HDMI
drivers for the RK3288 and RK3399.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass
08 Jun, 2017
9 commits
-
The last set of rebases had dropped the 'grf' field from the common
rk_vop. Add this back to un-break the build (and driver).Signed-off-by: Philipp Tomsich
-
This commit enables the RK3399 HDMI TX, which is very similar to the
one found on the RK3288. As requested by Simon, this splits the HDMI
driver into a SOC-specific portion (rk3399_hdmi.c, rk3288_hdmi.c) and
a common portion (rk_hdmi.c).Note that the I2C communication for reading the EDID works well with
the default settings, but does not with the alternate settings used on
the RK3288... this configuration aspect is reflected by the driverdata
for the RK3399 driver.Having some sort of DTS-based configuration for the regulator
dependencies would be nice for the future, but for now we simply use
lists of regulator names (also via driverdata) that we probe.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
To prepare for the addition of RK3399 HDMI support, the HDMI driver is
refactored and broken into a chip-specific and a generic part. This
change adds the internal interfaces, makes common/reusable functions
externally visible and splits the RK3288 driver into a separate file.For the probing of regulators, we reuse the infrastructure created
during the VOP refactoring... i.e. we simply call into the helper
function defined for the VOP.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
The Linux driver now supports higher mpixelclock settings.
Add these to rockchip_phy_config[] and rockchip_mpll_cfg[].Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
This commit adds a driver for the RK3399 VOPs capable and all the
necessary plumbing to feed the HDMI encoder. For the VOP-big, this
correctly tracks the ability to feed 10bit RGB data to the encoder.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
To prepare for adding the RK3399 VOP driver (which shares most of its
registers and config logic with the RK3228 VOP), this change refactors
the driver and splits the RK3288-specific driver off.The changes in detail are:
- introduces a data-structure for chip-specific drivers to register
features/callbacks with the common driver: at this time, this is
limited to a callback for setting the pin polarities (between the
VOP and the encoder modules) and a flag to signal 10bit RGB
capability
- refactors the probing of regulators into a helper function that
can take a list of regulator names to probe and autoset
- moves the priv data-structure into a (common) header file to be
used by the chip-specific drivers to provide base addresses to
the common driver
- uses a callback into the chip-specific driver to set pin polarities
(replacing the direct register accesses previously used)
- splits enabling the output (towards an encoder) into a separate
help function withint the common driverSigned-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
This introduces two new Kconfig options that configure the maximum
allowable framebuffer size (i.e. the memory reservation/allocation for
the framebuffer):
- VIDEO_ROCKCHIP_MAX_XRES
- VIDEO_ROCKCHIP_MAX_YRES
The resulting memory allocation will cover 4 byte per pixel for these
resolutions.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
For consistency sake (and as we are about to add new options to this
file), reformat the help for VIDEO_ROCKCHIP.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass -
When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for
the following implicitly defined functions are raised due to a missing
include directive:drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe':
drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration]
rk_setreg(&priv->grf->soc_con6, 1 << 15);
^~~~~~~~~
drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration]
rk_clrsetreg(&priv->grf->soc_con6, 1 << 4,
^~~~~~~~~~~~This change fixes this by including in rk_hdmi.c.
Signed-off-by: Philipp Tomsich
Acked-by: Simon Glass
01 Jun, 2017
1 commit
-
These support the flat device tree. We want to use the dev_read_..()
prefix for functions that support both flat tree and live tree. So rename
the existing functions to avoid confusion.In the end we will have:
1. dev_read_addr...() - works on devices, supports flat/live tree
2. devfdt_get_addr...() - current functions, flat tree only
3. of_get_address() etc. - new functions, live tree onlyAll drivers will be written to use 1. That function will in turn call
either 2 or 3 depending on whether the flat or live tree is in use.Note this involves changing some dead code - the imx_lpi2c.c file.
Signed-off-by: Simon Glass
16 May, 2017
1 commit
-
Instead of having drivers/video/rockchip/Kconfig point outside of its
hierarchy for dw_hdmi.o, we should use a configuration-option to
include the Designware HDMI support.This change introduces a new config option (not to be selected via
menuconfig, but to be selected from a dependent video driver's
configuration option) that enables dw_hdmi.o and selects it whenever
the HDMI support for Rockchip SoCs is selected.Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass
11 May, 2017
7 commits
-
plat->size here is used to reserve frame buffer space befor relocation.
our mipi panel use 24 bitwidth, and vop require 32bit align. So the frame
buffer size should be at least 1920*1200*32/8.Signed-off-by: Eric Gao
Reviewed-by: Simon Glass -
Because the bitwidth is different for different display mode, so we need
to set them according to demand.Signed-off-by: Eric Gao
Reviewed-by: Simon Glass -
Add mipi display mode for rk3399 vop, so that we can use mipi panel
for display.Signed-off-by: Eric Gao
Reviewed-by: Simon Glass -
It's caused by the difference of clk_set_rate function implement between
rk3288 andd rk3399.clk_set_rate() of rk3288 return 0 in normal condition.
clk_set_rate() of rk3399 return input parameter in normal condition.So check clk_set_rate's return value by IS_ERR_VALUE.
Signed-off-by: Eric Gao
-
Add basic driver for mipi display on rockchip soc platform.
Signed-off-by: Eric Gao
Acked-by: Simon Glass -
Modify Makefile for rockchip video driver according to Kconfig, so that
source code will not be compiled if not needed.Signed-off-by: Eric Gao
Acked-by: Simon Glass -
1. add Kconfig for rockchip video driver, so that video port can be
selected as needed.
2. move VIDEO_ROCKCHIP option to new Kconfig for concision.Signed-off-by: Eric Gao
Acked-by: Simon Glass
Drop indenting in Kconfig:
Signed-off-by: Simon Glass
05 Apr, 2017
1 commit
-
Designware HDMI controller and phy are used in other SoCs as well. Split
out platform independent code.DW HDMI has 8 bit registers but they can be represented as 32 bit
registers as well. Add support to select access mode.EDID reading code use reading by blocks which is not supported by other
SoCs in general. Make it more general using byte by byte approach, which
is also used in Linux driver.Finally, not all DW HDMI controllers are accompanied with DW HDMI phy.
Support custom phys by making controller code independent from phy code.Signed-off-by: Jernej Skrabec
Tested-by: Nickey Yang
Reviewed-by: Simon Glass
17 Mar, 2017
2 commits
-
Despite the comment in the code, CSC unit is never used. According to
the only public description of DW HDMI controller (i.MX6 manual), CSC
unit is bypassed in MC_FLOWCTRL register and then actually powered
down in MC_CLKDIS register.Signed-off-by: Jernej Skrabec
Reviewed-by: Simon Glass -
Function hdmi_lookup_n_cts() is feed with clock in Hz, which gets
compared with clocks in kHz. Fix that by converting all clocks to Hz.Signed-off-by: Jernej Skrabec
Reviewed-by: Simon Glass
27 Feb, 2017
1 commit
-
There is one "0" too many in 83500000 mpixelclock in rockchip_mpll_cfg[].
fix it.Signed-off-by: Nickey Yang
08 Feb, 2017
1 commit
-
At present devices use a simple integer offset to record the device tree
node associated with the device. In preparation for supporting a live
device tree, which uses a node pointer instead, refactor existing code to
access this field through an inline function.Signed-off-by: Simon Glass
12 Jan, 2017
1 commit
-
Correct mpixelclock errors in rockchip_phy_config[] and rockchip_mpll_cfg[].
Signed-off-by: Nickey Yang
26 Nov, 2016
3 commits
-
It makes not sense using u8 to hold a value on a 32-bit or 64-bit machine.
It can only bloat the code by forcing the compiler to mask the value.
Change it to uint.Signed-off-by: Simon Glass
-
Check whether a display device is in use before using it. Add a comment as
to why two displays cannot currently be used at the same time.This allows us to remove the device-tree change that disables vopb on
jerry.Signed-off-by: Simon Glass
-
This code incorrectly uses the oscillator. It should use the clock
selected in the device tree.Signed-off-by: Simon Glass
Fixes: 135aa95 (clk: convert API to match reset/mailbox style)