25 Oct, 2015
1 commit
-
In the "Getting Started with Coccinelle - KVM edition" presentation that
has been held by Julia Lawall at the KVM forum 2015 (see the slides at
http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf),
she pointed out some bad return value checks in U-Boot that can be
detected with Coccinelle by using the following config file:@@
identifier x,y;
identifier f;
statement S;
@@
x = f(...);
(
if (x < 0) S
|
if (
- y
+ x
< 0) S
)This patch now fixes these issues.
Signed-off-by: Thomas Huth
19 Jun, 2014
3 commits
-
At present this tool only checks the configuration signing. Have it also
look at each of the images in the configuration and confirm that they
verify.Signed-off-by: Simon Glass
Acked-by: Heiko Schocher (v1) -
It is more common to have 0 mean OK, and -ve mean error. Change this
function to work the same way to avoid confusion.Signed-off-by: Simon Glass
-
These tools crash if no arguments are provided. Add checks to avoid this.
Signed-off-by: Simon Glass
Acked-by: Heiko Schocher
12 Jun, 2014
2 commits
-
When adding hashes or signatures, the target FDT may be full. Detect this
and automatically try again after making 1KB of space.Signed-off-by: Simon Glass
-
Make the error handling common, and make sure the file is always closed
on error. Rename the parameter to be more description and add comments.Signed-off-by: Simon Glass
06 Jun, 2014
1 commit
-
It is trivial to crash fit_check_sign by invoking with an
absolute path in a deeply nested directory. This is exposed
by vboot_test.sh.Signed-off-by: Michael van der Westhuizen
Acked-by: Simon Glass
22 Mar, 2014
1 commit
-
add host tool "fit_check_sign" which verifies, if a fit image is
signed correct.Signed-off-by: Heiko Schocher
Cc: Simon Glass
