13 Jun, 2016
1 commit
-
The sed script, tools/scripts/define2mk.sed, converts config defines
from C headers into include/autoconf.mk for the use in Makefiles.I found the tool adds quotes around negative integer values.
For example, at the point of the v2016.07-rc1 tag,
include/configs/microblaze-generic.h defines
#define CONFIG_BOOTDELAY -1 /* -1 disables auto-boot */Because it is an integer option, it should be converted to:
CONFIG_BOOTDELAY=-1But, the script actually converts it to:
CONFIG_BOOTDELAY="-1"This is a fatal problem for the tools/moveconfig.py because it parses
include/autoconf.mk for the config defines from the board headers.
CONFIG_BOOTDELAY="-1" is considered as a string type option and it
is dropped due to the type mismatch from the entry in Kconfig.This commit fixes the script so that the tools/moveconfig.py can
correctly convert integer options with a negative value.Signed-off-by: Masahiro Yamada
26 Feb, 2014
1 commit
-
Generate include/generated/generic-asm-offsets.h and
include/generated/asm-offsets.h in ./Kbuild.This commit also changes the include guard.
Before this commit, __ASM_OFFSETS_H__ was used for both of them.
So we could not include generic-asm-offsets.h and asm-offsets.h
at the same time.This commit renames the include guard of the former to
__GENERIC_ASM_OFFSETS_H__.Signed-off-by: Masahiro Yamada
25 Jan, 2014
2 commits
-
The script files, define2mk.sed and make-asm-offsets
are used to create autoconf.mk and asm-offsets.h
while build.Whereas README, dot.kermrc, flash_param, send_cmd, send_image
are files useful for kermit.We should not put files which have the totally different purpose
into the same directory.This commit creates a new directory, tools/kermit,
and move kermit files into it.Signed-off-by: Masahiro Yamada
Cc: Wolfgang Denk -
Signed-off-by: Masahiro Yamada
15 Oct, 2013
2 commits
-
Signed-off-by: Wolfgang Denk
[trini: Drop changes for PEP 4 following python tools]
Signed-off-by: Tom Rini -
Signed-off-by: Wolfgang Denk
24 Jul, 2013
1 commit
-
Signed-off-by: Wolfgang Denk
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini
12 Apr, 2013
1 commit
-
Give more flexibility to define configs that can be interpreted by make, e.g. to
define fallback values of configs like in the example below.Before this change, the config lines:
#define CONFIG_SPL_MAX_SIZE 2048
#define CONFIG_SPL_PAD_TO CONFIG_SPL_MAX_SIZE
would have been changed in autoconfig.mk into:
CONFIG_SPL_MAX_SIZE=2048
CONFIG_SPL_PAD_TO="CONFIG_SPL_MAX_SIZE"Hence, a make recipe using as an argument to $(OBJCOPY):
--pad-to=$(CONFIG_SPL_PAD_TO)
would have issued:
--pad-to="CONFIG_SPL_MAX_SIZE"
which means nothing for $(OBJCOPY) and makes it fail.Thanks to this change, the config lines above are changed in autoconfig.mk into:
CONFIG_SPL_MAX_SIZE=2048
CONFIG_SPL_PAD_TO=$(CONFIG_SPL_MAX_SIZE)Hence, the make recipe above now issues:
--pad-to=2048
as expected from the defined config.Signed-off-by: Benoît Thébaudeau
Reviewed-by: Tom Rini
28 Oct, 2010
1 commit
-
When copying the "sed" script to generate the asm-offsets.h file from
the Linux Kbuild script into the make-asm-offsets file I missed the
fact that the former runs in a "make" context and thus uses double
"$$" to escape a single "$", while the latter is a shell script, where
this must not be done. Unfortunately the problem did not show up
during the initial tests on Power Architecture systems, but on ARM the
generated asm-offsets.h was not correct.Signed-off-by: Wolfgang Denk
Tested-by: Heiko Schocher
Tested-by: Ben Gardiner
27 Oct, 2010
1 commit
-
A recurrent issue is that certain C level constructs like sizeof() or
offsetof() cannot be used in assembler files, which is inconvenient
when such constructs are used in the definition of macro names etc.To avoid duplication of such definitions (and thus another cause of
problems), we adapt the Linux way to automatically generate the
respective definitions from the respective C header files.In Linux, this is implemented in include/linux/kbuild.h, Kbuild, and
arch/*/kernel/asm-offsets.c; we adapt the code from the Linux v2.6.36
kernel tree.We also copy the concept of the include/generated/ directory which can
be used to hold other automatically generated files as well.We start with an architecture-independent lib/asm-offsets.c which
generates include/generated/generic-asm-offsets.h (included by
include/asm-offsets.h, which is what will be referred to in the actual
source code). Later this may be extended by architecture-specific
arch/*/lib/asm-offsets.c files that will generate a
include/generated/asm-offsets.h.Signed-off-by: Wolfgang Denk
Acked-by: Kumar Gala
19 Oct, 2010
1 commit
-
When generating include/autoconfig.mk, hex numbers would be quoted.
This caused some false positives during automatic testing of the
builds, and is known to cause some real issues for some Blackfin
configurations. Don't use apostophes for decimal and hex numbers (nor
for octal numbers).Signed-off-by: Wolfgang Denk
Signed-off-by: Mike Frysinger
23 Feb, 2008
1 commit
-
In the thread "[1.3.2-rc1] MPC8548CDS/MPC8555CDS configs fails to link",
the define2mk.sed script was identified as the source of the link
failure on FreeBSD. The problem is that sed(1) does not always support
the '+' operator. It isn't on FreeBSD. The attach patch implements the
equivalent, using the '*' operator instead and should work everywhere.Signed-off-by: Marcel Moolenaar
21 Nov, 2007
1 commit
-
Use cpp and sed to postprocess config.h and import the defined values
into include/autoconf.mk. autoconf.mk is then included by config.mk to
give 'make' access to the board configuration.Doing this enables conditional compilation at the Makefile level instead
of by wrapping every .c file with #ifdef/#endif wrappers.Signed-off-by: Grant Likely
28 Jun, 2003
1 commit
-
- remove trailing white space, trailing empty lines, C++ comments, etc.
- split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)* Patches by Kenneth Johansson, 25 Jun 2003:
- major rework of command structure
(work done mostly by Michal Cendrowski and Joakim Kristiansen)
03 Nov, 2002
1 commit
09 Mar, 2002
1 commit