18 Dec, 2017

1 commit

• 6d0cbbd59   tools: zynqmpimage: Check return values from file functions ... Browse Code »

  Check all return values from file functions.
  In case of negative return exit immediately.
  Also change fsize return value which can't be negative.

  Reported-by: Coverity (CID: 23276, 23304, 169357)
  Signed-off-by: Michal Simek

  Michal Simek

  2017-12-18 16:32:06 +0800  

29 Nov, 2017

1 commit

• df4950e30   tools: zynqmpimage: adjust ug1085 reference to v1.4 of the document ... Browse Code »

  The chapter in which the table explaining the image format changed
  chapter as the document evolved. This should help people track the
  info down faster.

  Signed-off-by: Jean-Francois Dagenais
  Signed-off-by: Michal Simek

  Jean-Francois Dagenais

  2017-11-29 15:02:40 +0800  

28 Nov, 2017

1 commit

• c85a6b79d   tools: mkimage: Extend mkimage to also include pmufw ... Browse Code »

  The patch is adding external pmufw "Platform Management Unit firmware"
  to boot.bin image. Boot.bin is a Xilinx format which bootrom is capable
  to read and boot the system. pmufw is copied to the header data section
  follows by u-boot-spl.bin. pmufw is consumed by PMU unit (Microblaze)
  and SPL runs on a53-0.

  This is generated command line when PMUFW_INIT_FILE is setup.

  ./tools/mkimage -T zynqmpimage -R ./"" -n
  ./"board/xilinx/zynqmp/pmufw.bin" -d spl/u-boot-spl.bin spl/boot.bin

  Signed-off-by: Michal Simek
  Reviewed-by: Simon Glass

  Michal Simek

  2017-11-28 23:08:57 +0800  

28 Dec, 2016

1 commit

• ac71d4103   tools: mkimage: Call fclose in error path ... Browse Code »

  This patch is fixing missing fclose() calls
  in error patch introduced by:
  "tools: mkimage: Use fstat instead of stat to avoid malicious hacks"
  (sha1: ebe0f53f48e8f9ecc823e533a85b05c13638c350)

  Reported-by: Coverity (CID: 155064, 155065)
  Signed-off-by: Michal Simek
  Reviewed-by: Simon Glass

  Michal Simek

  2016-12-28 00:24:16 +0800  

09 Dec, 2016

2 commits

• ebe0f53f4   tools: mkimage: Use fstat instead of stat to avoid malicious hacks ... Browse Code »

  29

  The patch is fixing:
  "tools: mkimage: Check if file is regular file"
  (sha1: 56c7e8015509312240b1ee15f2ff74510939a45d)
  which contains two issues reported by Coverity
  Unchecked return value from stat and incorrect calling sequence where
  attack can happen between calling stat and fopen.
  Using pair in opposite order (fopen and fstat) is fixing this issue
  because fstat is using the same file descriptor (FILE *).

  Also fixing issue with:
  "tools: mkimage: Add support for initialization table for Zynq and
  ZynqMP" (sha1: 3b6460809c2a28360029c1c48247648fac4455c9)
  where file wasn't checked that it is regular file.

  Reported-by: Coverity (CID: 154711, 154712)
  Signed-off-by: Michal Simek
  Reviewed-by: Tom Rini

  Michal Simek

  2016-12-09 21:40:23 +0800  
• 361a87990   Revert "Merge branch 'master' of git://www.denx.de/git/u-boot-microblaze" ... Browse Code »

  This reverts commit 3edc0c252257e4afed163a3a74aba24a5509b198, reversing
  changes made to bb135a0180c31fbd7456021fb9700b49bba7f533.

  Tom Rini

  2016-12-09 20:56:54 +0800  

08 Dec, 2016

1 commit

• 37a2cf6f1   tools: mkimage: Use fstat instead of stat to avoid malicious hacks ... Browse Code »

  The patch is fixing:
  "tools: mkimage: Check if file is regular file"
  (sha1: 56c7e8015509312240b1ee15f2ff74510939a45d)
  which contains two issues reported by Coverity
  Unchecked return value from stat and incorrect calling sequence where
  attack can happen between calling stat and fopen.
  Using pair in opposite order (fopen and fstat) is fixing this issue
  because fstat is using the same file descriptor (FILE *).

  Also fixing issue with:
  "tools: mkimage: Add support for initialization table for Zynq and
  ZynqMP" (sha1: 3b6460809c2a28360029c1c48247648fac4455c9)
  where file wasn't checked that it is regular file.

  Reported-by: Coverity (CID: 154711, 154712)
  Signed-off-by: Michal Simek
  Reviewed-by: Tom Rini
  Series-to: trini
  Series-cc: u-boot

  Michal Simek

  2016-12-08 16:23:48 +0800  

15 Nov, 2016

2 commits

• 56c7e8015   tools: mkimage: Check if file is regular file ... Browse Code »

  58

  Current Makefile.spl passes -R parameter which is not empty
  and pointing to ./ folder.
  "./tools/mkimage -T zynqmpimage -R ./"" -d spl/u-boot-spl.bin
  spl/boot.bin"
  That's why mkimage is trying to parse ./ file and generate
  register init which is wrong.
  Check that passed filename is regular file. If not do not work with it.

  Signed-off-by: Michal Simek

  Michal Simek

  2016-11-15 22:27:45 +0800  
• 3b6460809   tools: mkimage: Add support for initialization table for Zynq and ZynqMP ... Browse Code »

  58

  The Zynq/ZynqMP boot.bin file contains a region for register initialization
  data. Filling in proper values in this table can reduce boot time
  (e.g. about 50ms faster on QSPI boot) and also reduce the size of
  the SPL binary.

  The table is a simple text file with register+data on each line. Other
  lines are simply skipped. The file can be passed to mkimage using the
  "-R" parameter.

  It is recommended to add reg init file to board folder.
  For example:
  CONFIG_BOOT_INIT_FILE="board/xilinx/zynqmp/xilinx_zynqmp_zcu102/reg.int

  Signed-off-by: Mike Looijmans
  Signed-off-by: Michal Simek

  Mike Looijmans

  2016-11-15 22:27:37 +0800  

24 May, 2016

1 commit

• d9b58b303   tools: zynqmpimage: Add Xilinx ZynqMP boot header generation ... Browse Code »

  Add support for the zynqmpimage to mkimage.
  Only basic functionality is supported without encryption and register
  initialization with one partition which is filled by U-Boot SPL.
  For more detail information look at Xilinx ZynqMP TRM.

  Signed-off-by: Michal Simek
  Reviewed-by: Simon Glass

  Michal Simek

  2016-05-24 17:15:01 +0800