Commit 96a30175f927facfb421655ef08b7a0fe546fbed

Authored by Arnd Bergmann
Committed by David S. Miller
1 parent e9b106b8fb

net: am2150: fix nmclan_cs.c shared interrupt handling

A recent patch tried to work around a valid warning for the use of a
deprecated interface by blindly changing from the old
pcmcia_request_exclusive_irq() interface to pcmcia_request_irq().

This driver has an interrupt handler that is not currently aware
of shared interrupts, but can be easily converted to be.
At the moment, the driver reads the interrupt status register
repeatedly until it contains only zeroes in the interesting bits,
and handles each bit individually.

This patch adds the missing part of returning IRQ_NONE in case none
of the bits are set to start with, so we can move on to the next
interrupt source.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5f5316fcd08ef7 ("am2150: Update nmclan_cs.c to use update PCMCIA API")
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff

drivers/net/ethernet/amd/nmclan_cs.c
... ... @@ -952,6 +952,8 @@
952 952 do {
953 953 /* WARNING: MACE_IR is a READ/CLEAR port! */
954 954 status = inb(ioaddr + AM2150_MACE_BASE + MACE_IR);
  955 + if (!(status & ~MACE_IMR_DEFAULT) && IntrCnt == MACE_MAX_IR_ITERATIONS)
  956 + return IRQ_NONE;
955 957  
956 958 pr_debug("mace_interrupt: irq 0x%X status 0x%X.\n", irq, status);
957 959