24 Feb, 2014
3 commits
-
These local symbols are used only in this file.
Fix the following sparse warnings:drivers/remoteproc/ste_modem_rproc.c:167:27: warning: symbol 'sproc_fw_ops' was not declared. Should it be static?
drivers/remoteproc/ste_modem_rproc.c:196:25: warning: symbol 'sproc_dev_cb' was not declared. Should it be static?Signed-off-by: Jingoo Han
[standartize patch title]
Signed-off-by: Ohad Ben-Cohen -
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)//
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
//Signed-off-by: Julia Lawall
[simplify patch title]
Signed-off-by: Ohad Ben-Cohen -
The comment above disable_irq says that it is needed to ensure that the
"devm subsystem might end up releasing things before freeing the irq,
thus allowing an interrupt to sneak in while the device is being
removed." disable_irq is enough for this purpose and there is no need to
manually free the reference to the clock.Cc: Robert Tivy
Signed-off-by: Uwe Kleine-König
[moved the Cc line into the commit message]
Signed-off-by: Ohad Ben-Cohen
29 Oct, 2013
1 commit
-
Currently a host kick error is silently ignored and not reflected in
the virtqueue of a particular virtio device.Changing the notify API for guest->host notification seems to be one
prerequisite in order to be able to handle such errors in the context
where the kick is triggered.This patch changes the notify API. The notify function must return a
bool return value. It returns false if the host notification failed.Signed-off-by: Heinz Graalfs
Signed-off-by: Rusty Russell
15 Jul, 2013
1 commit
-
We've already tested that it's an error.
Cc: Robert Tivy
Signed-off-by: Rusty Russell
Acked-by: Ohad Ben-Cohen
12 Jul, 2013
1 commit
-
Pull remoteproc fixes from Ohad Ben-Cohen:
"Trivial remoteproc fixes by Suman Anna, Wei Yongjun and Thomas Meyer"* tag 'remoteproc-3.11-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc:
remoteproc: Cocci spatch "memdup.spatch"
remoteproc: free carveout memories only after unmapping them
remoteproc/omap: fix a sparse warning
remoteproc: fix checkpatch errors in remoteproc code
remoteproc: fix error return code in rproc_fw_boot()
01 Jul, 2013
2 commits
-
Use kmemdup instead of kmalloc + memcpy.
Signed-off-by: Thomas Meyer
Signed-off-by: Ohad Ben-Cohen -
It is not preferable to have the allocated pages for carveout
memories freed before they are unmapped. The code that deals
with the cleanup of carveout memories is therefore moved after
the corresponding mapping entries were cleaned up.This is mostly a no-op since the remote processors are already
stopped when the cleanup function is called, but this will make
the cleanup code follow the exact reverse path of allocation.Signed-off-by: Suman Anna
Signed-off-by: Ohad Ben-Cohen
30 Jun, 2013
2 commits
-
This patch fixes relevant checkpatch errors and warnings
in the remoteproc source files.Signed-off-by: Suman Anna
[drop 80-char-lines checkpatch fixes and update commit log accordingly]
Signed-off-by: Ohad Ben-Cohen -
Set 'ret' to -EINVAL when needed, so a sensible return value
is returned on errors.Signed-off-by: Wei Yongjun
[fix additional instances of this bug as well, update commit log]
Signed-off-by: Ohad Ben-Cohen
12 Jun, 2013
1 commit
-
The mailbox hardware (in OMAP) uses a queued mailbox interrupt
mechanism that provides a communication channel between processors
through a set of registers and their associated interrupt signals
by sending and receiving messages.The OMAP mailbox framework/driver code is moved to be under
drivers/mailbox, in preparation for adapting to a common mailbox
driver framework. This allows the build for OMAP mailbox to be
enabled (it was disabled during the multi-platform support).As part of the migration from plat and mach code:
- Kconfig symbols have been renamed to build OMAP1 or OMAP2+ drivers.
- mailbox.h under plat-omap/plat/include has been split into a public
and private header files. The public header has only the API related
functions and types.
- The module name mailbox.ko from plat-omap is changed to
omap-mailbox.ko
- The module name mailbox_mach.ko from mach-omapX is changed as
mailbox_omap1.ko for OMAP1
mailbox_omap2.ko for OMAP2+Cc: Tony Lindgren
[gregkh@linuxfoundation.org: ack for staging part]
Acked-by: Greg Kroah-Hartman
Signed-off-by: Omar Ramirez Luna
Signed-off-by: Suman Anna
08 May, 2013
1 commit
-
Pull remoteproc update from Ohad Ben-Cohen:
- Some refactoring, cleanups and small improvements from Sjur
Brændeland. The improvements are mainly about better supporting
varios virtio properties (such as virtio's config space, status and
features). I now see that I messed up while commiting one of Sjur's
patches and erroneously put myself as the author, as well as letting
a nasty typo sneak in. I will not fix this in order to avoid
rebasing the patches. Sjur - sorry!- A new remoteproc driver for OMAP-L13x (technically a DaVinci
platform) from Robert Tivy.- Extend OMAP support to OMAP5 as well, from Vincent Stehlé.
- Fix Kconfig VIRTUALIZATION dependency, from Suman Anna (a
non-critical fix which arrived late during the rc cycle).* tag 'remoteproc-3.10' of git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc:
remoteproc: fix kconfig dependencies for VIRTIO
remoteproc/davinci: add a remoteproc driver for OMAP-L13x DSP
remoteproc: support default firmware name in rproc_alloc()
remoteproc/omap: support OMAP5 too
remoteproc: set vring addresses in resource table
remoteproc: support virtio config space.
remoteproc: perserve resource table data
remoteproc: calculate max_notifyid by counting vrings
remoteproc: code cleanup of resource parsing
remoteproc: parse STE-firmware and find resource table address
remoteproc: add find_loaded_rsc_table firmware ops
remoteproc: refactor rproc_elf_find_rsc_table()
01 May, 2013
1 commit
-
Pull trivial tree updates from Jiri Kosina:
"Usual stuff, mostly comment fixes, typo fixes, printk fixes and small
code cleanups"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (45 commits)
mm: Convert print_symbol to %pSR
gfs2: Convert print_symbol to %pSR
m32r: Convert print_symbol to %pSR
iostats.txt: add easy-to-find description for field 6
x86 cmpxchg.h: fix wrong comment
treewide: Fix typo in printk and comments
doc: devicetree: Fix various typos
docbook: fix 8250 naming in device-drivers
pata_pdc2027x: Fix compiler warning
treewide: Fix typo in printks
mei: Fix comments in drivers/misc/mei
treewide: Fix typos in kernel messages
pm44xx: Fix comment for "CONFIG_CPU_IDLE"
doc: Fix typo "CONFIG_CGROUP_CGROUP_MEMCG_SWAP"
mmzone: correct "pags" to "pages" in comment.
kernel-parameters: remove outdated 'noresidual' parameter
Remove spurious _H suffixes from ifdef comments
sound: Remove stray pluses from Kconfig file
radio-shark: Fix printk "CONFIG_LED_CLASS"
doc: put proper reference to CONFIG_MODULE_SIG_ENFORCE
...
24 Apr, 2013
1 commit
-
Fix typo in printk and comments within various drivers.
Signed-off-by: Masanari Iida
Signed-off-by: Jiri Kosina
21 Apr, 2013
1 commit
-
Fix this:
warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)
Cc: stable@vger.kernel.org
Signed-off-by: Suman Anna
[edit commit log]
Signed-off-by: Ohad Ben-Cohen
15 Apr, 2013
1 commit
-
Adding a new remoteproc driver for OMAP-L13x DSP
Signed-off-by: Robert Tivy
[removed 'EXPERIMENTAL' and fixed some indentation issues]
Signed-off-by: Ohad Ben-Cohen
07 Apr, 2013
7 commits
-
If rproc_alloc isn't given a firmware name, look for a default
one using the "rproc-%s-fw" template.Signed-off-by: Robert Tivy
[add commit log, document change, use snprintf, minor style change]
Signed-off-by: Ohad Ben-Cohen -
Fix obvious typo introduced in commit e121aefa7d9f10eee5cf26ed47129237a05d940b
("remoteproc: fix missing CONFIG_FW_LOADER configurations").Cc: stable@vger.kernel.org
Signed-off-by: Robert Tivy
[cc stable, slight subject change]
Signed-off-by: Ohad Ben-Cohen -
This allows building remoteproc on OMAP5 too.
Signed-off-by: Vincent Stehlé
[edit commit log]
Signed-off-by: Ohad Ben-Cohen -
Set the vring addresses in the resource table so that
the remote device can read the actual addresses used.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[rebase]
Signed-off-by: Ohad Ben-Cohen -
Support virtio configuration space and device status. The virtio
device can now access the resource table in shared memory.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[rebase and style changes]
Signed-off-by: Ohad Ben-Cohen -
Copy resource table from first to second firmware loading.
After firmware is loaded to memory, update the vdevs resource
pointer to the resource table kept in device memory.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[rebase, terminology and style changes]
Signed-off-by: Ohad Ben-Cohen -
Simplify handling of max_notifyid by simply counting the
number of vrings.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[small terminology changes]
Signed-off-by: Ohad Ben-Cohen
05 Apr, 2013
7 commits
-
Combine the almost identical functions rproc_handle_virtio_rsc
and rproc_handle_boot_rsc.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[small terminology and style changes]
Signed-off-by: Ohad Ben-Cohen -
Parse the STE firmware and scan the TOC-table to find the address
of the loaded resource table.Signed-off-by: Sjur Brændeland
[rebase patch; update terminology]
Signed-off-by: Ohad Ben-Cohen -
Add function find_loaded_rsc_table to firmware ops. This function
returns the location of the resource table in shared memory
after loading.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[align function name with existing terminology, update commit log]
[document new function, rebase patch, small cleanups]
Signed-off-by: Ohad Ben-Cohen -
Refactor rproc_elf_find_rsc_table() and split out the scanning
for the section header named resource table. This is done to
prepare for loading firmware once.Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[small function name change to make the code easier to read]
Signed-off-by: Ohad Ben-Cohen -
Remove the vdev entry from the list before freeing it,
otherwise rproc->vdevs will explode.Cc: stable@vger.kernel.org
Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[edit subject, minor commit log edit, cc stable]
Signed-off-by: Ohad Ben-Cohen -
Fixes coherent memory leakage, caused by non-deallocated
firmware image chunk.Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Tarnyagin
Signed-off-by: Sjur Brændeland
Acked-by: Ido Yariv
[slightly edit subject and commit log]
Signed-off-by: Ohad Ben-Cohen -
The new idr_alloc interface returns the allocated id back
on success, so fix the error path to check for negative
values. This was missed out in the newer idr interface
adoption patch, 15fc611 "remoteproc: convert to idr_alloc()".Signed-off-by: Suman Anna
Acked-by: Tejun Heo
Signed-off-by: Ohad Ben-Cohen
28 Feb, 2013
2 commits
-
Convert to the much saner new idr interface.
Signed-off-by: Tejun Heo
Cc: Ohad Ben-Cohen
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated. Drop its usage.Signed-off-by: Tejun Heo
Cc: Ohad Ben-Cohen
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
27 Feb, 2013
1 commit
-
Pull virtio updates from Rusty Russell:
"All trivial, thanks to the stuff which didn't quite make it time"* tag 'virtio-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
virtio_console: Initialize guest_connected=true for rproc_serial
virtio: use module_virtio_driver.
virtio: Add module driver macro for virtio drivers.
virtio_console: Use virtio device index to generate port name
virtio: make pci_device_id const
virtio: make config_ops const
virtio-mmio: fix wrong comment about register offset
virtio_console: Let unconnected rproc device receive data.
22 Feb, 2013
1 commit
-
Pull ARM SoC multiplatform support from Arnd Bergmann:
"Converting more ARM platforms to multiplatform support. This time,
OMAP gets converted, which is a major step since this is by far the
largest platform in terms of code size. The same thing happens to the
vt8500 platform."* tag 'multiplatform' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc:
net: cwdavinci_cpdma: export symbols for cpsw
remoteproc: omap: depend on OMAP_MBOX_FWK
[media] davinci: do not include mach/hardware.h
ARM: OMAP2+: Make sure files with omap initcalls include soc.h
ARM: OMAP2+: Include soc.h to drm.c to fix compiling
ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall
ARM: multi_v7_defconfig: add ARCH_ZYNQ
ARM: multi_v7_defconfig: remove unnecessary CONFIG_GPIOLIB
arm: vt8500: Remove remaining mach includes
arm: vt8500: Convert debug-macro.S to be multiplatform friendly
arm: vt8500: Remove single platform Kconfig options
ARM: OMAP2+: Remove now obsolete uncompress.h and debug-macro.S
ARM: OMAP2+: Add minimal support for booting vexpress
ARM: OMAP2+: Enable ARCH_MULTIPLATFORM support
ARM: OMAP2+: Disable code that currently does not work with multiplaform
ARM: OMAP2+: Add multiplatform debug_ll support
ARM: OMAP: Fix dmaengine init for multiplatform
ARM: OMAP: Fix i2c cmdline initcall for multiplatform
ARM: OMAP2+: Use omap initcalls
ARM: OMAP2+: Limit omap initcalls to omap only on multiplatform kernels
15 Feb, 2013
1 commit
-
Patch a62a6e98 "ARM: OMAP2+: Disable code that currently does not work
with multiplaform" makes the OMAP_MBOX_FWK option depend on !MULTIPLATFORM,
which means we cannot simply select that symbol from OMAP_REMOTEPROC.Turning the 'select' into 'depends on' ensures that all dependencies
are correct until OMAP_MBOX_FWK loses its dependency.Without this patch, building allmodconfig results in:
drivers/remoteproc/omap_remoteproc.c:31:26: fatal error: plat/mailbox.h: No such file or directory
Signed-off-by: Arnd Bergmann
Acked-by: Tony Lindgren
Acked-by: Ohad Ben-Cohen
11 Feb, 2013
1 commit
-
It is just a table of function pointers, make it const for cleanliness and security
reasons.Signed-off-by: Stephen Hemminger
Signed-off-by: Rusty Russell
22 Jan, 2013
1 commit
-
The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
while now and is almost always enabled by default. As agreed during the
Linux kernel summit, remove it from any "depends on" lines in Kconfigs.CC: Ohad Ben-Cohen
Signed-off-by: Kees Cook
Signed-off-by: Greg Kroah-Hartman
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Signed-off-by: Greg Kroah-Hartman
14 Dec, 2012
1 commit
-
Pull trivial branch from Jiri Kosina:
"Usual stuff -- comment/printk typo fixes, documentation updates, dead
code elimination."* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (39 commits)
HOWTO: fix double words typo
x86 mtrr: fix comment typo in mtrr_bp_init
propagate name change to comments in kernel source
doc: Update the name of profiling based on sysfs
treewide: Fix typos in various drivers
treewide: Fix typos in various Kconfig
wireless: mwifiex: Fix typo in wireless/mwifiex driver
messages: i2o: Fix typo in messages/i2o
scripts/kernel-doc: check that non-void fcts describe their return value
Kernel-doc: Convention: Use a "Return" section to describe return values
radeon: Fix typo and copy/paste error in comments
doc: Remove unnecessary declarations from Documentation/accounting/getdelays.c
various: Fix spelling of "asynchronous" in comments.
Fix misspellings of "whether" in comments.
eisa: Fix spelling of "asynchronous".
various: Fix spelling of "registered" in comments.
doc: fix quite a few typos within Documentation
target: iscsi: fix comment typos in target/iscsi drivers
treewide: fix typo of "suport" in various comments and Kconfig
treewide: fix typo of "suppport" in various comments
...
03 Dec, 2012
1 commit
-
Fix typos in printk within various drivers.
Signed-off-by: Masanari Iida
Signed-off-by: Jiri Kosina