Eric Lee / smarc-ti-linux-kernel

10 Oct, 2012

1 commit

  • c3d59ad6a   ext3: ext3_bread usage audit ... Browse Code »

    This is the ext3 version of the same patch applied to Ext4, where such goal is
    to audit the usage of ext3_bread() due a possible misinterpretion of its return
    value.

    Focused on directory blocks, a NULL value returned from ext3_bread() means a
    hole, which cannot exist into a directory inode. It can pass undetected after a
    fix in an uninitialized error variable.

    The (now) initialized variable into ext3_getblk() may lead to a zero'ed return
    value of ext3_bread() to its callers, which can make the caller do not detect
    the hole in the directory inode.

    This patch creates a new wrapper function ext3_dir_bread() which checks for
    holes properly, reports error, and returns EIO in that case.

    Signed-off-by: Carlos Maiolino
    Signed-off-by: Jan Kara

    Carlos Maiolino
     

31 Oct, 2005

1 commit

  • 381be2545   [PATCH] ext3: sparse fixes ... Browse Code »

    Fix warnings from sparse due to un-declared functions that should either
    have a header file or have been declared static

    fs/ext2/bitmap.c:14:15: warning: symbol 'ext2_count_free' was not declared. Should it be static?
    fs/ext2/namei.c:92:15: warning: symbol 'ext2_get_parent' was not declared. Should it be static?
    fs/ext3/bitmap.c:15:15: warning: symbol 'ext3_count_free' was not declared. Should it be static?
    fs/ext3/namei.c:1013:15: warning: symbol 'ext3_get_parent' was not declared. Should it be static?
    fs/ext3/xattr.c:214:1: warning: symbol 'ext3_xattr_block_get' was not declared. Should it be static?
    fs/ext3/xattr.c:358:1: warning: symbol 'ext3_xattr_block_list' was not declared. Should it be static?
    fs/ext3/xattr.c:630:1: warning: symbol 'ext3_xattr_block_find' was not declared. Should it be static?
    fs/ext3/xattr.c:863:1: warning: symbol 'ext3_xattr_ibody_find' was not declared. Should it be static?

    Signed-off-by: Ben Dooks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Dooks