08 Apr, 2014

1 commit


30 Mar, 2014

1 commit

  • The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
    for opportunities to replace a call to memcpy by a struct assignment.
    This patch removes memcpy-assign.cocci as it is not clear that this
    convention has an impact on the generated code.

    Signed-off-by: Peter Senna Tschudin
    Signed-off-by: Michal Marek

    Peter Senna Tschudin
     

03 Jan, 2014

1 commit

  • As indicated by Sekhar in [1], there seems to be a tendency to use
    IS_ERR_VALUE to check the error result for pm_runtime_* functions which
    make no sense considering commit c48cd65 (ARM: OMAP: use consistent
    error checking) - the error values can either be < 0 for error OR
    0, 1 in cases where we have success.

    So, setup a coccinelle script to help identify the same.

    [1] http://marc.info/?t=138472678100003&r=1&w=2

    Cc: Russell King
    Reported-by: Sekhar Nori
    Signed-off-by: Nishanth Menon
    Acked-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nishanth Menon
     

23 Oct, 2013

1 commit


08 Sep, 2013

1 commit

  • Pull misc kbuild updates from Michal Marek:
    "In the kbuild misc branch, I have:
    - make rpm-pkg updates, most importantly the rpm package now calls
    /sbin/installkernel
    - make deb-pkg: debuginfo split, correct kernel image path for
    parisc, mips and powerpc and a couple more minor fixes
    - New coccinelle check"

    * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
    scripts/checkkconfigsymbols.sh: replace echo -e with printf
    Provide version number for Debian firmware package
    coccinelle: replace 0/1 with false/true in functions returning bool
    deb-pkg: add a hook argument to match debian hooks parameters
    deb-pkg: fix installed image path on parisc, mips and powerpc
    deb-pkg: split debug symbols in their own package
    deb-pkg: use KCONFIG_CONFIG instead of .config file directly
    rpm-pkg: add generation of kernel-devel
    rpm-pkg: install firmware files in kernel relative directory
    rpm-pkg: add %post section to create initramfs and grub hooks

    Linus Torvalds
     

14 Aug, 2013

1 commit


15 Jul, 2013

1 commit


04 Jul, 2013

1 commit


03 Jul, 2013

1 commit


14 Jun, 2013

1 commit


28 Feb, 2013

1 commit

  • Pull misc non-critical kbuild changes from Michal Marek:

    - Fix for make TAGS

    - Fix for make rpm

    - Some new coccinelle semantic patches

    * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
    scripts/coccinelle: find constant additions that could be bit ors
    coccicheck: Allow to show the executed command line
    coccicheck: Allow the user to give a V= (verbose) argument
    scripts/coccinelle/misc/memcpy-assign.cocci: Replace memcpy with struct assignment
    kbuild: clear KBUILD_SRC when calling 'make' in RPM spec
    scripts/coccinelle/misc/semicolon.cocci: Add unneeded semicolon test
    scripts/tags.sh: Fix regex syntax for etags

    Linus Torvalds
     

22 Feb, 2013

2 commits


24 Jan, 2013

1 commit

  • This semantic patch looks for semicolons that can be removed without
    changing the semantics of the code. The confidence is moderate
    because there are some false positives on cases like:

    b/drivers/mmc/host/cb710-mmc.c:589
    break;
    case MMC_POWER_UP:
    default:
    - /* ignore */;
    }

    There are 37 patches accepted reported by this semantic patch and
    more than 300 fixes to be applied.

    Signed-off-by: Peter Senna Tschudin
    Signed-off-by: Michal Marek

    Peter Senna Tschudin
     

23 Jan, 2013

1 commit

  • The devm_request_and_ioremap() function is very useful and helps avoid a
    whole lot of boilerplate. However, one issue that keeps popping up is
    its lack of a specific error code to determine which of the steps that
    it performs failed. Furthermore, while the function gives an example and
    suggests what error code to return on failure, a wide variety of error
    codes are used throughout the tree.

    In an attempt to fix these problems, this patch adds a new function that
    drivers can transition to. The devm_ioremap_resource() returns a pointer
    to the remapped I/O memory on success or an ERR_PTR() encoded error code
    on failure. Callers can check for failure using IS_ERR() and determine
    its cause by extracting the error code using PTR_ERR().

    devm_request_and_ioremap() is implemented as a wrapper around the new
    API and return NULL on failure as before. This ensures that backwards
    compatibility is maintained until all users have been converted to the
    new API, at which point the old devm_request_and_ioremap() function
    should be removed.

    A semantic patch is included which can be used to convert from the old
    devm_request_and_ioremap() API to the new devm_ioremap_resource() API.
    Some non-trivial cases may require manual intervention, though.

    Signed-off-by: Thierry Reding
    Cc: Arnd Bergmann
    Acked-by: Dmitry Torokhov
    Signed-off-by: Greg Kroah-Hartman

    Thierry Reding
     

21 Dec, 2012

1 commit

  • Pull kbuild misc changes from Michal Marek:
    "This is the non-critical part of kbuild

    - scripts/kernel-doc requires a "Return:" section for non-void
    functions
    - ARCH=arm SUBARCH=... support for make tags
    - COMPILED_SOURCE=1 support for make tags (only indexes .c files for
    which a .o exists)
    - New coccinelle check
    - Option parsing fix for scripts/config"

    * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
    scripts/config: Fix wrong "shift" for --keep-case
    scripts/tags.sh: Support compiled source
    scripts/tags.sh: Support subarch for ARM
    scripts/coccinelle/misc/warn.cocci: use WARN
    scripts/kernel-doc: check that non-void fcts describe their return value
    Kernel-doc: Convention: Use a "Return" section to describe return values

    Linus Torvalds
     

19 Dec, 2012

1 commit


09 Dec, 2012

1 commit


12 Oct, 2012

1 commit

  • Pull kbuild misc changes from Michal Marek:
    "In the non-critical part of kbuild, I have
    - Some make coccicheck improvements and two new tests
    - Support for a cleaner html output in scripts/kernel-doc, named
    html5 (no, it does not play videos, yet)

    BTW, Randy wants to route further kernel-doc patches through the
    kbuild tree."

    * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
    Update SmPL/Coccinelle section of MAINTAINERS
    coccicheck: Add the rep+ctxt mode
    scripts/coccinelle/tests/odd_ptr_err.cocci: semantic patch for IS_ERR/PTR_ERR inconsistency
    scripts/tags.sh: Add magic for pci access functions
    scripts/coccinelle: ptr_ret: Add ternary operator version
    scripts/kernel-doc: drop maintainer
    scripts/kernel-doc: added support for html5

    Linus Torvalds
     

11 Oct, 2012

1 commit


02 Oct, 2012

1 commit

  • Pull the trivial tree from Jiri Kosina:
    "Tiny usual fixes all over the place"

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (34 commits)
    doc: fix old config name of kprobetrace
    fs/fs-writeback.c: cleanup riteback_sb_inodes kerneldoc
    btrfs: fix the commment for the action flags in delayed-ref.h
    btrfs: fix trivial typo for the comment of BTRFS_FREE_INO_OBJECTID
    vfs: fix kerneldoc for generic_fh_to_parent()
    treewide: fix comment/printk/variable typos
    ipr: fix small coding style issues
    doc: fix broken utf8 encoding
    nfs: comment fix
    platform/x86: fix asus_laptop.wled_type module parameter
    mfd: printk/comment fixes
    doc: getdelays.c: remember to close() socket on error in create_nl_socket()
    doc: aliasing-test: close fd on write error
    mmc: fix comment typos
    dma: fix comments
    spi: fix comment/printk typos in spi
    Coccinelle: fix typo in memdup_user.cocci
    tmiofb: missing NULL pointer checks
    tools: perf: Fix typo in tools/perf
    tools/testing: fix comment / output typos
    ...

    Linus Torvalds
     

01 Sep, 2012

1 commit


31 Aug, 2012

1 commit


14 Jul, 2012

1 commit


13 Jul, 2012

1 commit


29 May, 2012

1 commit

  • Pull misc kbuild changes from Michal Marek:
    "The non-critical part of kbuild for 3.5 includes

    - two new coccinelle checks
    - fix for make deb-pkg to include generated headers in arch/*/include

    I have more make-deb-pkg fixes in the backlog, but these will likely
    have to wait for 3.6."

    * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
    builddeb: include autogenerated header files
    scripts/coccinelle: sizeof of pointer
    scripts/coccinelle: address test is always true

    Linus Torvalds
     

25 May, 2012

2 commits


06 Apr, 2012

2 commits

  • Merge batch of fixes from Andrew Morton:
    "The simple_open() cleanup was held back while I wanted for laggards to
    merge things.

    I still need to send a few checkpoint/restore patches. I've been
    wobbly about merging them because I'm wobbly about the overall
    prospects for success of the project. But after speaking with Pavel
    at the LSF conference, it sounds like they're further toward
    completion than I feared - apparently davem is at the "has stopped
    complaining" stage regarding the net changes. So I need to go back
    and re-review those patchs and their (lengthy) discussion."

    * emailed from Andrew Morton : (16 patches)
    memcg swap: use mem_cgroup_uncharge_swap fix
    backlight: add driver for DA9052/53 PMIC v1
    C6X: use set_current_blocked() and block_sigmask()
    MAINTAINERS: add entry for sparse checker
    MAINTAINERS: fix REMOTEPROC F: typo
    alpha: use set_current_blocked() and block_sigmask()
    simple_open: automatically convert to simple_open()
    scripts/coccinelle/api/simple_open.cocci: semantic patch for simple_open()
    libfs: add simple_open()
    hugetlbfs: remove unregister_filesystem() when initializing module
    drivers/rtc/rtc-88pm860x.c: fix rtc irq enable callback
    fs/xattr.c:setxattr(): improve handling of allocation failures
    fs/xattr.c:listxattr(): fall back to vmalloc() if kmalloc() failed
    fs/xattr.c: suppress page allocation failure warnings from sys_listxattr()
    sysrq: use SEND_SIG_FORCED instead of force_sig()
    proc: fix mount -t proc -o AAA

    Linus Torvalds
     
  • Find instances of an open-coded simple_open() and replace them with
    calls to simple_open().

    Signed-off-by: Julia Lawall
    Reported-by: Stephen Boyd
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

27 Mar, 2012

1 commit


25 Feb, 2012

5 commits


15 Jan, 2012

3 commits


03 Dec, 2010

1 commit

  • For doubleinit.cocci, Coccinelle 0.2.4 requires a comma after ... in a
    field list. Coccinelle also now behaves gracefully when a definition is
    provided for a virtual that doesn't exist, so there is no need for the
    semantic patch code to check for this case.

    Updated the documentation to reflect the fact that the best results will
    now be obtained with Coccinelle version 0.2.4 or later.

    Signed-off-by: Julia Lawall

    Julia Lawall