17 Mar, 2011

7 commits


15 Mar, 2011

1 commit


14 Mar, 2011

11 commits

  • hpwdt_init_nmi_decoding() is called in hpwdt_init_one error handling,
    thus remove the __devexit annotation of hpwdt_exit_nmi_decoding().

    This patch fixes below warning:

    WARNING: drivers/watchdog/hpwdt.o(.devinit.text+0x36f): Section mismatch in reference from the function hpwdt_init_one() to the function .devexit.text:hpwdt_exit_nmi_decoding()
    The function __devinit hpwdt_init_one() references
    a function __devexit hpwdt_exit_nmi_decoding().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    hpwdt_exit_nmi_decoding() so it may be used outside an exit section.

    Signed-off-by: Axel Lin
    Acked-by: Thomas Mingarelli
    Signed-off-by: Wim Van Sebroeck

    Axel Lin
     
  • outb_p(c || 0x01, WDT_EFDR); -> || should be |

    Reported-By: Toralf Förster
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • "==" has higher precedence than "&". Since
    if (sch311x_sio_inb(sio_config_port, 0x30) & (0x01 == 0)) is always
    false the message is never printed.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Wim Van Sebroeck

    Dan Carpenter
     
  • if (sch311x_sio_inb(sio_config_port, 0x30) && 0x01 == 0) -> && should be &

    Reported-By: Toralf Förster
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • cppcheck-1.47 reports:
    [drivers/watchdog/cpwd.c:650]: (error) Buffer access out-of-bounds: p.devs

    The source code is
    for (i = 0; i < 4; i++) {
    misc_deregister(&p->devs[i].misc);

    where devs is defined as WD_NUMDEVS big and WD_NUMDEVS is equal to 3.
    So the 4 should be a 3 or WD_NUMDEVS.

    Reported-By: David Binderman
    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     
  • So we used to use lpfn directly to restrict VRAM when we couldn't
    access the unmappable area, however this was removed in
    93225b0d7bc030f4a93165347a65893685822d70 as it also restricted
    the gtt placements. However it was only later noticed that this
    broke on some hw.

    This removes the active_vram_size, and just explicitly sets it
    when it changes, TTM/drm_mm will always use the real_vram_size,
    and the active vram size will change the TTM size used for lpfn
    setting.

    We should re-work the fpfn/lpfn to per-placement at some point
    I suspect, but that is too late for this kernel.

    Hopefully this addresses:
    https://bugs.freedesktop.org/show_bug.cgi?id=35254

    v2: fix reported useful VRAM size to userspace to be correct.

    Signed-off-by: Dave Airlie

    Dave Airlie
     
  • * 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging:
    hwmon/f71882fg: Set platform drvdata to NULL later
    hwmon/f71882fg: Fix a typo in a comment

    Linus Torvalds
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6:
    [SCSI] target: Fix t_transport_aborted handling in LUN_RESET + active I/O shutdown

    Linus Torvalds
     
  • * git://git.infradead.org/users/dwmw2/mtd-2.6.38:
    mtd: add "platform:" prefix for platform modalias
    mtd: mtd_blkdevs: fix double free on error path
    mtd: amd76xrom: fix oops at boot when resources are not available
    mtd: fix race in cfi_cmdset_0001 driver
    mtd: jedec_probe: initialise make sector erase command variable
    mtd: jedec_probe: Change variable name from cfi_p to cfi

    Linus Torvalds
     
  • * 'drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6:
    drm/radeon: fix page flipping hangs on r300/r400
    drm/radeon: add pageflip hooks for fusion

    Linus Torvalds
     
  • The device table is required to load modules based on modaliases.

    After adding MODULE_DEVICE_TABLE, below entries will be added to
    modules.pcimap:

    pch_gpio 0x00008086 0x00008803 0xffffffff 0xffffffff 0x00000000 0x00000000 0x0
    ml_ioh_gpio 0x000010db 0x0000802e 0xffffffff 0xffffffff 0x00000000 0x00000000 0x0

    Signed-off-by: Axel Lin
    Cc: Tomoya MORINAGA
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     

13 Mar, 2011

3 commits


11 Mar, 2011

12 commits

  • Since 43cc71eed1250755986da4c0f9898f9a635cb3bf (platform: prefix MODALIAS
    with "platform:"), the platform modalias is prefixed with "platform:".

    Signed-off-by: Axel Lin
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org

    Axel Lin
     
  • This one liner patch fixes double free that will occur if add_mtd_blktrans_dev
    fails. On failure it frees the input argument, but all its users also free it
    on error which is natural thing to do. Thus don't free it.

    All credit for finding that bug belongs to reporters of the bug in the android bugzilla
    http://code.google.com/p/android/issues/detail?id=13761

    Commit message tweaked by Artem.

    Signed-off-by: Maxim Levitsky
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org

    Maxim Levitsky
     
  • For some unknown reasons resources needed by amd76xrom driver can be
    unavailable. And instead of returning an error, the driver keeps going
    and crash the kernel. This patch fixes the problem by making the driver
    return -EBUSY if the resources are not available.

    Commit messages tweaked by Artem.

    Reported-by: Russell Whitaker
    Signed-off-by: Stanislaw Gruszka
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org

    Stanislaw Gruszka
     
  • As inval_cache_and_wait_for_operation() drop and reclaim the lock
    to invalidate the cache, some other thread may suspend the operation
    before reaching the for(;;) loop. Therefore the loop must start with
    checking the chip->state before reading status from the chip.

    Signed-off-by: Joakim Tjernlund
    Acked-by: Michael Cashwell
    Acked-by: Stefan Bigler
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse
    Cc: stable@kernel.org

    Joakim Tjernlund
     
  • In the commit 08968041bef437ec363623cd3218c2b083537ada
    (mtd: cfi_cmdset_0002: make sector erase command variable)
    introdused a field sector_erase_cmd. In the same commit initialisation
    of cfi->sector_erase_cmd made in cfi_chip_setup()
    (file drivers/mtd/chips/cfi_probe.c), so the CFI chip has no problem:

    ...
    cfi->cfi_mode = CFI_MODE_CFI;
    cfi->sector_erase_cmd = CMD(0x30);
    ...

    But for the JEDEC chips this initialisation is not carried out,
    so the JEDEC chips have sector_erase_cmd == 0.

    This patch adds the missing initialisation.

    Signed-off-by: Antony Pavlov
    Acked-by: Guillaume LECERF
    Signed-off-by: David Woodhouse
    CC: stable@kernel.org

    Antony Pavlov
     
  • In the following commit, we'll need to use the CMD() macro in order to
    fix the initialisation of the sector_erase_cmd field. That requires the
    local variable to be called 'cfi', so change it first in a simple patch.

    Signed-off-by: Antony Pavlov
    Acked-by: Guillaume LECERF
    Signed-off-by: David Woodhouse
    CC: stable@kernel.org

    Antony Pavlov
     
  • Looks like these got passed over with both being merged at the same
    time but not quite meeting in the middle.

    should fix: https://bugs.freedesktop.org/show_bug.cgi?id=34137
    along with Michael's phoronix article.

    Reported-by: Chi-Thanh Christopher Nguyen
    Article-written-by: Michael Larabel @ phoronix
    Signed-off-by: Dave Airlie

    Dave Airlie
     
  • Simply remove redundant 'dev' NULL check.

    Signed-off-by: Jinqiu Yang
    Signed-off-by: David S. Miller

    j223yang@asset.uwaterloo.ca
     
  • David S. Miller
     
  • * 'media_fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6:
    [media] mantis_pci: remove asm/pgtable.h include
    [media] tda829x: fix regression in probe functions
    [media] mceusb: don't claim multifunction device non-IR parts
    [media] nuvoton-cir: fix wake from suspend
    [media] cx18: Add support for Hauppauge HVR-1600 models with s5h1411
    [media] ivtv: Fix corrective action taken upon DMA ERR interrupt to avoid hang
    [media] cx25840: fix probing of cx2583x chips
    [media] cx23885: Remove unused 'err:' labels to quiet compiler warning
    [media] cx23885: Revert "Check for slave nack on all transactions"
    [media] DiB7000M: add pid filtering
    [media] Fix sysfs rc protocol lookup for rc-5-sz
    [media] au0828: fix VBI handling when in V4L2 streaming mode
    [media] ir-raw: Properly initialize the IR event (BZ#27202)
    [media] s2255drv: firmware re-loading changes
    [media] Fix double free of video_device in mem2mem_testdev
    [media] DM04/QQBOX memcpy to const char fix

    Linus Torvalds
     
  • This patch fixes an issue in OpenIPMI module where sometimes an ABORT command
    is sent after sending an IPMI request to BMC causing the IPMI request to fail.

    Signed-off-by: YiCheng Doe
    Signed-off-by: Corey Minyard
    Acked-by: Tom Mingarelli
    Tested-by: Andy Cress
    Tested-by: Mika Lansirine
    Tested-by: Brian De Wolf
    Cc: Jean Michel Audet
    Cc: Jozef Sudelsky
    Acked-by: Matthew Garrett
    Signed-off-by: Linus Torvalds

    Doe, YiCheng
     
  • This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb

    drm/i915: Do not handle backlight combination mode specially

    since this commit introduced other regressions due to untouched LBPC
    register, e.g. the backlight dimmed after resume.

    In addition to the revert, this patch includes a fix for the original
    issue (weird backlight levels) by removing the wrong bit shift for
    computing the current backlight level.
    Also, including typo fixes (lpbc -> lbpc).

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34524
    Acked-by: Indan Zupancic
    Reviewed-by: Keith Packard
    Reviewed-by: Jesse Barnes
    Cc:
    Signed-off-by: Takashi Iwai
    Signed-off-by: Linus Torvalds

    Takashi Iwai
     

10 Mar, 2011

4 commits

  • * git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog:
    watchdog: sbc_fitpc2_wdt, fix crash on systems without DMI_BOARD_NAME

    Linus Torvalds
     
  • * 'for-2639-rc7/i2c-fixes' of git://git.fluff.org/bjdooks/linux:
    i2c-eg20t: include slab.h for memory allocations
    i2c-ocores: Fix pointer type mismatch error
    i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup

    Linus Torvalds
     
  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc:
    mmc: fix CONFIG_MMC_UNSAFE_RESUME regression

    Linus Torvalds
     
  • Some systems don't provide DMI_BOARD_NAME in their DMI tables. Avoid
    crash in such situations in fitpc2_wdt_init.

    The fix is to check if the dmi_get_system_info return value is NULL.

    The oops:
    BUG: unable to handle kernel NULL pointer dereference at (null)
    IP: [] strstr+0x26/0xa0
    PGD 3966e067 PUD 39605067 PMD 0
    Oops: 0000 [#1] SMP
    last sysfs file: /sys/devices/system/cpu/cpu1/cache/index2/shared_cpu_map
    CPU 1
    Modules linked in: ...
    Pid: 1748, comm: modprobe Not tainted 2.6.37-22-default #1 /Bochs
    RIP: 0010:[] [] strstr+0x26/0xa0
    RSP: 0018:ffff88003ad73f18 EFLAGS: 00010206
    RAX: 0000000000000000 RBX: 00000000ffffffed RCX: 00000000ffffffff
    RDX: ffffffffa003f4cc RSI: ffffffffa003f4c2 RDI: 0000000000000000
    ...
    CR2: 0000000000000000 CR3: 000000003b7ac000 CR4: 00000000000006e0
    ...
    Process modprobe (pid: 1748, threadinfo ffff88003ad72000, task ffff88002e6365c0)
    Stack: ...
    Call Trace:
    [] fitpc2_wdt_init+0x1f/0x13c [sbc_fitpc2_wdt]
    [] do_one_initcall+0x3a/0x170
    ...
    Code: f3 c3 0f 1f 00 80 3e 00 53 48 89 f8 74 1b 48 89 f2 0f 1f 40 00 48 83 c2 01 80 3a 00 75 f7 49 89 d0 48 89 f8 49 29 f0 75 02 5b c3 3f 00 74 0e 0f 1f 44 00 00 48 83 c0 01 80 38 00 75 f7 49 89

    Signed-off-by: Jiri Slaby
    Signed-off-by: Wim Van Sebroeck

    Jiri Slaby
     

09 Mar, 2011

2 commits

  • Fixes (with v2.6.38-rc3/parisc/parisc-allmodconfig):
    src/drivers/i2c/busses/i2c-eg20t.c:720: error: implicit declaration of function 'kzalloc'
    src/drivers/i2c/busses/i2c-eg20t.c:790: error: implicit declaration of function 'kfree'

    Reported-by: Geert Uytterhoeven
    Signed-off-by: Wolfram Sang
    Cc: Tomoya MORINAGA
    Cc: Ben Dooks
    Signed-off-by: Ben Dooks

    Wolfram Sang
     
  • ocores_i2c_of_probe needs to use a const __be32 type for handing
    device tree property values. This patch fixed the following build
    warning:

    CC drivers/i2c/busses/i2c-ocores.o
    drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe':
    drivers/i2c/busses/i2c-ocores.c:254: warning: assignment discards qualifiers from pointer target type
    drivers/i2c/busses/i2c-ocores.c:261: warning: assignment discards qualifiers from pointer target type

    Signed-off-by: Grant Likely
    Cc: Peter Korsgaard
    Cc: Ben Dooks
    Cc: linux-i2c@vger.kernel.org
    Signed-off-by: Ben Dooks

    Grant Likely