Commit 637d32dc720897616e8a1a4f9e9609e29d431800

Authored by Eric Paris
Committed by James Morris
1 parent e68b75a027

Capabilities: BUG when an invalid capability is requested

If an invalid (large) capability is requested the capabilities system
may panic as it is dereferencing an array of fixed (short) length.  Its
possible (and actually often happens) that the capability system
accidentally stumbled into a valid memory region but it also regularly
happens that it hits invalid memory and BUGs.  If such an operation does
get past cap_capable then the selinux system is sure to have problems as
it already does a (simple) validity check and BUG.  This is known to
happen by the broken and buggy firegl driver.

This patch cleanly checks all capable calls and BUG if a call is for an
invalid capability.  This will likely break the firegl driver for some
situations, but it is the right thing to do.  Garbage into a security
system gets you killed/bugged

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Acked-by: Andrew G. Morgan <morgan@kernel.org>
Signed-off-by: James Morris <jmorris@namei.org>

Showing 1 changed file with 5 additions and 0 deletions Side-by-side Diff

... ... @@ -514,6 +514,11 @@
514 514 */
515 515 int capable(int cap)
516 516 {
  517 + if (unlikely(!cap_valid(cap))) {
  518 + printk(KERN_CRIT "capable() called with invalid cap=%u\n", cap);
  519 + BUG();
  520 + }
  521 +
517 522 if (has_capability(current, cap)) {
518 523 current->flags |= PF_SUPERPRIV;
519 524 return 1;