20 Apr, 2006

40 commits

  • WARNING: drivers/video/pm2fb.o - Section mismatch: reference
    to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
    WARNING: drivers/video/pm2fb.o - Section mismatch: reference
    to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)

    They are caused because pm2fb_set_par() uses lowhsync and lowvsync which
    are marked __devinitdata.

    Signed-off-by: Darren Jenkins
    Signed-off-by: Adrian Bunk
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Darren Jenkins
     
  • gather_stats() is called with a spinlock held from check_pte_range. We
    cannot reschedule with a lock held.

    Signed-off-by: Christoph Lameter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Lameter
     
  • Add myself as the IPMI maintainer.

    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • In cases where a struct kretprobe's *_handler fields are non-NULL, it is
    possible to cause a system crash, due to the possibility of calls ending up
    in zombie functions. Documentation clearly states that unused *_handlers
    should be set to NULL, but kprobe users sometimes fail to do so.

    Fix it by setting the non-relevant fields of the struct kretprobe to NULL.

    Signed-off-by: Ananth N Mavinakayanahalli
    Acked-by: Jim Keniston
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ananth N Mavinakayanahalli
     
  • Those also break userland regs like following.

    00000000 :
    0: 0f b7 44 24 0c movzwl 0xc(%esp),%eax
    5: 83 ca ff or $0xffffffff,%edx
    8: 0f b7 4c 24 08 movzwl 0x8(%esp),%ecx
    d: 66 83 f8 ff cmp $0xffffffff,%ax
    11: 0f 44 c2 cmove %edx,%eax
    14: 66 83 f9 ff cmp $0xffffffff,%cx
    18: 0f 45 d1 cmovne %ecx,%edx
    1b: 89 44 24 0c mov %eax,0xc(%esp)
    1f: 89 54 24 08 mov %edx,0x8(%esp)
    23: e9 fc ff ff ff jmp 24

    where the tailcall at the end overwrites the incoming stack-frame.

    Signed-off-by: OGAWA Hirofumi
    [ I would _really_ like to have a way to tell gcc about calling
    conventions. The "prevent_tail_call()" macro is pretty ugly ]
    Signed-off-by: Linus Torvalds

    OGAWA Hirofumi
     
  • * 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
    IB/mthca: make a function static
    IB/ipath: Fix whitespace
    IB/ipath: Make more names static
    IB/mad: Fix RMPP version check during agent registration
    IB/srp: Remove request from list when SCSI abort succeeds

    Linus Torvalds
     
  • This patch makes the needlessly global mthca_update_rate() static.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Roland Dreier

    Adrian Bunk
     
  • Signed-off-by: Roland Dreier

    Roland Dreier
     
  • Make symbols that are only used in a single source file static.

    Signed-off-by: Roland Dreier

    Roland Dreier
     
  • Only check that RMPP version is not specified when MAD class does not
    support RMPP. Just because a class is allowed to use RMPP doesn't
    mean that rmpp_version needs to be set for the MAD agent to
    register. Checking this was a recent change which was too pedantic.

    Signed-off-by: Hal Rosenstock
    Signed-off-by: Roland Dreier

    Hal Rosenstock
     
  • If a SCSI abort succeeds, then the aborted request should to be
    removed from the list of pending requests. This fixes list corruption
    after an abort occurs.

    Signed-off-by: Roland Dreier

    Roland Dreier
     
  • * git://git.linux-nfs.org/pub/linux/nfs-2.6:
    SUNRPC: Dead code in net/sunrpc/auth_gss/auth_gss.c
    NFS: remove needless check in nfs_opendir()
    NFS: nfs_show_stats; for_each_possible_cpu(), not NR_CPUS
    NFS: make 2 functions static
    NFS,SUNRPC: Fix compiler warnings if CONFIG_PROC_FS & CONFIG_SYSCTL are unset
    NFS: fix PROC_FS=n compile error
    VFS: Fix another open intent Oops
    RPCSEC_GSS: fix leak in krb5 code caused by superfluous kmalloc

    Linus Torvalds
     
  • Hi,

    the coverity checker spotted that cred is always NULL
    when we jump to out_err ( there is just one case, when
    we fail to allocate the memory for cred )
    This is Coverity ID #79

    Signed-off-by: Eric Sesterhenn
    Signed-off-by: Trond Myklebust

    Eric Sesterhenn
     
  • Local variable res was initialized to 0 - no check needed here.

    Signed-off-by: Carsten Otte
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Trond Myklebust

    Carsten Otte
     
  • Convert a for-loop that explicitly references "NR_CPUS" into the
    potentially more efficient for_each_possible_cpu() construct.

    Signed-off-by: John Hawkes
    Signed-off-by: Andrew Morton
    Signed-off-by: Trond Myklebust

    John Hawkes
     
  • Signed-off-by: Adrian Bunk
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Trond Myklebust

    Adrian Bunk
     
  • Signed-off-by: Trond Myklebust

    Trond Myklebust
     
  • fs/built-in.o: In function `nfs_show_stats':inode.c:(.text+0x15481a): undefined reference to `rpc_print_iostats'
    net/built-in.o: In function `rpc_destroy_client': undefined reference to `rpc_free_iostats'
    net/built-in.o: In function `rpc_clone_client': undefined reference to `rpc_alloc_iostats'
    net/built-in.o: In function `rpc_new_client': undefined reference to `rpc_alloc_iostats'
    net/built-in.o: In function `xprt_release': undefined reference to `rpc_count_iostats'
    make: *** [.tmp_vmlinux1] Error 1

    Signed-off-by: Adrian Bunk
    Cc: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Trond Myklebust

    Adrian Bunk
     
  • If the call to nfs_intent_set_file() fails to open a file in
    nfs4_proc_create(), we should return an error.

    Signed-off-by: Trond Myklebust

    Trond Myklebust
     
  • I was sloppy when generating a previous patch; I modified the callers of
    krb5_make_checksum() to allocate memory for the buffer where the result is
    returned, then forgot to modify krb5_make_checksum to stop allocating that
    memory itself. The result is a per-packet memory leak. This fixes the
    problem by removing the now-superfluous kmalloc().

    Signed-off-by: J. Bruce Fields
    Signed-off-by: Trond Myklebust

    J. Bruce Fields
     
  • * 'splice' of git://brick.kernel.dk/data/git/linux-2.6-block:
    [PATCH] splice: fixup writeout path after ->map changes
    [PATCH] splice: offset fixes
    [PATCH] tee: link_pipe() must be careful when dropping one of the pipe locks
    [PATCH] splice: cleanup the SPLICE_F_NONBLOCK handling
    [PATCH] splice: close i_size truncate races on read

    Linus Torvalds
     
  • Fix return code of fb_write():

    If at least 1 byte was transferred to the device, return number of bytes,
    otherwise:

    - return -EFBIG - if file offset is past the maximum allowable offset or
    size is greater than framebuffer length
    - return -ENOSPC - if size is greater than framebuffer length - offset

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     
  • Fix modpost section mismatch warnings in savagefb driver:

    WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .exit.text after 'savagefb_remove' (at offset 0x66)
    WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .exit.text after 'savagefb_remove' (at offset 0x6e)
    WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.text: from .text.savagefb_resume after 'savagefb_resume' (at offset 0x70)

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • Marking radeon_pci_register() as __devinit clears up all section
    mismatch warnings that are caused by radeon_pci_register() calling
    various __devinit function. Is there some reason not to do this?

    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x628)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6b5)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6bd)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_probe_screens from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7d6)
    WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_check_modes from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7e5)

    Signed-off-by: Randy Dunlap
    Cc: "Antonino A. Daplas"
    Acked-by: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • Fix the following section mismatch:

    WARNING: drivers/video/savage/savagefb.o - Section mismatch: reference to .init.data: from .text.savagefb_probe after 'savagefb_probe' (at offset 0x5e2)

    Signed-off-by: Jean Delvare
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jean Delvare
     
  • From http://bugzilla.kernel.org/show_bug.cgi?id=6358

    The alim15x3.c havn't been update for 3 years. Recently when we use this
    "ULI M1573" south bridge chip found that can't mount CDROM(VCD) smoothly,
    must waiting for a long time. After I check the "ULI M1573" south bridge
    datasheet, I found the reason. The reason is the "ULI M1573" version in
    the Linux is "0xC7" not "0xC4" anymore So I was modified the source than it
    was successed.

    Cc: Bartlomiej Zolnierkiewicz
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    KAI.HSU
     
  • Noted by Sergei Shtylylov

    Signed-off-by: Adrian Bunk
    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Add support for the IDE device on ATI SB600

    Signed-off-by: Felix Kuehling
    Acked-by: Bartlomiej Zolnierkiewicz
    Cc: Alan Cox
    Acked-by: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Anatoli Antonovitch
     
  • Andrew Morton pointed out that compiler might not inline the functions
    marked for inline in kprobes. There-by allowing the insertion of probes
    on these kprobes routines, which might cause recursion.

    This patch removes all such inline and adds them to kprobes section
    there by disallowing probes on all such routines. Some of the routines
    can even still be inlined, since these routines gets executed after the
    kprobes had done necessay setup for reentrancy.

    Signed-off-by: Prasanna S Panchamukhi
    Acked-by: David S. Miller
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasanna S Panchamukhi
     
  • Andrew Morton pointed out that compiler might not inline the functions
    marked for inline in kprobes. There-by allowing the insertion of probes
    on these kprobes routines, which might cause recursion.

    This patch removes all such inline and adds them to kprobes section
    there by disallowing probes on all such routines. Some of the routines
    can even still be inlined, since these routines gets executed after the
    kprobes had done necessay setup for reentrancy.

    Signed-off-by: Prasanna S Panchamukhi
    Cc: "Luck, Tony"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasanna S Panchamukhi
     
  • Andrew Morton pointed out that compiler might not inline the functions
    marked for inline in kprobes. There-by allowing the insertion of probes
    on these kprobes routines, which might cause recursion.

    This patch removes all such inline and adds them to kprobes section
    there by disallowing probes on all such routines. Some of the routines
    can even still be inlined, since these routines gets executed after the
    kprobes had done necessay setup for reentrancy.

    Signed-off-by: Prasanna S Panchamukhi
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasanna S Panchamukhi
     
  • Andrew Morton pointed out that compiler might not inline the functions
    marked for inline in kprobes. There-by allowing the insertion of probes
    on these kprobes routines, which might cause recursion.

    This patch removes all such inline and adds them to kprobes section
    there by disallowing probes on all such routines. Some of the routines
    can even still be inlined, since these routines gets executed after the
    kprobes had done necessay setup for reentrancy.

    Signed-off-by: Prasanna S Panchamukhi
    Cc: Andi Kleen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasanna S Panchamukhi
     
  • Andrew Morton pointed out that compiler might not inline the functions
    marked for inline in kprobes. There-by allowing the insertion of probes
    on these kprobes routines, which might cause recursion.

    This patch removes all such inline and adds them to kprobes section
    there by disallowing probes on all such routines. Some of the routines
    can even still be inlined, since these routines gets executed after the
    kprobes had done necessay setup for reentrancy.

    Signed-off-by: Prasanna S Panchamukhi
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasanna S Panchamukhi
     
  • The wording of two messages in drivers/pnp/manager.c is incorrect. Fix that.

    Signed-off-by: Jan Engelhardt
    Acked-by: Pavel Machek
    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Engelhardt
     
  • From: Randy Dunlap

    Fix all modpost section mismatch warnings in parport_pc:

    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x230)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x283)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x3e6)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x400)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x463)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.text: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x488)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data:superios from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x54c)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data: from .text.parport_pc_probe_port after 'parport_pc_probe_port' (at offset 0x56a)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data: from .text.parport_pc_pci_probe after 'parport_pc_pci_probe' (at offset 0x67)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data: from .text.parport_pc_pci_probe after 'parport_pc_pci_probe' (at offset 0x9f)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data: from .text.parport_pc_pci_probe after 'parport_pc_pci_probe' (at offset 0xa7)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data:cards from .text.parport_pc_pci_probe after 'parport_pc_pci_probe' (at offset 0x132)
    WARNING: drivers/parport/parport_pc.o - Section mismatch: reference to .init.data: from .text.parport_pc_pci_probe after 'parport_pc_pci_probe' (at offset 0x142)

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy.Dunlap
     
  • I was looking into random driver code and found a suspicious looking
    memcpy() in drivers/char/ipmi/ipmi_bt_sm.c on 2.6.17-rc1:

    if ((size < 2) || (size > IPMI_MAX_MSG_LENGTH))
    return -1;
    ...
    memcpy(bt->write_data + 3, data + 1, size - 1);

    where sizeof bt->write_data is IPMI_MAX_MSG_LENGTH. It looks like the
    memcpy would overflow by 2 bytes if size == IPMI_MAX_MSG_LENGTH. A patch
    attached to limit size to (IPMI_MAX_LENGTH - 2).

    Cc: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Heikki Orsila
     
  • Fix potential NULL pointer deref in gen_init_cpio.c spotted by coverity
    checker. This fixes coverity bug #86

    Without this patch we risk dereferencing a NULL `type' in the
    "if ('\n' == *type) {" line.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     
  • Replace outdated help message with a reference to README. Update README
    for make *config variants and environment variable info.

    Signed-off-by: Randy Dunlap
    Acked-by: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • gcc complains about __devinit in the wrong location:
    drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types

    Signed-off-by: Randy Dunlap
    Acked-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • Add new line of /proc/meminfo output.

    Explain the HugePage_ lines in /proc/meminfo (from Bill Irwin).

    Change KB to kB since the latter is what is used in the kernel.

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap