22 Jul, 2011

1 commit

  • - unify vlan and nonvlan rx path
    - kill adapter->vlgrp and atl1c_vlan_rx_register
    - allow to turn on/off rx/tx vlan accel via ethtool (set_features)

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

24 Jun, 2011

1 commit


07 Jun, 2011

1 commit


20 May, 2011

1 commit


30 Apr, 2011

2 commits

  • This updates the network drivers so that they don't access the
    ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
    instead.

    For most of the drivers, these changes are purely cosmetic and don't
    fix any problem, such as for those 1GbE/10GbE drivers that indirectly
    call their own ethtool get_settings()/mii_ethtool_gset(). The changes
    are meant to enforce code consistency and provide robustness with
    future larger throughputs, at the expense of a few CPU cycles for each
    ethtool operation.

    All drivers compiled with make allyesconfig ion x86_64 have been
    updated.

    Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
    Signed-off-by: David Decotigny
    Signed-off-by: David S. Miller

    David Decotigny
     
  • This makes sure the ethtool's set_settings() callback of network
    drivers don't ignore the 16 most significant bits when ethtool calls
    their set_settings().

    All drivers compiled with make allyesconfig on x86_64 have been
    updated.

    Signed-off-by: David Decotigny
    Signed-off-by: David S. Miller

    David Decotigny
     

27 Apr, 2011

1 commit


22 Apr, 2011

1 commit

  • The mechanism used to initiate work events from the interrupt
    handler has a classic read/modify/write race between the interrupt
    handler that sets the condition, and the worker task that reads and
    clears the condition. Close these races by using atomic
    bit fields.

    Cc: stable@kernel.org
    Cc: Jie Yang
    Signed-off-by: Tim Gardner
    Signed-off-by: David S. Miller

    Tim Gardner
     

17 Apr, 2011

1 commit


08 Apr, 2011

1 commit

  • Things left as they were:
    - atl1: is RX checksum really enabled?
    - atl2: copy-paste from atl1, with-errors-on-modify I presume
    - atl1c: there's a bug: MTU can't be changed if device is not up

    Signed-off-by: Michał Mirosław
    Signed-off-by: David S. Miller

    Michał Mirosław
     

19 Mar, 2011

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (47 commits)
    doc: CONFIG_UNEVICTABLE_LRU doesn't exist anymore
    Update cpuset info & webiste for cgroups
    dcdbas: force SMI to happen when expected
    arch/arm/Kconfig: remove one to many l's in the word.
    asm-generic/user.h: Fix spelling in comment
    drm: fix printk typo 'sracth'
    Remove one to many n's in a word
    Documentation/filesystems/romfs.txt: fixing link to genromfs
    drivers:scsi Change printk typo initate -> initiate
    serial, pch uart: Remove duplicate inclusion of linux/pci.h header
    fs/eventpoll.c: fix spelling
    mm: Fix out-of-date comments which refers non-existent functions
    drm: Fix printk typo 'failled'
    coh901318.c: Change initate to initiate.
    mbox-db5500.c Change initate to initiate.
    edac: correct i82975x error-info reported
    edac: correct i82975x mci initialisation
    edac: correct commented info
    fs: update comments to point correct document
    target: remove duplicate include of target/target_core_device.h from drivers/target/target_core_hba.c
    ...

    Trivial conflict in fs/eventpoll.c (spelling vs addition)

    Linus Torvalds
     

24 Feb, 2011

1 commit

  • The dmaw_block is an enum and max_pay_load is u32. Therefore
    sparse gives warning about comparison of unsigned and signed value.
    Resolve by using min_t to force cast.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     

15 Feb, 2011

1 commit


12 Feb, 2011

1 commit


05 Feb, 2011

1 commit


03 Feb, 2011

1 commit

  • Commit 8f574b35f22fbb9b5e5f1d11ad6b55b6f35f4533 ("atl1c: Add AR8151 v2
    support and change L0s/L1 routine") added support for a new adapter
    but failed to add it to the PCI device table.

    Signed-Off-By: Chuck Ebbert
    Signed-off-by: David S. Miller

    Chuck Ebbert
     

21 Jan, 2011

1 commit


19 Jan, 2011

1 commit


27 Dec, 2010

1 commit


23 Dec, 2010

1 commit

  • The atl1c driver uses the legacy PCI power management, so it has to
    do some PCI-specific things in its ->suspend() and ->resume()
    callbacks and they are not done correctly.

    Convert atl1c to the new PCI power management framework and make it
    let the PCI subsystem handle all of the PCI-specific aspects of
    device handling during system power transitions.

    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: David S. Miller

    Rafael J. Wysocki
     

17 Dec, 2010

1 commit

  • Some drivers are using skb_transport_offset(skb) instead of skb->csum_start
    for NETIF_F_HW_CSUM offload. This does not matter now, but if someone
    implements checksumming of encapsulated packets then this will break silently.

    TSO output paths are left as they are, since they are for IP+TCP only
    (might be worth converting though).

    Signed-off-by: Michał Mirosław
    Signed-off-by: David S. Miller

    Michał Mirosław
     

22 Nov, 2010

1 commit

  • Commit 496c185c9495629ef1c65387cb2594578393cfe0 "atl1c: Add support
    for Atheros AR8152 and AR8152" added the condition:

    if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b)

    for enabling OTP CLK, and the condition:

    if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)

    for disabling OTP CLK. Since the two previously defined hardware
    types are athr_l1c and athr_l2c, the latter condition appears to be
    the correct one. Change the former to match.

    Signed-off-by: Ben Hutchings
    Signed-off-by: David S. Miller

    Ben Hutchings
     

25 Oct, 2010

1 commit


21 Oct, 2010

1 commit

  • Many (but not all) drivers check to see whether there is a vlan
    group configured before using a tag stored in the skb. There's
    not much point in this check since it just throws away data that
    should only be present in the expected circumstances. However,
    it will soon be legal and expected to get a vlan tag when no
    vlan group is configured, so remove this check from all drivers
    to avoid dropping the tags.

    Signed-off-by: Jesse Gross
    Signed-off-by: David S. Miller

    Jesse Gross
     

03 Sep, 2010

1 commit

  • fresh skbs have ip_summed set to CHECKSUM_NONE (0)

    We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.

    Introduce skb_checksum_none_assert() helper so that we keep this
    assertion documented in driver sources.

    Change most occurrences of :

    skb->ip_summed = CHECKSUM_NONE;

    by :

    skb_checksum_none_assert(skb);

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

29 Aug, 2010

1 commit

  • The nic_type field is compared to athr_l2c twice.

    The sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @expression@
    expression E;
    @@

    (
    * E
    || ... || E
    |
    * E
    && ... && E
    )
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

22 Aug, 2010

1 commit


01 Jun, 2010

1 commit

  • Add AR8151 v2.0 Gigabit 1000 support
    Change jumbo frame size to 6K
    Update L0s/L1 rountine
    when link speed is 100M or 1G, set L1 link timer to 4 for l1d_2 and l2c_b2
    set L1 link timer to 7 for l2c_b, set L1 link timer to 0xF for others.
    Update atl1c_suspend routine
    just refactory the function, add atl1c_phy_power_saving routine,
    when Wake On Lan enable, this func will be called to save power,
    it will reautoneg PHY to 10/100M speed depend on the link
    partners link capability.
    Update atl1c_configure_des_ring
    do not use l2c_b default SRAM configuration.

    Signed-off-by: Jie Yang
    Signed-off-by: David S. Miller

    Jie Yang
     

14 May, 2010

1 commit

  • This patch removes from drivers/net/ all the unnecessary
    return; statements that precede the last closing brace of
    void functions.

    It does not remove the returns that are immediately
    preceded by a label as gcc doesn't like that.

    It also does not remove null void functions with return.

    Done via:
    $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
    xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

    with some cleanups by hand.

    Compile tested x86 allmodconfig only.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

12 Apr, 2010

1 commit


04 Apr, 2010

1 commit

  • Converts the list and the core manipulating with it to be the same as uc_list.

    +uses two functions for adding/removing mc address (normal and "global"
    variant) instead of a function parameter.
    +removes dev_mcast.c completely.
    +exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
    manipulation with lists on a sandbox (used in bonding and 80211 drivers)

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

31 Mar, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

23 Feb, 2010

1 commit


17 Feb, 2010

1 commit

  • AR8151 is a Gigabit Ethernet device. AR8152 devices are
    Fast Ethernet devices, there are two revisions, a 1.0
    and a 2.0 revision.

    This has been tested against these devices:

    Driver Model-name vendor:device Type
    atl1c AR8131 1969:1063 Gigabit Ethernet
    atl1c AR8132 1969:1062 Fast Ethernet
    atl1c AR8151(v1.0) 1969:1073 Gigabit Ethernet
    atl1c AR8152(v1.1) 1969:2060 Fast Ethernet

    This device has no hardware available yet so it goes untested,
    but it should work:

    atl1c AR8152(v2.0) 1969:2062 Fast Ethernet

    Signed-off-by: Luis R. Rodriguez
    Signed-off-by: David S. Miller

    Luis R. Rodriguez
     

08 Jan, 2010

1 commit


07 Jan, 2010

1 commit


12 Dec, 2009

1 commit


10 Dec, 2009

1 commit

  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)
    tree-wide: fix misspelling of "definition" in comments
    reiserfs: fix misspelling of "journaled"
    doc: Fix a typo in slub.txt.
    inotify: remove superfluous return code check
    hdlc: spelling fix in find_pvc() comment
    doc: fix regulator docs cut-and-pasteism
    mtd: Fix comment in Kconfig
    doc: Fix IRQ chip docs
    tree-wide: fix assorted typos all over the place
    drivers/ata/libata-sff.c: comment spelling fixes
    fix typos/grammos in Documentation/edac.txt
    sysctl: add missing comments
    fs/debugfs/inode.c: fix comment typos
    sgivwfb: Make use of ARRAY_SIZE.
    sky2: fix sky2_link_down copy/paste comment error
    tree-wide: fix typos "couter" -> "counter"
    tree-wide: fix typos "offest" -> "offset"
    fix kerneldoc for set_irq_msi()
    spidev: fix double "of of" in comment
    comment typo fix: sybsystem -> subsystem
    ...

    Linus Torvalds
     

09 Dec, 2009

1 commit