Eric Lee / smarc-uboot

Download as
Browse Code »

Commit 9c2069ad87a068ba9bfde13a1a4026702edbe11a

Authored by Peng Fan
Committed by Peng Fan
1 parent 91703d0672
Exists in smarc-rel_imx_4.1.15_2.0.0_ga

dfu: avoid memory leak 

When dfu_fill_entity fail, need to free dfu to avoid memory leak.

Reported by Coverity:
"
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable dfu going out of scope leaks the storage
it points to.
"

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: "Łukasz Majewski" <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
(cherry picked from commit 5d8fae79163e94671956c99654abf48cf49757ba)

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

... ... @@ -468,8 +468,10 @@
468 468 s = strsep(&env, ";");
469 469 ret = dfu_fill_entity(&dfu[i], s, alt_num_cnt, interface,
470 470 devstr);
471   - if (ret)
  471 + if (ret) {
  472 + free(dfu);
472 473 return -1;
  474 + }
473 475  
474 476 list_add_tail(&dfu[i].list, &dfu_list);
475 477 alt_num_cnt++;