Eric Lee / smarc-uboot

16 Jan, 2019

1 commit

  • a4773c555   xyz-modem: Fix timeout loop waiting with WATCHDOG ... Browse Code »

    Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting")
    fixes the loop delay when using a hw watchdog, assuming that watchdog
    kicking is taken care of by getc(). But the xyzmodem driver tries to
    do a getc only after confirming that a character is available like below:
    while (!tstc()) {
    till timeout;
    }
    if (tstc())
    *c = getc();

    and getc() does a watchdog reset only if it fails to see a character.
    In this case, getc() always sees a character and never does a
    watchdog reset. So to make sure that watchdog doesn't get reset
    while loading the file, do a watchdog reset just before starting the
    image loading.

    Signed-off-by: Lokesh Vutla
    Signed-off-by: Vignesh R
    Reviewed-by: Simon Glass

    Lokesh Vutla
     

09 Dec, 2018

1 commit

  • a740ee913   lib: merge CRC16-CCITT into u-boot/crc.h ... Browse Code »

    This merges the CRC16-CCITT headers into u-boot/crc.h to prepare for
    rolling CRC16 into the hash infrastructure. Given that CRC8, CRC32
    and CRC32-C already have their prototypes in a single header file, it
    seems a good idea to also include CRC16-CCITT in the same.

    Signed-off-by: Philipp Tomsich

    Philipp Tomsich
     

11 May, 2018

2 commits

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    56

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

08 Apr, 2017

2 commits

29 Nov, 2016

1 commit

  • 2c77c0d65   xyz-modem: Change getc timeout loop waiting ... Browse Code »
    17

    This fixes the loop delay when using a hw watchdog.

    In case a watchdog is used that accesses CPU registers,
    the defined delay of 20us in a tight loop will cause a
    huge delay in the actual timeout seen. This is caused
    by the fact that udelay will inheritantly call WATCHDOG_RESET.
    Together with the omap wdt implementation, the seen timeout increases up to
    around 30s. This makes the loop very slow and causes long
    delays when using the modem.

    Instead, implement the 2 sec loop by using the timer interface to know
    when to break out of the timeout loop. Watchdog kicking is taken care of
    by getc().

    Signed-off-by: Tomas Melin

    tomas.melin@vaisala.com
     

15 Mar, 2016

1 commit

  • ecb57f69b   lib/crc16.c: Rename cyg_crc16() to crc16_ccitt() and add crc start value ... Browse Code »

    The original name of this function is unclear. This patch renames this
    CRC16 function to crc16_ccitt() matching its name with its
    implementation.

    To make the usage of this function more flexible, lets add the CRC start
    value as parameter to this function. This way it can be used by other
    functions requiring different start values than 0 as well.

    Signed-off-by: Stefan Roese
    Reviewed-by: Tom Rini

    Stefan Roese
     

12 Jun, 2014

1 commit

24 Jul, 2013

1 commit

05 Nov, 2012

1 commit

  • 199adb601   common/misc: sparse fixes ... Browse Code »

    command.c:44:38: error: bad constant expression
    dlmalloc.c:1468:2: warning: Using plain integer as NULL pointer
    dlmalloc.c:1468:5: warning: Using plain integer as NULL pointer
    dlmalloc.c:2176:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:2179:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2382:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2436:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2582:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2585:17: warning: Using plain integer as NULL pointer
    dlmalloc.c:2646:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2659:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2692:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2707:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2708:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2786:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2801:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:2801:22: warning: Using plain integer as NULL pointer
    dlmalloc.c:2926:27: warning: Using plain integer as NULL pointer
    dlmalloc.c:2928:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2929:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:3075:14: warning: Using plain integer as NULL pointer
    hush.c:292:14: warning: symbol 'last_return_code' was not declared. Should it be static?
    hush.c:293:5: warning: symbol 'nesting_level' was not declared. Should it be static?
    hush.c:2175:20: warning: Using plain integer as NULL pointer
    hush.c:2175:34: warning: Using plain integer as NULL pointer
    hush.c:2210:41: warning: Using plain integer as NULL pointer
    hush.c:2216:45: warning: Using plain integer as NULL pointer
    hush.c:2249:25: warning: Using plain integer as NULL pointer
    hush.c:2332:13: warning: symbol 'new_pipe' was not declared. Should it be static?
    hush.c:2390:5: warning: symbol 'reserved_word' was not declared. Should it be static?
    hush.c:2927:5: warning: symbol 'parse_stream' was not declared. Should it be static?
    hush.c:3127:6: warning: symbol 'mapset' was not declared. Should it be static?
    hush.c:3133:6: warning: symbol 'update_ifs_map' was not declared. Should it be static?
    hush.c:3161:5: warning: symbol 'parse_stream_outer' was not declared. Should it be static?
    hush.c:3295:34: warning: Using plain integer as NULL pointer
    hush.c:3631:5: warning: symbol 'do_showvar' was not declared. Should it be static
    image.c:1282:29: warning: Using plain integer as NULL pointer
    image.c:1315:41: warning: Using plain integer as NULL pointer
    image.c:1330:25: warning: Using plain integer as NULL pointer
    image.c:1706:25: warning: Using plain integer as NULL pointer
    main.c:510:10: warning: symbol 'hist_num' was not declared. Should it be static?
    main.c:512:5: warning: symbol 'hist_list' was not declared. Should it be static?
    main.c:513:6: warning: symbol 'hist_lines' was not declared. Should it be static?
    usb_storage.c:195:6: warning: symbol 'usb_show_progress' was not declared. Should it be static?
    usb_storage.c:440:48: warning: Using plain integer as NULL pointer
    usb_storage.c:503:5: warning: symbol 'usb_stor_BBB_comdat' was not declared. Should it be static?
    usb_storage.c:551:5: warning: symbol 'usb_stor_CB_comdat' was not declared. Should it be static?
    usb_storage.c:629:55: warning: Using plain integer as NULL pointer
    usb_storage.c:620:5: warning: symbol 'usb_stor_CBI_get_status' was not declared. Should it be static?
    usb_storage.c:675:43: warning: Using plain integer as NULL pointer
    usb_storage.c:668:5: warning: symbol 'usb_stor_BBB_clear_endpt_stall' was not declared. Should it be static?
    usb_storage.c:679:5: warning: symbol 'usb_stor_BBB_transport' was not declared. Should it be static?
    usb_storage.c:801:5: warning: symbol 'usb_stor_CB_transport' was not declared. Sh
    xyzModem.c:104:1: warning: symbol 'CYGACC_COMM_IF_GETC_TIMEOUT' was not declared. Should it be static?
    xyzModem.c:122:1: warning: symbol 'CYGACC_COMM_IF_PUTC' was not declared. Should it be static?
    xyzModem.c:169:1: warning: symbol 'parse_num' was not declared. Should it be stat

    note: hush.c's nesting_level deleted because not used.

    Signed-off-by: Kim Phillips

    Kim Phillips
     

29 Jul, 2011

1 commit

20 Jul, 2009

1 commit

31 Aug, 2006

1 commit

21 Jul, 2006

1 commit

10 May, 2006

1 commit

16 Apr, 2006

1 commit

30 Mar, 2006

1 commit