10 Apr, 2020
2 commits
-
Refactor the printing sequence in dm_dump_drivers to make it more clear.
Signed-off-by: Ovidiu Panait
Cc: Sean Anderson
Cc: Simon Glass
Reviewed-by: Simon Glass -
Currently, dm drivers command produces a segfault:
=> dm drivers
Driver Compatible
--------------------------------
Segmentation fault (core dumped)This is caused by a NULL pointer dereference of entry->of_match.
Add a check to prevent this.Signed-off-by: Ovidiu Panait
Cc: Sean Anderson
Cc: Simon Glass
03 Mar, 2020
1 commit
-
In various cases a power domain must stay enabled after device
removal when booting OS (i.e. serial debug console or display).
Add a flag to selectively skip switching off a power domain.Fixes: 52edfed65de9 ("dm: core: device: switch off power domain after device removal")
Signed-off-by: Anatolij Gustschin
Acked-by: Neil Armstrong
Tested-by: Guillaume La Roque
Reviewed-by: Simon Glass
11 Feb, 2020
1 commit
-
sandbox conversion to SDL2
TPM TEE driver
Various minor sandbox video enhancements
New driver model core utility functions
07 Feb, 2020
2 commits
-
Now that we have uclass_first_device_drvdata(), use it from syscon to
reduce code duplication.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng -
It is sometimes useful to find a device in a uclass using only its driver
data. The driver data often indicates the 'subtype' of the device, e,g,
via its compatible string.Add a function to handle this.
Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
06 Feb, 2020
13 commits
-
At present dm/device.h includes the linux-compatible features. This
requires including linux/compat.h which in turn includes a lot of headers.
One of these is malloc.h which we thus end up including in every file in
U-Boot. Apart from the inefficiency of this, it is problematic for sandbox
which needs to use the system malloc() in some files.Move the compatibility features into a separate header file.
Signed-off-by: Simon Glass
-
At present devres.h is included in all files that include dm.h but few
make use of it. Also this pulls in linux/compat which adds several more
headers. Drop the automatic inclusion and require files to include devres
themselves. This provides a good indication of which files use devres.Signed-off-by: Simon Glass
Reviewed-by: Anatolij Gustschin -
This adds a subcommand to dm to dump out what drivers are installed, and their
compatible strings. I have found this useful in ensuring that I have the correct
drivers compiled, and that I have put in the correct compatible strings.Signed-off-by Sean Anderson
Reviewed-by: Simon Glass -
These conditions are not needed and just reduce build coverage. Drop them.
Signed-off-by: Simon Glass
-
It is sometimes useful to process all children, making sure they are
probed first. Add functions to help with this and a macro to make it more
convenient.Signed-off-by: Simon Glass
-
When generating ACPI tables we need to make sure that all devices have
read their platform data, so that they can generate the tables correctly.Rather than adding this code in ACPI, create a core function to handle it.
Signed-off-by: Simon Glass
-
Add a function to read a property from the chosen node, providing access
to its length. Update ofnode_get_chosen_string() to make use of it.Signed-off-by: Simon Glass
-
Now that we have ofnode_read_prop() we can rewrite this function using
that one, reducing the amount of duplicated code.Update ofnode_read_size() and move it up next to the other similar
functions.Signed-off-by: Simon Glass
-
Add a new function to read a property that supports reading the length as
well.Reimplement ofnode_read_string() using it and fix its comment.
Signed-off-by: Simon Glass
-
This function is actually intended to read a string rather than a
property. All of its current callers use it that way. Also there is no way
to return the length of the property from this function.Rename it to better indicate its purpose, using ofnode_read as the prefix
since this matches most other functions.Also add some tests which are missing for these functions.
Signed-off-by: Simon Glass
-
These functions do not modify the device so should use a const pointer to
it. Update the code accordingly.Signed-off-by: Simon Glass
-
These functions do not modify the device so should use a const pointer to
it. Update the code accordingly.Signed-off-by: Simon Glass
-
Update this header file to use const devices where possible, to permit
callers to also use const.Signed-off-by: Simon Glass
08 Jan, 2020
11 commits
-
This adds a message to lists_bind_fdt when it skips initializing a device
pre-relocation. I've had a couple errors where a device didn't initialize
properly because one of its dependencies was missing.Signed-off-by: Sean Anderson
Reviewed-by: Bin Meng -
Since the ofdata_to_platdata() method can allocate resources, add it as a
new devres phase.Signed-off-by: Simon Glass
-
At present we only support two phases where devres can be used:
bind and probe. This is handled with a boolean. We want to add a new
phase (platdata), so change this to an enum.Signed-off-by: Simon Glass
-
The devres functionality has very few users in U-Boot, but it still should
have tests. Add a few basic tests of the main functions.Signed-off-by: Simon Glass
-
At present when CONFIG_DEBUG_DEVRES is enabled, U-Boot prints log messages
to the console with every devres allocation/free event. This causes most
tests to fail since the console output is not as expected.In particular this prevents us from adding a device to sandbox which uses
devres in its bind method.Move devres over to use U-Boot's logging feature instead, and add a new
category for devres.Signed-off-by: Simon Glass
-
We want to avoid allocating platform data twice. This could happen if
device_probe() is called after device_ofdata_to_platdata() for the same
device.Add a flag to track whether device_ofdata_to_platdata() has been called on
a device. Check the flag to make sure it doesn't happen twice, and clear
the flag when the data is freed.Signed-off-by: Simon Glass
-
Add a new internal function, device_ofdata_to_platdata() to handle
allocating private space associated with each device and reading the
platform data from the device tree.Call this new function from device_probe().
Signed-off-by: Simon Glass
-
At present the parent is probed before the child's ofdata_to_platdata()
method is called. Adjust the logic slightly so that probing parents is
not done until afterwards.Signed-off-by: Simon Glass
-
This method is supposed to extract platform data from the device tree. It
should be done before the device itself is probed. Move it earlier in the
device_probe() function.Signed-off-by: Simon Glass
-
Remove this duplicated code, since the 'fail' label does this immediately.
Signed-off-by: Simon Glass
-
Use this macros instead of the linux ones, as the output is smaller.
Signed-off-by: Simon Glass
15 Dec, 2019
1 commit
-
Early in boot it is necessary to decode the PCI device/function values for
particular peripherals in the device tree or of-platdata. This is needed
in TPL where CONFIG_PCI is not defined.To handle this, move pci_get_devfn() into a file that is built even when
CONFIG_PCI is not defined.Also add a function for use by of-platdata, to convert a reg property to
a pci_dev_t.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
03 Dec, 2019
2 commits
-
Free allocated memory in case of an error in regmap_init_mem() and
regmap_init_mem_index().Signed-off-by: Faiz Abbas
-
These functions are CPU-related and do not use driver model. Move them to
cpu_func.hSigned-off-by: Simon Glass
Reviewed-by: Daniel Schwierzeck
Reviewed-by: Tom Rini
01 Nov, 2019
1 commit
-
- Fix for patman with email addresses containing commas
- Bootstage improvements for TPL, SPL
- Various sandbox and dm improvements and fixes
28 Oct, 2019
3 commits
-
The FDT specification [0] gives a requirement of aligning properties on
32-bits. Make sure that the compiler is aware of this constraint when
accessing 64-bits properties.[0]: https://github.com/devicetree-org/devicetree-specification/blob/master/source/flattened-format.rst
Signed-off-by: Jean-Jacques Hiblot
Reviewed-by: Simon Glass -
Use log() insted of debug() for uclass_find_device_by_seq function,
since this print is very much and we can filter it out with log()
interface.Signed-off-by: Kever Yang
Reviewed-by: Simon Glass
Move #define to top of file as per docs:
Signed-off-by: Simon Glass -
This function assumes that the 'val' parameter has no masked bits set.
This is not defined by the function prototype though. Fix the function to
mask the value and update the documentation.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
Reviewed-by: Jean-Jacques Hiblot
22 Oct, 2019
1 commit
-
This fixes the case where assigned-clocks is used to define a clock
defaults inside this same clock's node. This is used sometimes to setup a
default parents and/or rate for a clock.example:
muxed_clock: muxed_clock {
clocks = , ;
#clock-cells = ;
assigned-clocks = ;
assigned-clock-parents = ;
};It doesn't work in u-boot because the assigned-clocks are setup *before*
the clock is probed. (clk_set_parent() will likely crash or fail if called
before the device probe function)
Making it work by handling "assigned-clocks" in 2 steps: first before the
clk device is probed, and then after the clk device is probed.Signed-off-by: Jean-Jacques Hiblot
15 Oct, 2019
2 commits
-
At present the 'Index' column of 'dm tree' assumes there is
two digits, this patch increase it to 3 digits.It also aligns output of 'dm uclass', assuming the same 3 digits index.
The boards with CONFIG_PINCTRL_FULL activated have one pinconfig
by pin configuration, so they can have more than 100 devices
pinconfig (for example with stm32mp157c-ev1 board we have
106 pinconfig node).Signed-off-by: Patrick Delaunay
Reviewed-by: Simon Glass -
The power domain associated with a device is enabled when probing,
but currently the domain remains enabled when the device is removed.
Some boards started to disable power domains for selected devices
via custom board_quiesce_devices(), but it doesn't work in many
cases, i. e. because devices still can be accessed later in
.remove() callback on behalf of dm_remove_devices_flags().Utilize the DM core to power off the device power domain, but add a
device flag to be able to selectively let the power domain enabled
after device removal. This might be required for devices that must
remain enabled when booting OS, i. e. serial console for debug
output, etc.Signed-off-by: Anatolij Gustschin
Signed-off-by: Lokesh Vutla
Reviewed-by: Simon Glass
