25 Jan, 2019
1 commit
-
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10
interfaces (0..9) as the number can only have one digit.On boards with more than 10 interfaces, this leads to the protection
and format checks being absent for eth10addr and above.Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow
more than one digit.Signed-off-by: Simon Goldschmidt
Acked-by: Joe Hershberger
07 May, 2018
1 commit
-
When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from. So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry. Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents. There's also a few places where I found we did not have a tag
and have introduced one.Signed-off-by: Tom Rini
04 May, 2016
1 commit
-
VLAN identifiers are 12-bit decimal numbers, not IP addresses.
Signed-off-by: Stefan Agner
Reviewed-by: Tom Rini
Acked-by: Joe Hershberger
08 Feb, 2016
1 commit
-
passing argv/argc can produce off-by-one errors
Signed-off-by: Andreas Fenkart
21 Sep, 2015
1 commit
-
The code that checks if a string has the format of a MAC address has been
moved to a separate function called eth_validate_ethaddr_str().This has been done to allow other components (such as vsc9953 driver)
to validate a MAC address.Signed-off-by: Codrin Ciubotariu
Acked-by: Joe Hershberger
Reviewed-by: York Sun
21 May, 2015
2 commits
-
Check that the common network stack's env vars conform to the proper
format for IP addresses.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Use a regular expression to apply the default formatting flags for all
ethaddr env vars.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
24 Jul, 2013
1 commit
-
Signed-off-by: Wolfgang Denk
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini
14 Dec, 2012
5 commits
-
Use the variable access flags to implement the protection for ethaddr
and serial# instead of hard-coding them.Signed-off-by: Joe Hershberger
-
Add support for read-only, write-once, and change-default.
Signed-off-by: Joe Hershberger
-
Similar to the env callback command, this will show details about the
options available, the static list, and the currently active variables.Signed-off-by: Joe Hershberger
-
Currently just validates variable types as decimal, hexidecimal,
boolean, ip address, and mac address. Call
env_acl_validate_setenv_params() from setenv() in fw_env.c.If the entry is not found in the env .flags, then look in the static
one. This allows the env to override the static definitions, but prevents
the need to have every definition in the environment distracting you.Need to build in _ctype for isdigit for Linux.
Signed-off-by: Joe Hershberger
-
Currently just validates variable types as decimal, hexidecimal,
boolean, ip address, and mac address.If the entry is not found in the env ".flags", then look in the static
one. This allows the env to override the static definitions, but prevents
the need to have every definition in the environment distracting you.Signed-off-by: Joe Hershberger