24 May, 2019

1 commit


25 Jan, 2019

1 commit

  • No mainline board enables CONFIG_MCAST_TFTP and there have been
    compilation issues with the code for some time. Additionally, it has a
    potential buffer underrun issue (reported as a side note in
    CVE-2018-18439).

    Remove the multicast TFTP code but keep the driver API for the future
    addition of IPv6.

    Cc: Simon Goldschmidt
    Signed-off-by: Chris Packham
    Acked-by: Joe Hershberger

    Chris Packham
     

21 Aug, 2018

1 commit

  • When a USB ethernet device is halted, the device driver is removed. When
    this happens the uclass private memory is freed and uclass_priv is set to
    NULL. This causes a data abort when uclass_priv->state is then set to
    ETH_STATE_PASSIVE.

    Fix it by checking if uclass_priv is NULL before setting uclass_priv->state

    Signed-off-by: Jean-Jacques Hiblot
    Acked-by: Joe Hershberger

    Jean-Jacques Hiblot
     

27 Jul, 2018

1 commit

  • With driver model, we were not checking if the state of the device was
    marked as active before calling the halt function. Check that the device
    is probed and also marked as active. This avoids the case where we were
    calling halt on the first device in net_init() and the driver would
    operate on bogus data structures causing problems. In this case, the
    priv was all 0, so halt() would close STDIN.

    Signed-off-by: Joe Hershberger
    Reviewed-by: Simon Glass

    Joe Hershberger
     

14 Jun, 2018

1 commit

  • On devices that have their first network interface provided by a FPGA,
    the initialization of further interfaces will fail if the FPGA is not
    yet programmed. This leads to problems during factory setup when the
    data is supposed to be loaded over secondary netowork interfaces.

    To avoid this, use the uclass_{first,next}_device_check functions to
    initialize as many ethernet devices as possible.

    Signed-off-by: Mario Six
    Acked-by: Joe Hershberger

    Mario Six
     

07 May, 2018

1 commit

  • When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

23 Mar, 2018

1 commit

  • In the efi_loader main loop we call eth_rx() occasionally. This rx function
    might end up calling into devices that haven't been initialized yet,
    potentially resulting in a lot of transfer timeouts.

    Instead, let's make sure the ethernet device is actually initialized before
    reading from or writing to it.

    Signed-off-by: Alexander Graf
    Acked-by: Joe Hershberger

    Alexander Graf
     

16 Aug, 2017

3 commits


03 Jun, 2017

1 commit


08 Feb, 2017

2 commits


08 Nov, 2016

1 commit


14 Oct, 2016

1 commit


06 Feb, 2016

1 commit

  • This fixes the following error when building microblaze-generic:

    net/eth-uclass.c: In function 'eth_post_probe':
    net/eth-uclass.c:466:18: error: 'gd' undeclared (first use in this function)
    ops->start += gd->reloc_off;

    Fixes: db9391e1 ("net: Move driver-model code into its own file")

    Signed-off-by: Simon Glass
    Acked-by: Joe Hershberger

    Simon Glass
     

29 Jan, 2016

1 commit