14 Nov, 2018
1 commit
-
Fix coverity issue CID 43665: Free of address-of expression (BAD_FREE)
incorrect_free: free frees incorrect pointer pp.pp points the port array field of struct ahci_uc_priv, should not free it.
Signed-off-by: Ye Li
Acked-by: Peng Fan
13 Nov, 2018
2 commits
-
Fix coverity issue CID 3261683: Wrong operator used (CONSTANT_EXPRESSION_RESULT)
operator_confusion: ({...; __v;}) | 67108864 is always 1/true regardless of the values
of its operand. This occurs as the logical operand of !When DIAG_X is set, the PHY COMINIT signal is detected, so should use '&' to check
whether it is set.Signed-off-by: Ye Li
-
Fix coverity issue CID 3606684: Resource leak (RESOURCE_LEAK)
leaked_storage: Variable uc_priv going out of scope leaks the storage it points toSigned-off-by: Ye Li
27 Apr, 2018
2 commits
-
- some delay is required between SATA_CTRL0 RST SET and CLR.
Otherwise, sata phy link would be down.
- specific the ahci modification by imx8qm platform.Signed-off-by: Richard Zhu
Signed-off-by: Ye Li -
The reset_sata should reset the sata device info and free the probe_ent
memory. Otherwise, it will cause memory leak if we init the sata again.Signed-off-by: Ye Li
09 Feb, 2018
1 commit
-
config_fallbacks.h has some logic that sets HAVE_BLOCK_DEVICE
based on a list of enabled options. Moving HAVE_BLOCK_DEVICE to
Kconfig allows us to drastically shrink the logic in
config_fallbacks.hSigned-off-by: Adam Ford
[trini: Rename HAVE_BLOCK_DEVICE to CONFIG_BLOCK_DEVICE]
Signed-off-by: Tom Rini
13 Dec, 2017
10 commits
-
Signed-off-by: Tuomas Tynkkynen
-
This symbol enables some library code used by various SATA drivers,
so make this a non-user-visible symbol select'ed by the respective
drivers, and let moveconfig handle the rest.Signed-off-by: Tuomas Tynkkynen
-
And use 'imply' liberally.
Signed-off-by: Tuomas Tynkkynen
-
Signed-off-by: Tuomas Tynkkynen
-
Use 'imply' here liberally to avoid the combinatorial explosion of
defconfig changes in the PowerPC boards.Signed-off-by: Tuomas Tynkkynen
-
Signed-off-by: Tuomas Tynkkynen
-
Signed-off-by: Tuomas Tynkkynen
-
Use 'imply' here liberally to avoid the combinatorial explosion of
defconfig changes in the PowerPC boards.Signed-off-by: Tuomas Tynkkynen
-
The last user of this driver went away in August 2015 in commit:
b6073fd2115 ("arm: Remove mx51_efikamx, mx51_efikasb boards")Signed-off-by: Tuomas Tynkkynen
-
The last user of this driver went away in June 2017, in commit:
98f705c9ce ("powerpc: remove 4xx support")Signed-off-by: Tuomas Tynkkynen
28 Nov, 2017
1 commit
-
s/achi_/ahci_/g
Signed-off-by: Michal Simek
Reviewed-by: Simon Glass
03 Nov, 2017
1 commit
-
The patch:
"dm: ahci: Unwind the confusing init code"
(sha1: 7cf1afce7fa3fe64189020fe14b93f7326dd0758)
introduce bug for ceva sata because port didn't start.
On the other hand the dwc_ahci.c was fixed correctly.
Do the same change for ceva too.Signed-off-by: Michal Simek
Tested-by: Mian Yousaf Kaukab
04 Oct, 2017
1 commit
-
U-Boot widely uses error() as a bit noisier variant of printf().
This macro causes name conflict with the following line in
include/linux/compiler-gcc.h:# define __compiletime_error(message) __attribute__((error(message)))
This prevents us from using __compiletime_error(), and makes it
difficult to fully sync BUILD_BUG macros with Linux. (Notice
Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)Let's convert error() into now treewide-available pr_err().
Done with the help of Coccinelle, excluing tools/ directory.
The semantic patch I used is as follows:
//
@@@@
-error
+pr_err
(...)
//Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
[trini: Re-run Coccinelle]
Signed-off-by: Tom Rini
13 Sep, 2017
1 commit
-
Import include/linux/dma-direction.h from Linux 4.13-rc7 and delete
duplicated definitions of enum dma_data_direction.Signed-off-by: Masahiro Yamada
Reviewed-by: Andy Shevchenko
17 Aug, 2017
14 commits
-
Update this driver to support driver model. This involves implementing the
AHCI operations and reusing existing common code.Signed-off-by: Simon Glass
-
At present the AHCI uclass is just a shell and we still use the global
functions to access SATA. Fix this by adding operations to the uclass.Signed-off-by: Simon Glass
-
Driver model wants to use the core functions in this file but accesses the
uclass-private data in a different way. Move the code into new 'common'
functions and set up stubs to call these.Signed-off-by: Simon Glass
-
This function will not be used with driver model and it relates to the
other exported functions. Move it down next to them.Signed-off-by: Simon Glass
-
This variable is set but never used. Drop it.
Signed-off-by: Simon Glass
-
Rename dwc_ahsata.h to indicate that it is a private header file. We plan
to create another header with some public functions.Signed-off-by: Simon Glass
-
Sort the header file inclusions into the correct order.
Signed-off-by: Simon Glass
-
There is a strange &(var) coding style in this driver. Adjust it to use
&var instead, which is more usual.Signed-off-by: Simon Glass
-
With driver model sata_dev_desc[] does not exist. We still want to use the
common code of this driver so update it to pass struct ahci_uc_priv * to
each of these functions, instead of an integer which must be looked up in
sata_dev_desc[].Signed-off-by: Simon Glass
-
Most of the casts in this driver are not necessary. With driver model we
do not cast from void *. Update the driver to follow this rule.Signed-off-by: Simon Glass
-
With driver model this becomes uclass-private data. Rename the parameter
varable to reflect this.With the driver model conversion we will not have any exported functions.
Move all exported functions to be together at the end of the file so that
we can deal with them in one #ifdef block.Signed-off-by: Simon Glass
-
With the driver model conversion we will not have any exported functions.
Move all exported functions to be together at the end of the file so that
we can deal with them in one #ifdef block.Signed-off-by: Simon Glass
-
This function is not called from anywhere. Drop it.
Signed-off-by: Simon Glass
-
Some functions are not called from outside this file. Make these static
to make that obvious.Signed-off-by: Simon Glass
04 Aug, 2017
1 commit
-
ahci_probe_scsi() now takes a 'base' argument, and there is an API
that prepares base address for us: ahci_probe_scsi_pci().Reported-by: Tom Rini
Reviewed-by: Simon Glass
Signed-off-by: Bin Meng
02 Aug, 2017
1 commit
01 Aug, 2017
4 commits
-
This adds support for PCI-based AHCI controller based on DM SCSI.
Signed-off-by: Bin Meng
Reviewed-by: Simon Glass
Tested-by: Simon Glass -
This is expected to be attached to the uclass and the code operates that
way, but the uclass has not been updated. Fix it to avoid using memory at
address 0.Signed-off-by: Simon Glass
Fixes: 47fc61a (dm: ahci: Drop use of probe_ent) -
When the SATA code was moved into drivers/ata these Kconfig options were
added to that directory. They already exist in drivers/scsi. Remove them
from drivers/ata to fix the duplication.Signed-off-by: Simon Glass
Fixes: 7f2b5f4 (sata: Move drivers into new drivers/ata directory) -
At present the AHCI SCSI driver only supports PCI with driver model.
Rename the existing function to indicate this and add support for adding
a non-PCI controller .Signed-off-by: Simon Glass