01 Feb, 2018

5 commits

  • There is more common code in mmc, nand and ubi env drivers that
    can be shared by moving to env_import_redund.

    For this, a status/error value whether the buffers were loaded
    are passed as additional parameters to env_import_redund.
    Ideally, these are already returned to the env driver by the
    storage driver. This is the case for mmc, nand and ubi, so for
    this change, code deduplicated.

    Signed-off-by: Simon Goldschmidt
    Acked-by: Maxime Ripard

    Simon Goldschmidt
     
  • env_import (and env_import_redund) currently return 1 on success
    and 0 on error. However, they are only used from functions
    returning 0 on success or a negative value on error.

    Let's clean this up by making env_import and env_import_redund
    return 0 on success and -EIO on error (as was the case for all
    users before).

    Users that cared for the return value are also updated. Funny
    enough, this only affects onenand.c and sf.c

    Signed-off-by: Simon Goldschmidt
    Acked-by: Maxime Ripard

    Simon Goldschmidt
     
  • env_get_f calls env_get_char to load single characters from the
    environment. However, the return value of env_get_char was not
    checked for errors. Now if the env driver does not support the
    .get_char call, env_get_f did not notice this and looped over the
    whole size of the environment, calling env_get_char over 8000
    times with the default settings, just to return an error in the
    end.

    Fix this by checking if env_get_char returns < 0.

    Signed-off-by: Simon Goldschmidt
    Acked-by: Maxime Ripard

    Simon Goldschmidt
     
  • Tom Rini
     
  • The omapl138_lcdk platform is not a DA850 SoC so we need to select
    SOC_DA8XX and not SOC_DA850, as it was before. It does however point
    out a bit of a misnomer in how all of these PLL defines are named as
    they are generic to DA8xx, not DA850 centric. Remove the 'if SOC_DA850'
    under the defaults as these are simply the defaults. As SOC_DA8XX will
    select SYS_DA850_DDR_INIT when needed, we do not need it under both SOC
    options.

    Fixes: 76e22222d3aa ("Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig")
    Signed-off-by: Tom Rini

    Tom Rini
     

31 Jan, 2018

14 commits


30 Jan, 2018

21 commits