Eric Lee / smarc-uboot

24 Jul, 2013

1 commit

01 Mar, 2013

1 commit

19 Jan, 2011

1 commit

  • 141053d60   cmd_jffs2: Fix get_part_sector_size_nor() overflow bug ... Browse Code »

    When a flash partition was positioned at the very top of a 32-bit memory
    map (eg located at 0xf8000000 with a size of 0x8000000)
    get_part_sector_size_nor() would incorrectly calculate the partition's
    ending address to 0x0 due to overflow. When the overflow occurred
    get_part_sector_size_nor() would falsely return a sector size of 0.
    A sector size of 0 results in subsequent jffs2 operations failing.

    To workaround the overflow subtract 1 from calculated address of
    the partition endpoint.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

26 Jan, 2010

1 commit

  • 2903ad33a   jffs2: fix hangs/crashs when not using CONFIG_JFFS2_PART_SIZE ... Browse Code »

    Commit b5b004ad8a0ac6f98bd5708ec8b22fbddd1c1042 caused the sector_size to
    be calculated incorrectly when the part size was not hardcoded. This is
    because the new code relied on part->size but tried to do the calculation
    before it was initialized properly, and it did not take into consideration
    the magic SIZE_REMAINING define.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

17 Jul, 2009

1 commit

  • be33b046b   Remove legacy NAND and disk on chip code. ... Browse Code »
    43

    Legacy NAND had been scheduled for removal. Any boards that use this
    were already not building in the previous release due to an #error.

    The disk on chip code in common/cmd_doc.c relies on legacy NAND,
    and it has also been removed. There is newer disk on chip code
    in drivers/mtd/nand; someone with access to hardware and sufficient
    time and motivation can try to get that working, but for now disk
    on chip is not supported.

    Signed-off-by: Scott Wood

    Scott Wood
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

29 May, 2009

1 commit

  • 76b5883da   jffs2/mtdparts: Fix problem with usage from JFFS2 and MTDPARTS together ... Browse Code »

    Currently using JFFS2 with MTDPARTS enabled doesn't work. This is because
    mtdparts_init() is available in both files, cmd_mtdparts.c and
    cmd_jffs2.c. Please note that in the original cmd_jffs2.c file (before
    the jffs2/mtdparts command/file split those 2 different versions
    already existed. So this is nothing new. The main problem is that the
    variables "current_dev" and "current_partnum" are declared in both
    files now. This doesn't work.

    This patch now changes the names of those variable to more specific
    names: "current_mtd_dev" and "current_mtd_partnum". This is because
    this patch also changes the declaration from static to global, so
    that they can be used from both files.

    Please note that my first tests were not successful. The MTD devices
    selected via mtdparts are now accessed but I'm failing to see the
    directory listed via the "ls" command. Nothing is displayed. Perhaps
    I didn't generate the JFFS2 image correctly (I never used JFFS2 in
    U-Boot before). Not sure. Perhaps somebody else could take a look at
    this as well. I'll continue looking into this on Monday.

    Signed-off-by: Stefan Roese
    Cc: Wolfgang Denk
    Cc: Detlev Zundel
    Cc: Ilya Yanok
    Cc: Renaud barbier

    Stefan Roese
     

21 Mar, 2009

1 commit

  • 68d7d6510   Separate mtdparts command from jffs2 ... Browse Code »
    12

    Currently the mtdparts commands are included in the jffs2 command support.
    This doesn't make sense anymore since other commands (e.g. UBI) use this
    infrastructure as well now. This patch separates the mtdparts commands from
    the jffs2 commands making it possible to only select mtdparts when no JFFS2
    support is needed.

    Signed-off-by: Stefan Roese
    Signed-off-by: Kyungmin Park

    Stefan Roese
     

28 Jan, 2009

3 commits

10 Dec, 2008

1 commit

09 Dec, 2008

1 commit

19 Oct, 2008

1 commit

07 Sep, 2008

1 commit

13 Aug, 2008

1 commit

11 Jul, 2008

1 commit

09 Jan, 2008

1 commit

21 Nov, 2007

1 commit

15 Sep, 2007

1 commit

08 Aug, 2007

1 commit

07 Aug, 2007

1 commit

14 Jul, 2007

1 commit

11 Jul, 2007

1 commit

09 Jul, 2007

1 commit

04 Jul, 2007

1 commit

28 Oct, 2006

1 commit

13 Sep, 2006

1 commit

06 Mar, 2006

1 commit

24 Feb, 2006

1 commit

12 Oct, 2005

1 commit

15 Sep, 2005

1 commit

11 Sep, 2005

1 commit

16 Aug, 2005

1 commit

10 Aug, 2005

2 commits

08 Aug, 2005

1 commit

10 Jun, 2005

1 commit

09 Sep, 2004

1 commit

  • eedcd078f   * Patch by Detlev Zundel, 08 Sep 2004: ... Browse Code »

    Update etags build target

    * Improve NetConsole support: add support for broadcast destination
    address and buffered input.

    * Cleanup compiler warnings for GCC 3.3.x and later

    * Fix problem in cmd_jffs2.c introduced by CFG_JFFS_SINGLE_PART patch

    wdenk