08 Aug, 2017
1 commit
-
PXE boot is broken with GCC 7.1 due option '-fstore-merging' enabled
by default for '-O2':BOOTP broadcast 1
data abort
pc : [] lr : []
reloc pc : [] lr : []
sp : 8f558bc0 ip : 00000000 fp : 8ffef5a4
r10: 8ffed248 r9 : 8f558ee0 r8 : 8ffef594
r7 : 0000000e r6 : 8ffed700 r5 : 00000000 r4 : 8ffed74e
r3 : 00060101 r2 : 8ffed230 r1 : 8ffed706 r0 : 00000ddd
Flags: nzcv IRQs off FIQs off Mode SVC_32
Resetting CPU ...Core reason is usage of structures for network headers without packed
attribute.Reviewed-by: Yauheni Kaliuta
Signed-off-by: Denis Pynkin
Acked-by: Joe Hershberger
19 Apr, 2015
5 commits
-
Convert uchar/ushort to u8/u16 respectively.
Signed-off-by: Radha Mohan Chintakuntla
Signed-off-by: Sergey Temerkhanov
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This commit fixes incorrect DHCP/BOOTP packet layout caused by
'ulong' type size difference on 64 and 32-bit architectures.
It also renames NetReadLong()/NetCopyLong() to
net_read_u32/net_copy_u32() accordingly.Signed-off-by: Radha Mohan Chintakuntla
Signed-off-by: Sergey Temerkhanov
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within bootp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
The variables around the bootfile were inconsistent and used CamelCase.
Update them to make the code more readable.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
09 Aug, 2014
1 commit
-
Currently, the BOOTP code sends out its initial request as soon as the
Ethernet driver indicates "link up". If this packet is lost or not
replied to for some reason, the code waits for a 1s timeout before
retrying. For some reason, such early packets are often lost on my
system, so this causes an annoying delay.To optimize this, modify the BOOTP code to have very short timeouts for
the first packet transmitted, but gradually increase the timeout each
time a timeout occurs. This way, if the first packet is lost, the second
packet is transmitted quite quickly and hence the overall delay is low.
However, if there's still no response, we don't keep spewing out packets
at an insane speed.It's arguably more correct to try and find out why the first packet is
lost. However, it seems to disappear inside my Ethenet chip; the TX chip
indicates no error during TX (not that it has much in the way of
reporting...), yet wireshark on the RX side doesn't see any packet.
FWIW, I'm using an ASIX USB Ethernet adapter. Perhaps "link up" is
reported too early or based on the wrong condition in HW, and we should
add some fixed extra delay into the driver. However, this would slow down
every link up event even if it ends up not being needed in some cases.
Having BOOTP retry quickly applies the fix/WAR to every possible
Ethernet device, and is quite simple to implement, so seems a better
solution.Signed-off-by: Stephen Warren
Acked-by: Joe Hershberger
24 May, 2012
3 commits
-
Clearer constant name.
Also remove related BOOTP_SIZE which was unused and doesn't take
into account VLAN packets.Signed-off-by: Joe Hershberger
-
Rename IP header related things to IP_UDP. The existing definition
of IP_t includes UDP header, so name it to accurately describe the
structure.Signed-off-by: Joe Hershberger
-
Make the MAC-seeded random number generator available to /net in
general. MAC-seeded rand will be needed by link-local as well, so
give it an interface.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
16 May, 2012
1 commit
-
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
19 Oct, 2008
1 commit
-
Enforce millisecond semantics of the first argument to NetSetTimeout() --
the change is transparent for well-behaving boards (CFG_HZ == 1000 and
get_timer() countiing in milliseconds).Rationale for this patch is to enable millisecond granularity for
network-related timeouts, which is needed for the upcoming automatic
software update feature.Summary of changes:
- do not scale the first argument to NetSetTimeout() by CFG_HZ
- change timeout values used in the networking code to millisecondsSigned-off-by: Rafal Czubak
Signed-off-by: Bartlomiej Sieka
Signed-off-by: Ben Warren
27 Aug, 2008
1 commit
-
The option CONFIG_BOOTP_RANDOM_DELAY does not compile, because of a
missing extern inside the net/bootp.h headerSigned-off-by: Remy Bohmer
Signed-off-by: Ben Warren
18 Nov, 2007
1 commit
10 Jul, 2007
1 commit
-
Signed-off-by: Jon Loeliger
04 Jul, 2007
1 commit
-
This is a compatibility step that allows both the older form
and the new form to co-exist for a while until the older can
be removed entirely.All transformations are of the form:
Before:
#if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT)
After:
#if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) || defined(CONFIG_CMD_AUTOSCRIPT)Signed-off-by: Jon Loeliger
21 Jul, 2002
1 commit
