10 Nov, 2012

3 commits


09 Nov, 2012

1 commit


08 Nov, 2012

6 commits

  • commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse
    fixes" broke the help command trying to fix the sparse error
    "command.c:44:38: error: bad constant expression".

    As Henrik points out, the fix was bad because the commit used
    CONFIG_SYS_MAXARGS whereas the code intended to use the maximum
    number of commands (not arguments to a command).

    Revert command.c changes to the original code as asked by Wolfgang.

    Reported-by: Henrik Nordström
    Signed-off-by: Anatolij Gustschin

    Anatolij Gustschin
     
  • Microblaze platform can use CONFIG_OF_EMBED option
    but also it is necessary to support boards
    which don't want to use this option.
    U-Boot doesn't compile dts/libdts.o for #undef CONFIG_OF_EMBED
    case that's why it should be guarded by ifdef.

    Signed-off-by: Michal Simek

    Michal Simek
     
  • The patch
    "include/linux/byteorder: import latest endian definitions from linux"
    (sha1: eef1cf2d5cf1cae5fb76713e912263dedf110aeb)

    Introduced a lot of compilation failures with unknow types.
    include/linux/byteorder/big_endian.h:45:1: error: unknown type name '__le64'
    include/linux/byteorder/big_endian.h: In function '__cpu_to_le64p':
    include/linux/byteorder/big_endian.h:47:18: error: '__le64' undeclared (first use in this function)
    include/linux/byteorder/big_endian.h:47:18: note: each undeclared identifier is reported only once for each function it appears in
    include/linux/byteorder/big_endian.h:47:25: error: expected ';' before '__swab64p'
    include/linux/byteorder/big_endian.h: At top level:
    include/linux/byteorder/big_endian.h:49:1: error: unknown type name '__le64'
    include/linux/byteorder/big_endian.h:53:1: error: unknown type name '__le32'
    include/linux/byteorder/big_endian.h: In function '__cpu_to_le32p':
    include/linux/byteorder/big_endian.h:55:18: error: '__le32' undeclared (first use in this function)
    include/linux/byteorder/big_endian.h:55:25: error: expected ';' before '__swab32p'
    include/linux/byteorder/big_endian.h: At top level:
    include/linux/byteorder/big_endian.h:57:1: error: unknown type name '__le32'
    include/linux/byteorder/big_endian.h:61:1: error: unknown type name '__le16'
    ...

    Removing asm/bitops.h solved this problem.

    Signed-off-by: Michal Simek

    Michal Simek
     
  • Flushing caches is necessary because of soft reset
    which doesn't clear caches.

    Signed-off-by: Michal Simek
    Reviewed-by: Marek Vasut

    Michal Simek
     
  • Just remove ancient code.

    Signed-off-by: Michal Simek
    Acked-by: Stephan Linz
    Reviewed-by: Marek Vasut

    Michal Simek
     
  • ext2_find_next_zero_bit must be also static if __swab32 is also static.

    Warning:
    include/asm/bitops.h:369:22: warning: '__fswab32' is static but
    used in inline function 'ext2_find_next_zero_bit'
    which is not static [enabled by default]

    Signed-off-by: Michal Simek
    Acked-by: Stephan Linz

    Michal Simek
     

06 Nov, 2012

1 commit


05 Nov, 2012

29 commits

  • Tom Rini
     
  • When using SUBLEVEL for the -rc? tag, this results in an ugly version
    string like "2013.01.-rc1" - let's use EXTRAVERSION instead to get the
    simple "2013.01-rc1"

    Signed-off-by: Wolfgang Denk
    Signed-off-by: Tom Rini

    Wolfgang Denk
     
  • Signed-off-by: Tom Rini

    Tom Rini
     
  • The BRANCH= tag can be used to indicate the destination branch for a
    commit. Ignore this tag.

    Also ignore the gerrit 'Commit-Ready:' tag.

    Signed-off-by: Simon Glass

    Simon Glass
     
  • The gadget ethernet driver needs to keep copies of the MAC address (at
    both endpoints) as strings so it needs a custom function for validation
    of the MAC. It was not however performing a totally correct check and
    also was emitting a warning about a set but unused variable. The
    solution to both is that after checking the string contents we use the
    standard test for a valid MAC.

    Cc: Joe Hershberger
    Cc: Marek Vasut
    Signed-off-by: Tom Rini
    Acked-by: Joe Hershberger

    Tom Rini
     
  • Signed-off-by: Kim Phillips

    Kim Phillips
     
  • nand_ecc.c:82:5: warning: symbol 'nand_calculate_ecc' was not declared. Should it be static?
    nand_ecc.c:155:5: warning: symbol 'nand_correct_data' was not declared. Should it be static?
    nand_base.c:2854:1: error: directive in argument list
    nand_base.c:2856:1: error: directive in argument list

    Signed-off-by: Kim Phillips
    Acked-by: Scott Wood

    Kim Phillips
     
  • cfi_flash.c:756:43: warning: Using plain integer as NULL pointer
    cfi_flash.c:1150:52: warning: cast to non-scalar
    cfi_flash.c:1433:46: warning: cast truncates bits from constant value (890089 becomes 89)
    cfi_flash.c:1490:61: warning: cast truncates bits from constant value (1f001f becomes 1f)
    cfi_flash.c:1508:61: warning: cast truncates bits from constant value (10001 becomes 1)
    cfi_flash.c:1738:63: warning: cast truncates bits from constant value (10001 becomes 1)
    cfi_flash.c:1857:6: warning: symbol '__flash_cmd_reset' was not declared. Should it be static?

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • fsl_esdhc.c:71:6: warning: symbol 'esdhc_xfertyp' was not declared. Should it be static?
    fsl_esdhc.c:413:6: warning: symbol 'set_sysctl' was not declared. Should it be st

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • mmc.c:137:5: warning: symbol 'mmc_send_cmd' was not declared. Should it be static?
    mmc.c:203:5: warning: symbol 'mmc_send_status' was not declared. Should it be static?
    mmc.c:247:5: warning: symbol 'mmc_set_blocklen' was not declared. Should it be static?
    mmc.c:440:5: warning: symbol 'mmc_read_blocks' was not declared. Should it be static?
    mmc.c:510:5: warning: symbol 'mmc_go_idle' was not declared. Should it be static?
    mmc.c:532:1: warning: symbol 'sd_send_op_cond' was not declared. Should it be static?
    mmc.c:597:5: warning: symbol 'mmc_send_op_cond' was not declared. Should it be static?
    mmc.c:661:5: warning: symbol 'mmc_send_ext_csd' was not declared. Should it be static?
    mmc.c:683:5: warning: symbol 'mmc_switch' was not declared. Should it be static?
    mmc.c:705:5: warning: symbol 'mmc_change_freq' was not declared. Should it be static?
    mmc.c:775:5: warning: symbol 'sd_switch' was not declared. Should it be static?
    mmc.c:796:5: warning: symbol 'sd_change_freq' was not declared. Should it be static?
    mmc.c:935:6: warning: symbol 'mmc_set_ios' was not declared. Should it be static?
    mmc.c:953:6: warning: symbol 'mmc_set_bus_width' was not declared. Should it be static?
    mmc.c:1108:26: warning: dubious: !x & y
    mmc.c:960:5: warning: symbol 'mmc_startup' was not declared. Should it be static?
    mmc.c:1243:5: warning: symbol 'mmc_send_if_cond' was not declared. Should it be s

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • input.c:97:5: warning: symbol 'input_queue_ascii' was not declared. Should it be

    Signed-off-by: Kim Phillips
    Acked-by: Simon Glass

    Kim Phillips
     
  • mpc83xx_gpio.c:166:26: warning: non-ANSI function declaration of function 'mpc83xx_gpio_init_f'
    mpc83xx_gpio.c:190:26: warning: non-ANSI function declaration of function 'mpc83xx_gpio_init_r'

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • sata_sil.c:371:7: warning: symbol 'sil_sata_rw_lba28' was not declared. Should it be static?
    sata_sil.c:399:7: warning: symbol 'sil_sata_rw_lba48' was not declared. Should it be static?
    sata_sil.c:429:6: warning: symbol 'sil_sata_cmd_flush_cache' was not declared. Should it be static?
    sata_sil.c:441:6: warning: symbol 'sil_sata_cmd_flush_cache_ext' was not declared. Should it be static?
    sata_sil.c:489:7: warning: symbol 'sata_read' was not declared. Should it be static?
    sata_sil.c:505:7: warning: symbol 'sata_write' was not declared. Should it be static?
    sata_sil.c:526:5: warning: symbol 'init_sata' was not declared. Should it be static?
    sata_sil.c:588:5: warning: symbol 'scan_sata' was not declared. Should it be static?
    fsl_sata.c:59:6: warning: symbol 'dprint_buffer' was not declared. Should it be static?
    fsl_sata.c:187:42: warning: incorrect type in assignment (different base types)
    fsl_sata.c:187:42: expected unsigned int [unsigned] [usertype] cda
    fsl_sata.c:187:42: got restricted __le32 [usertype]
    fsl_sata.c:291:6: warning: symbol 'fsl_sata_hardware_reset' was not declared. Should it be static?
    fsl_sata.c:418:27: warning: incorrect type in assignment (different base types)
    fsl_sata.c:418:27: expected unsigned int [unsigned] [usertype] dba
    fsl_sata.c:418:27: got restricted __le32 [usertype]
    fsl_sata.c:424:41: warning: incorrect type in assignment (different base types)
    fsl_sata.c:424:41: expected unsigned int [unsigned] [usertype] ext_c_ddc
    fsl_sata.c:424:41: got restricted __le32 [usertype]
    fsl_sata.c:431:41: warning: incorrect type in assignment (different base types)
    fsl_sata.c:431:41: expected unsigned int [unsigned] [usertype] ext_c_ddc
    fsl_sata.c:431:41: got restricted __le32 [usertype]
    fsl_sata.c:442:22: warning: incorrect type in assignment (different base types)
    fsl_sata.c:442:22: expected unsigned int [unsigned] [usertype] cda
    fsl_sata.c:442:22: got restricted __le32 [usertype]
    fsl_sata.c:446:31: warning: incorrect type in assignment (different base types)
    fsl_sata.c:446:31: expected unsigned int [unsigned] [usertype] prde_fis_len
    fsl_sata.c:446:31: got restricted __le32 [usertype]
    fsl_sata.c:448:22: warning: incorrect type in assignment (different base types)
    fsl_sata.c:448:22: expected unsigned int [unsigned] [usertype] ttl
    fsl_sata.c:448:22: got restricted __le32 [usertype]
    fsl_sata.c:460:28: warning: incorrect type in assignment (different base types)
    fsl_sata.c:460:28: expected unsigned int [unsigned] [usertype] attribute
    fsl_sata.c:460:28: got restricted __le32 [usertype]
    fsl_sata.c:623:6: warning: symbol 'fsl_sata_flush_cache' was not declared. Should it be static?
    fsl_sata.c:667:5: warning: symbol 'fsl_sata_rw_ncq_cmd' was not declared. Should it be static?
    fsl_sata.c:710:6: warning: symbol 'fsl_sata_flush_cache_ext' was not declared. Should it be static?
    fsl_sata.c:725:6: warning: symbol 'fsl_sata_software_reset' was not declared. Should it be static?
    fsl_sata.c:760:5: warning: symbol 'ata_low_level_rw_lba48' was not declared. Should it be static?
    fsl_sata.c:795:5: warning: symbol 'ata_low_level_rw_lba28' was not declared. Should it be static?

    the following compiler warnings show up after fixing the above, so
    remove those three functions:

    fsl_sata.c:59:13: warning: 'dprint_buffer' defined but not used [-Wunused-function]
    fsl_sata.c:291:13: warning: 'fsl_sata_hardware_reset' defined but not used [-Wunused-function]
    fsl_sata.c:726:13: warning: 'fsl_sata_software_reset' defined but not used [-Wunused-function]

    Other than that, the following are fixed by __iomem annotation:

    fsl_sata.c:84:39: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:84:39: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:84:39: got unsigned int volatile *addr
    fsl_sata.c:172:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:172:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:172:26: got unsigned int *
    fsl_sata.c:175:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:175:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:175:19: got unsigned int *
    fsl_sata.c:181:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:181:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:181:19: got unsigned int *
    fsl_sata.c:184:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:184:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:184:26: got unsigned int *
    fsl_sata.c:186:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:186:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:186:19: got unsigned int *
    fsl_sata.c:189:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:189:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:189:26: got unsigned int *
    fsl_sata.c:191:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:191:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:191:19: got unsigned int *
    fsl_sata.c:194:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:194:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:194:26: got unsigned int *
    fsl_sata.c:195:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:195:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:195:19: got unsigned int *
    fsl_sata.c:198:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:198:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:198:19: got unsigned int *
    fsl_sata.c:201:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:201:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:201:19: got unsigned int *
    fsl_sata.c:204:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:204:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:204:26: got unsigned int *
    fsl_sata.c:205:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:205:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:205:19: got unsigned int *
    fsl_sata.c:208:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:208:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:208:26: got unsigned int *
    fsl_sata.c:209:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:209:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:209:19: got unsigned int *
    fsl_sata.c:212:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:212:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:212:26: got unsigned int *
    fsl_sata.c:213:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:213:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:213:19: got unsigned int *
    fsl_sata.c:216:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:216:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:216:19: got unsigned int *
    fsl_sata.c:219:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:219:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:219:19: got unsigned int *
    fsl_sata.c:222:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:222:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:222:19: got unsigned int *
    fsl_sata.c:225:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:225:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:225:26: got unsigned int *
    fsl_sata.c:227:19: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:227:19: expected unsigned int volatile [noderef] *addr
    fsl_sata.c:227:19: got unsigned int *
    fsl_sata.c:242:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:242:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:242:26: got unsigned int *
    fsl_sata.c:256:32: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:256:32: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:256:32: got unsigned int *
    fsl_sata.c:262:26: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:262:26: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:262:26: got unsigned int *
    fsl_sata.c:274:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:274:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:274:53: got unsigned int *
    fsl_sata.c:275:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:275:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:275:53: got unsigned int *
    fsl_sata.c:276:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:276:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:276:53: got unsigned int *
    fsl_sata.c:277:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:277:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:277:53: got unsigned int *
    fsl_sata.c:278:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:278:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:278:53: got unsigned int *
    fsl_sata.c:279:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:279:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:279:53: got unsigned int *
    fsl_sata.c:280:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:280:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:280:53: got unsigned int *
    fsl_sata.c:281:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:281:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:281:53: got unsigned int *
    fsl_sata.c:282:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:282:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:282:53: got unsigned int *
    fsl_sata.c:283:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:283:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:283:53: got unsigned int *
    fsl_sata.c:284:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:284:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:284:53: got unsigned int *
    fsl_sata.c:285:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:285:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:285:53: got unsigned int *
    fsl_sata.c:286:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:286:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:286:53: got unsigned int *
    fsl_sata.c:287:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:287:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:287:53: got unsigned int *
    fsl_sata.c:288:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:288:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:288:53: got unsigned int *
    fsl_sata.c:289:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:289:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:289:53: got unsigned int *
    fsl_sata.c:290:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:290:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:290:53: got unsigned int *
    fsl_sata.c:291:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:291:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:291:53: got unsigned int *
    fsl_sata.c:292:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:292:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:292:53: got unsigned int *
    fsl_sata.c:293:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:293:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:293:53: got unsigned int *
    fsl_sata.c:294:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:294:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:294:53: got unsigned int *
    fsl_sata.c:295:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:295:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:295:53: got unsigned int *
    fsl_sata.c:296:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:296:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:296:53: got unsigned int *
    fsl_sata.c:297:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:297:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:297:53: got unsigned int *
    fsl_sata.c:298:53: warning: incorrect type in argument 1 (different address spaces)
    fsl_sata.c:298:53: expected unsigned int const volatile [noderef] *addr
    fsl_sata.c:298:53: got unsigned int *

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • fdt.c:91:78: warning: Using plain integer as NULL pointer
    fdt.c:103:78: warning: Using plain integer as NULL pointer
    speed.c:55:11: warning: symbol 'corecnf_tab' was not declared. Should it be static?
    speed.c:519:5: warning: symbol 'do_clocks' was not declared. Should it be static?
    mpc8313erdb.c:73:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:74:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:75:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:76:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:79:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:80:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:81:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:82:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:85:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:86:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:87:17: warning: obsolete struct initializer, use C99 syntax
    mpc8313erdb.c:88:17: warning: obsolete struct initializer, use C99 syntax

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • fsl_corenet_serdes.c:485:6: warning: symbol '__soc_serdes_init' was not declared. Should it be static?
    cpu_init.c:185:6: warning: symbol 'invalidate_cpc' was not declared. Should it be static?
    bcsr.c:28:27: warning: non-ANSI function declaration of function 'enable_8568mds_duart'
    bcsr.c:39:33: warning: non-ANSI function declaration of function 'enable_8568mds_flash_write'
    bcsr.c:46:34: warning: non-ANSI function declaration of function 'disable_8568mds_flash_write'
    bcsr.c:53:29: warning: non-ANSI function declaration of function 'enable_8568mds_qe_mdio'
    bcsr.c:28:33: warning: non-ANSI function declaration of function 'enable_8569mds_flash_write'
    bcsr.c:33:34: warning: non-ANSI function declaration of function 'disable_8569mds_flash_write'
    bcsr.c:38:28: warning: non-ANSI function declaration of function 'enable_8569mds_qe_uec'
    bcsr.c:63:47: warning: non-ANSI function declaration of function 'disable_8569mds_brd_eeprom_write_protect'
    ngpixis.c:245:1: error: directive in argument list
    ngpixis.c:247:1: error: directive in argument list

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • ctrl_regs.c:31:5: warning: symbol 'fsl_ddr_get_version' was not declared. Should it be static?
    cpu.c:135:14: warning: non-ANSI function declaration of function 'cpu_mask'
    cpu.c:154:18: warning: non-ANSI function declaration of function 'cpu_numcores'
    cpu.c:37:17: warning: symbol 'cpu_type_list' was not declared. Should it be static?
    cpu.c:117:17: warning: symbol 'cpu_type_unknown' was not declared. Should it be static?
    fsl_lbc.c:14:6: warning: symbol '__lbc_sdram_init' was not declared. Should it be static?

    and:

    lc_common_dimm_params.c:15:1: warning: symbol 'compute_cas_latency_ddr3' was not declared. Should it be static?

    making it static produces the following compiler warning:

    lc_common_dimm_params.c:15:1: warning: 'compute_cas_latency_ddr3' defined but not used [-Wunused-function]

    so we protect it with the preprocessor.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • vsprintf.c:31:12: warning: symbol 'hex_asc' was not declared. Should it be static?
    vsprintf.c:398:18: warning: Using plain integer as NULL pointer

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • define Z_NULL to (void *)0 include/u-boot/zlib.h to get rid of most of
    the NULL pointer warnings.

    inflate.c:942:1: warning: non-ANSI definition of function 'inflateEnd'
    inflate.c:9:1: warning: non-ANSI definition of function 'inflateReset'
    inflate.c:12:17: warning: Using plain integer as NULL pointer
    inflate.c:12:42: warning: Using plain integer as NULL pointer
    inflate.c:15:17: warning: Using plain integer as NULL pointer
    inflate.c:21:19: warning: Using plain integer as NULL pointer
    inflate.c:35:1: warning: non-ANSI definition of function 'inflateInit2_'
    inflate.c:38:20: warning: Using plain integer as NULL pointer
    inflate.c:41:17: warning: Using plain integer as NULL pointer
    inflate.c:42:17: warning: Using plain integer as NULL pointer
    inflate.c:50:18: warning: Using plain integer as NULL pointer
    inflate.c:65:23: warning: Using plain integer as NULL pointer
    inflate.c:69:21: warning: Using plain integer as NULL pointer
    inflate.c:78:1: warning: non-ANSI definition of function 'inflateInit_'
    inflate.c:86:1: warning: non-ANSI definition of function 'fixedtables'
    inflate.c:108:26: warning: Using plain integer as NULL pointer
    inflate.c:109:1: warning: non-ANSI definition of function 'updatewindow'
    inflate.c:112:30: warning: Using plain integer as NULL pointer
    inflate.c:339:1: warning: non-ANSI definition of function 'inflate'
    inflate.c:349:17: warning: Using plain integer as NULL pointer
    inflate.c:349:42: warning: Using plain integer as NULL pointer
    inflate.c:350:27: warning: Using plain integer as NULL pointer
    inflate.c:369:42: warning: Using plain integer as NULL pointer
    inflate.c:376:32: warning: Using plain integer as NULL pointer
    inflate.c:401:54: warning: Using plain integer as NULL pointer
    inflate.c:419:32: warning: Using plain integer as NULL pointer
    inflate.c:426:32: warning: Using plain integer as NULL pointer
    inflate.c:433:32: warning: Using plain integer as NULL pointer
    inflate.c:444:36: warning: Using plain integer as NULL pointer
    inflate.c:449:37: warning: Using plain integer as NULL pointer
    inflate.c:450:38: warning: Using plain integer as NULL pointer
    inflate.c:457:40: warning: Using plain integer as NULL pointer
    inflate.c:458:47: warning: Using plain integer as NULL pointer
    inflate.c:480:40: warning: Using plain integer as NULL pointer
    inflate.c:481:50: warning: Using plain integer as NULL pointer
    inflate.c:491:37: warning: Using plain integer as NULL pointer
    inflate.c:492:37: warning: Using plain integer as NULL pointer
    inflate.c:501:40: warning: Using plain integer as NULL pointer
    inflate.c:502:53: warning: Using plain integer as NULL pointer
    inflate.c:512:37: warning: Using plain integer as NULL pointer
    inflate.c:513:40: warning: Using plain integer as NULL pointer
    inflate.c:525:32: warning: Using plain integer as NULL pointer
    inflate.c:529:52: warning: Using plain integer as NULL pointer
    inflate.c:543:54: warning: Using plain integer as NULL pointer
    inflate.c:932:17: warning: Using plain integer as NULL pointer
    inflate.c:932:42: warning: Using plain integer as NULL pointer
    inflate.c:935:26: warning: Using plain integer as NULL pointer
    inflate.c:940:19: warning: Using plain integer as NULL pointer
    adler32.c:58:5: warning: non-ANSI definition of function 'adler32'
    adler32.c:81:16: warning: Using plain integer as NULL pointer
    zutil.c:53:9: warning: non-ANSI definition of function 'zcalloc'
    zutil.c:64:9: warning: non-ANSI definition of function 'zcfree'
    inffast.c:70:1: warning: non-ANSI definition of function 'inflate_fast'
    inftrees.c:33:1: warning: non-ANSI definition of function 'inflate_table'

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • phy.c:46:5: warning: symbol 'genphy_config_advert' was not declared. Should it be static?
    phy.c:121:5: warning: symbol 'genphy_setup_forced' was not declared. Should it be static?
    phy.c:468:5: warning: symbol 'phy_probe' was not declared. Should it be static?
    phy.c:491:19: warning: symbol 'get_phy_driver' was not declared. Should it be static?
    phy.c:508:19: warning: symbol 'phy_device_create' was not declared. Should it be static?
    phy.c:552:5: warning: symbol 'get_phy_id' was not declared. Should it be static?
    phy.c:584:19: warning: symbol 'get_phy_device' was not declared. Should it be sta
    vitesse.c:126:5: warning: symbol 'vsc8601_config' was not declared. Should it be static?
    vsc7385.c:33:5: warning: symbol 'vsc7385_upload_firmware' was not declared. Should it be static?
    tgec_phy.c:33:5: warning: symbol 'tgec_mdio_write' was not declared. Should it be static?
    tgec_phy.c:75:5: warning: symbol 'tgec_mdio_read' was not declared. Should it be static?
    tgec_phy.c:117:5: warning: symbol 'tgec_mdio_reset' was not declared. Should it be static?
    eth.c:48:6: warning: symbol 'dtsec_configure_serdes' was not declared. Should it be static?
    p4080.c:26:5: warning: symbol 'port_to_devdisr' was not declared. Should it be static?

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • bootp.c:44:14: warning: symbol 'dhcp_state' was not declared. Should it be static?
    bootp.c:45:15: warning: symbol 'dhcp_leasetime' was not declared. Should it be static?
    bootp.c:46:10: warning: symbol 'NetDHCPServerIP' was not declared. Should it be static?
    arp.c:30:17: warning: symbol 'NetArpWaitReplyIP' was not declared. Should it be static?
    arp.c:37:16: warning: symbol 'NetArpTxPacket' was not declared. Should it be static?
    arp.c:38:17: warning: symbol 'NetArpPacketBuf' was not declared. Should it be static?
    atheros.c:33:19: warning: symbol 'AR8021_driver' was not declared. Should it be static?
    net.c:183:7: warning: symbol 'PktBuf' was not declared. Should it be static?
    net.c:159:21: warning: symbol 'net_state' was not declared. Should it be static?
    ping.c:73:6: warning: symbol 'ping_start' was not declared. Should it be static?
    ping.c:82:13: warning: symbol 'ping_receive' was not declared. Should it be static?
    tftp.c:53:7: warning: symbol 'TftpRRQTimeoutMSecs' was not declared. Should it be static?
    tftp.c:54:5: warning: symbol 'TftpRRQTimeoutCountMax' was not declared. Should it be static?
    eth.c:125:19: warning: symbol 'eth_current' was not declared. Should it be static?

    Note: in the ping.c fix, commit a36b12f95a29647a06b5459198684fc142482020
    "net: Move PING out of net.c" mistakenly carried the ifdef CMD_PING
    clause from when it was necessary to avoid warnings when it was embedded
    in net.c.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • command.c:44:38: error: bad constant expression
    dlmalloc.c:1468:2: warning: Using plain integer as NULL pointer
    dlmalloc.c:1468:5: warning: Using plain integer as NULL pointer
    dlmalloc.c:2176:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:2179:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2382:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2436:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2582:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2585:17: warning: Using plain integer as NULL pointer
    dlmalloc.c:2646:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2659:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2692:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2707:19: warning: Using plain integer as NULL pointer
    dlmalloc.c:2708:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2786:31: warning: Using plain integer as NULL pointer
    dlmalloc.c:2801:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:2801:22: warning: Using plain integer as NULL pointer
    dlmalloc.c:2926:27: warning: Using plain integer as NULL pointer
    dlmalloc.c:2928:14: warning: Using plain integer as NULL pointer
    dlmalloc.c:2929:12: warning: Using plain integer as NULL pointer
    dlmalloc.c:3075:14: warning: Using plain integer as NULL pointer
    hush.c:292:14: warning: symbol 'last_return_code' was not declared. Should it be static?
    hush.c:293:5: warning: symbol 'nesting_level' was not declared. Should it be static?
    hush.c:2175:20: warning: Using plain integer as NULL pointer
    hush.c:2175:34: warning: Using plain integer as NULL pointer
    hush.c:2210:41: warning: Using plain integer as NULL pointer
    hush.c:2216:45: warning: Using plain integer as NULL pointer
    hush.c:2249:25: warning: Using plain integer as NULL pointer
    hush.c:2332:13: warning: symbol 'new_pipe' was not declared. Should it be static?
    hush.c:2390:5: warning: symbol 'reserved_word' was not declared. Should it be static?
    hush.c:2927:5: warning: symbol 'parse_stream' was not declared. Should it be static?
    hush.c:3127:6: warning: symbol 'mapset' was not declared. Should it be static?
    hush.c:3133:6: warning: symbol 'update_ifs_map' was not declared. Should it be static?
    hush.c:3161:5: warning: symbol 'parse_stream_outer' was not declared. Should it be static?
    hush.c:3295:34: warning: Using plain integer as NULL pointer
    hush.c:3631:5: warning: symbol 'do_showvar' was not declared. Should it be static
    image.c:1282:29: warning: Using plain integer as NULL pointer
    image.c:1315:41: warning: Using plain integer as NULL pointer
    image.c:1330:25: warning: Using plain integer as NULL pointer
    image.c:1706:25: warning: Using plain integer as NULL pointer
    main.c:510:10: warning: symbol 'hist_num' was not declared. Should it be static?
    main.c:512:5: warning: symbol 'hist_list' was not declared. Should it be static?
    main.c:513:6: warning: symbol 'hist_lines' was not declared. Should it be static?
    usb_storage.c:195:6: warning: symbol 'usb_show_progress' was not declared. Should it be static?
    usb_storage.c:440:48: warning: Using plain integer as NULL pointer
    usb_storage.c:503:5: warning: symbol 'usb_stor_BBB_comdat' was not declared. Should it be static?
    usb_storage.c:551:5: warning: symbol 'usb_stor_CB_comdat' was not declared. Should it be static?
    usb_storage.c:629:55: warning: Using plain integer as NULL pointer
    usb_storage.c:620:5: warning: symbol 'usb_stor_CBI_get_status' was not declared. Should it be static?
    usb_storage.c:675:43: warning: Using plain integer as NULL pointer
    usb_storage.c:668:5: warning: symbol 'usb_stor_BBB_clear_endpt_stall' was not declared. Should it be static?
    usb_storage.c:679:5: warning: symbol 'usb_stor_BBB_transport' was not declared. Should it be static?
    usb_storage.c:801:5: warning: symbol 'usb_stor_CB_transport' was not declared. Sh
    xyzModem.c:104:1: warning: symbol 'CYGACC_COMM_IF_GETC_TIMEOUT' was not declared. Should it be static?
    xyzModem.c:122:1: warning: symbol 'CYGACC_COMM_IF_PUTC' was not declared. Should it be static?
    xyzModem.c:169:1: warning: symbol 'parse_num' was not declared. Should it be stat

    note: hush.c's nesting_level deleted because not used.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • cmd_boot.c:40:5: warning: symbol 'do_go' was not declared. Should it be static?
    cmd_bootm.c:164:6: warning: symbol '__arch_preboot_os' was not declared. Should it be static?
    cmd_bootm.c:477:5: warning: symbol 'do_bootm_subcommand' was not declared. Should it be static?
    cmd_bootm.c:1022:1: error: directive in argument list
    cmd_bootm.c:1028:1: error: directive in argument list
    cmd_bootm.c:1029:1: error: directive in argument list
    cmd_bootm.c:1036:1: error: directive in argument list
    cmd_bootm.c:1042:1: error: directive in argument list
    cmd_bootm.c:1044:1: error: directive in argument list
    cmd_bootm.c:1045:1: error: directive in argument list
    cmd_bootm.c:1047:1: error: directive in argument list
    cmd_bootm.c:1089:5: warning: symbol 'do_iminfo' was not declared. Should it be static?
    cmd_bootm.c:1176:5: warning: symbol 'do_imls' was not declared. Should it be static?
    cmd_bootm.c:1654:1: error: directive in argument list
    cmd_bootm.c:1660:1: error: directive in argument list
    cmd_console.c:32:5: warning: symbol 'do_coninfo' was not declared. Should it be s
    cmd_date.c:46:5: warning: symbol 'do_date' was not declared. Should it be static?
    cmd_echo.c:27:5: warning: symbol 'do_echo' was not declared. Should it be static?
    cmd_exit.c:27:5: warning: symbol 'do_exit' was not declared. Should it be static?
    cmd_fat.c:97:5: warning: symbol 'do_fat_ls' was not declared. Should it be static?
    cmd_fat.c:136:5: warning: symbol 'do_fat_fsinfo' was not declared. Should it be s
    cmd_fdt.c:66:5: warning: symbol 'do_fdt' was not declared. Should it be static?
    cmd_fdt.c:542:43: warning: incorrect type in assignment (different base types)
    cmd_fdt.c:542:43: expected unsigned int [unsigned] [usertype]
    cmd_fdt.c:542:43: got restricted __be32 [usertype]
    cmd_fdt.c:679:42: warning: cast to restricted __be32
    cmd_fdt.c:820:1: error: directive in argument list
    cmd_fdt.c:822:1: error: directive in argument list
    cmd_flash.c:292:5: warning: symbol 'do_flinfo' was not declared. Should it be static?
    cmd_flash.c:324:5: warning: symbol 'do_flerase' was not declared. Should it be static?
    cmd_flash.c:457:5: warning: symbol 'do_protect' was not declared. Should it be st
    cmd_help.c:27:5: warning: symbol 'do_help' was not declared. Should it be static?
    cmd_i2c.c:136:6: warning: symbol '__def_i2c_init_board' was not declared. Should it be static?
    cmd_i2c.c:144:14: warning: symbol '__def_i2c_get_bus_speed' was not declared. Should it be static?
    cmd_i2c.c:151:5: warning: symbol '__def_i2c_set_bus_speed' was not declared. Should it be static?
    cmd_i2c.c:1322:1: error: directive in argument list
    cmd_i2c.c:1324:1: error: directive in argument list
    cmd_i2c.c:1326:1: error: directive in argument list
    cmd_i2c.c:1328:1: error: directive in argument list
    cmd_i2c.c:1337:1: error: directive in argument list
    cmd_i2c.c:1339:1: error: directive in argument list
    cmd_irq.c:27:5: warning: symbol 'do_interrupts' was not declared. Should it be static?
    cmd_itest.c:133:5: warning: symbol 'binary_test' was not declared. Should it be static?
    cmd_itest.c:158:5: warning: symbol 'do_itest' was not declared. Should it be stat
    cmd_load.c:54:5: warning: symbol 'do_load_serial' was not declared. Should it be static?
    cmd_load.c:431:6: warning: symbol 'his_eol' was not declared. Should it be static?
    cmd_load.c:432:6: warning: symbol 'his_pad_count' was not declared. Should it be static?
    cmd_load.c:433:6: warning: symbol 'his_pad_char' was not declared. Should it be static?
    cmd_load.c:434:6: warning: symbol 'his_quote' was not declared. Should it be static?
    cmd_load.c:436:5: warning: symbol 'do_load_serial_bin' was not declared. Should it be static?
    cmd_load.c:549:6: warning: symbol 'send_pad' was not declared. Should it be static?
    cmd_load.c:558:6: warning: symbol 'ktrans' was not declared. Should it be static?
    cmd_load.c:568:5: warning: symbol 'chk1' was not declared. Should it be static?
    cmd_load.c:578:6: warning: symbol 's1_sendpacket' was not declared. Should it be static?
    cmd_load.c:587:6: warning: symbol 'send_ack' was not declared. Should it be static?
    cmd_load.c:600:6: warning: symbol 'send_nack' was not declared. Should it be static?
    cmd_load.c:614:6: warning: symbol 'os_data_init' was not declared. Should it be static?
    cmd_load.c:615:6: warning: symbol 'os_data_char' was not declared. Should it be static?
    cmd_load.c:657:6: warning: symbol 'k_data_init' was not declared. Should it be static?
    cmd_load.c:663:6: warning: symbol 'k_data_save' was not declared. Should it be static?
    cmd_load.c:669:6: warning: symbol 'k_data_restore' was not declared. Should it be static?
    cmd_load.c:675:6: warning: symbol 'k_data_char' was not declared. Should it be static?
    cmd_load.c:693:6: warning: symbol 'send_parms' was not declared. Should it be static?
    cmd_load.c:694:6: warning: symbol 'send_ptr' was not declared. Should it be static?
    cmd_load.c:698:6: warning: symbol 'handle_send_packet' was not declared. Should i
    cmd_mdio.c:60:5: warning: symbol 'mdio_write_ranges' was not declared. Should it be static?
    cmd_mdio.c:82:5: warning: symbol 'mdio_read_ranges' was not declared. Should it be static?
    cmd_mdio.c:115:5: warning: symbol 'extract_reg_range' was not declared. Should it be static?
    cmd_mdio.c:144:5: warning: symbol 'extract_phy_range' was not declared. Should it
    cmd_mem.c:54:5: warning: symbol 'do_mem_md' was not declared. Should it be static?
    cmd_mem.c:150:5: warning: symbol 'do_mem_mm' was not declared. Should it be static?
    cmd_mem.c:154:5: warning: symbol 'do_mem_nm' was not declared. Should it be static?
    cmd_mem.c:159:5: warning: symbol 'do_mem_mw' was not declared. Should it be static?
    cmd_mem.c:256:5: warning: symbol 'do_mem_cmp' was not declared. Should it be static?
    cmd_mem.c:326:5: warning: symbol 'do_mem_cp' was not declared. Should it be static?
    cmd_mem.c:436:5: warning: symbol 'do_mem_base' was not declared. Should it be static?
    cmd_mem.c:449:5: warning: symbol 'do_mem_loop' was not declared. Should it be static?
    cmd_mem.c:595:5: warning: symbol 'do_mem_mtest' was not declared. Should it be static?
    cmd_mem.c:618:26: warning: Using plain integer as NULL pointer
    cmd_mem.c:1057:5: warning: symbol 'do_mem_crc' was not declared. Should it be static?
    cmd_misc.c:30:5: warning: symbol 'do_sleep' was not declared. Should it be static
    cmd_mmc.c:118:5: warning: symbol 'do_mmcinfo' was not declared. Should it be static?
    cmd_mmc.c:272:32: warning: Using plain integer as NULL pointer
    cmd_mmc.c:150:5: warning: symbol 'do_mmcops' was not declared. Should it be stati
    cmd_mp.c:27:1: warning: symbol 'cpu_cmd' was not declared. Should it be static?
    cmd_mp.c:85:1: error: directive in argument list
    cmd_mp.c:88:1: error: directive in argument list
    cmd_mtdparts.c:150:18: warning: symbol 'mtdids' was not declared. Should it be static?
    cmd_mtdparts.c:153:18: warning: symbol 'devices' was not declared. Should it be static?
    cmd_mtdparts.c:713:5: warning: symbol 'mtd_device_validate' was not declared. Should it be static?
    cmd_mtdparts.c:1887:5: warning: symbol 'do_chpart' was not declared. Should it be static?
    cmd_mtdparts.c:1925:5: warning: symbol 'do_mtdparts' was not declared. Should it be static?
    cmd_mtdparts.c:2060:1: error: directive in argument list
    cmd_mtdparts.c:2063:1: error: directive in argument list
    cmd_mtdparts.c:2066:1: error: directive in argument list
    cmd_mtdparts.c:2071:1: error: directive in argument list
    cmd_mtdparts.c:2073:1: error: directive in argument list
    cmd_nand.c:377:18: error: bad constant expression
    cmd_nand.c:431:5: warning: symbol 'do_nand' was not declared. Should it be static?
    cmd_nand.c:796:1: error: directive in argument list
    cmd_nand.c:801:1: error: directive in argument list
    cmd_nand.c:802:1: error: directive in argument list
    cmd_nand.c:806:1: error: directive in argument list
    cmd_nand.c:819:1: error: directive in argument list
    cmd_nand.c:824:1: error: directive in argument list
    cmd_nand.c:825:1: error: directive in argument list
    cmd_nand.c:831:1: error: directive in argument list
    cmd_nand.c:918:5: warning: symbol 'do_nandboot' was not declared. Should it be static?
    cmd_net.c:33:5: warning: symbol 'do_bootp' was not declared. Should it be static?
    cmd_net.c:107:5: warning: symbol 'do_dhcp' was not declared. Should it be static?
    cmd_net.c:120:5: warning: symbol 'do_nfs' was not declared. Should it be static?
    cmd_nvedit.c:138:5: warning: symbol 'do_env_print' was not declared. Should it be static?
    cmd_nvedit.c:323:5: warning: symbol '_do_env_set' was not declared. Should it be static?
    cmd_nvedit.c:435:5: warning: symbol 'do_env_set' was not declared. Should it be static?
    cmd_nvedit.c:514:5: warning: symbol 'do_env_edit' was not declared. Should it be static?
    cmd_nvedit.c:620:5: warning: symbol 'do_env_save' was not declared. Should it be static?
    cmd_nvedit.c:1016:1: error: directive in argument list
    cmd_nvedit.c:1018:1: error: directive in argument list
    cmd_nvedit.c:1021:1: error: directive in argument list
    cmd_nvedit.c:1023:1: error: directive in argument list
    cmd_nvedit.c:1024:1: error: directive in argument list
    cmd_nvedit.c:1026:1: error: directive in argument list
    cmd_nvedit.c:1027:1: error: directive in argument list
    cmd_nvedit.c:1029:1: error: directive in argument list
    cmd_nvedit.c:1030:1: error: directive in argument list
    cmd_nvedit.c:1032:1: error: directive in argument list
    cmd_nvedit.c:1034:1: error: directive in argument list
    cmd_nvedit.c:1036:1: error: directive in argument list
    cmd_nvedit.c:1037:1: error: directive in argument list
    cmd_nvedit.c:1039:1: error: directive in argument list
    cmd_pci.c:38:17: warning: symbol 'ShortPCIListing' was not declared. Should it be static?
    cmd_pci.c:38:22: warning: 'ShortPCIListing' defined but not used [-Wunused-variable]
    cmd_pci.c:411:5: warning: symbol 'do_pci' was not declared. Should it be static?
    cmd_pci.c:494:1: error: directive in argument list
    cmd_pci.c:497:1: error: directive in argument list
    cmd_reginfo.c:40:5: warning: symbol 'do_reginfo' was not declared. Should it be static?
    cmd_sata.c:31:5: warning: symbol 'sata_curr_device' was not declared. Should it be static?
    note -> ata_piix.c doesn't seem to use 'sata_curr_device'; deleted.
    cmd_sata.c:32:18: warning: symbol 'sata_dev_desc' was not declared. Should it be static?
    cmd_sata.c:70:5: warning: symbol 'do_sata' was not declared. Should it be static?
    cmd_setexpr.c:53:5: warning: symbol 'do_setexpr' was not declared. Should it be static?
    cmd_source.c:186:1: error: directive in argument list
    cmd_source.c:190:1: error: directive in argument list
    cmd_test.c:27:5: warning: symbol 'do_test' was not declared. Should it be static?
    cmd_test.c:153:5: warning: symbol 'do_false' was not declared. Should it be static?
    cmd_test.c:164:5: warning: symbol 'do_true' was not declared. Should it be static
    cmd_usb.c:43:6: warning: symbol 'usb_get_class_desc' was not declared. Should it be static?
    cmd_usb.c:69:6: warning: symbol 'usb_display_class_sub' was not declared. Should it be static?
    cmd_usb.c:151:6: warning: symbol 'usb_display_string' was not declared. Should it be static?
    cmd_usb.c:161:6: warning: symbol 'usb_display_desc' was not declared. Should it be static?
    cmd_usb.c:195:6: warning: symbol 'usb_display_conf_desc' was not declared. Should it be static?
    cmd_usb.c:210:6: warning: symbol 'usb_display_if_desc' was not declared. Should it be static?
    cmd_usb.c:227:6: warning: symbol 'usb_display_ep_desc' was not declared. Should it be static?
    cmd_usb.c:252:6: warning: symbol 'usb_display_config' was not declared. Should it be static?
    cmd_usb.c:283:6: warning: symbol 'usb_show_tree_graph' was not declared. Should it be static?
    cmd_usb.c:343:6: warning: symbol 'usb_show_tree' was not declared. Should it be static?
    cmd_usb.c:356:5: warning: symbol 'do_usbboot' was not declared. Should it be static?
    cmd_usb.c:366:5: warning: symbol 'do_usb' was not declared. Should it be static?
    cmd_version.c:31:5: warning: symbol 'do_version' was not declared. Should it be s
    cmd_ximg.c:46:1: warning: symbol 'do_imgextract' was not declared. Should it be static?
    cmd_ximg.c:272:1: error: directive in argument list
    cmd_ximg.c:276:1: error: directive in argument list

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • include/image.h:378:1: warning: cast to restricted __be32
    include/image.h:381:1: warning: cast to restricted __be32
    include/image.h:382:1: warning: cast to restricted __be32
    include/image.h:383:1: warning: cast to restricted __be32

    fix by annotating image header integers big endian.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • traps.c:*:1: warning: symbol 'print_backtrace' was not declared. Should it be static?
    traps.c:93:1: warning: symbol '_exception' was not declared. Should it be static?
    board.c:166:6: warning: symbol '__board_add_ram_info' was not declared. Should it be static?
    board.c:174:5: warning: symbol '__board_flash_wp_on' was not declared. Should it be static?
    board.c:187:6: warning: symbol '__cpu_secondary_init_r' was not declared. Should it be static?
    board.c:265:12: warning: symbol 'init_sequence' was not declared. Should it be static?
    board.c:348:5: warning: symbol '__fixup_cpu' was not declared. Should it be static?
    board.c:405:53: warning: Using plain integer as NULL pointer

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • extable.c:66:9: warning: symbol 'ex_tab_message' was not declared. Should it be static?

    making it static can produce a new build warning on some boards:

    extable.c:66:12: warning: 'ex_tab_message' defined but not used [-Wunused-variable]

    but ex_tab_message doesn't do much even when used, so just remove it.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • a fixup __iomem definition in arch code appears to be placed there as a cover
    up from a code import from linux when u-boot didn't yet have a compiler.h,
    introduced by commit 812711ce6b3a386125dcf0d6a59588e461abbb87 "Implement
    __raw_{read,write}[bwl] on all architectures".

    git show 812711ce6b3a386125dcf0d6a59588e461abbb87:include/linux/compiler.h
    fatal: Path 'include/linux/compiler.h' exists on disk, but not in '812711ce6b3a386125dcf0d6a59588e461abbb87'.

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • hack to avoid:

    /opt/gcc-4.6.3-nolibc/powerpc-linux/bin/../lib/gcc/powerpc-linux/4.6.3/include/stddef.h:413:9: warning: preprocessor token offsetof redefined
    u-boot/include/linux/stddef.h:20:9: this was the original definition

    tried protecting with __KERNEL__, and #including compiler.h first.

    Even tried include dir reordering to no avail:

    +++ b/config.mk
    @@ -194,7 +194,11 @@ OBJCFLAGS += --gap-fill=0xff
    gccincdir := $(shell $(CC) -print-file-name=include)

    CPPFLAGS := $(DBGFLAGS) $(OPTFLAGS) $(RELFLAGS) \
    - -D__KERNEL__
    + -D__KERNEL__ \
    + -I $(gccincdir) \
    + -nostdinc
    +
    +# -isystem $(gccincdir) \

    # Enable garbage collection of un-used sections for SPL
    ifeq ($(CONFIG_SPL_BUILD),y)
    @@ -227,8 +231,7 @@ CPPFLAGS += -I$(OBJTREE)/include2 -I$(OBJTREE)/include
    endif

    CPPFLAGS += -I$(TOPDIR)/include
    -CPPFLAGS += -fno-builtin -ffreestanding -nostdinc \
    - -isystem $(gccincdir) -pipe $(PLATFORM_CPPFLAGS)
    +CPPFLAGS += -fno-builtin -ffreestanding -pipe $(PLATFORM_CPPFLAGS)

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • include/linux/unaligned/generic.h:5:9: warning: preprocessor token __force redefined
    include/linux/compiler.h:10:10: this was the original definition

    fixup __force definitions in compat.h code appears to be placed
    there as a cover up from a code import from linux when u-boot didn't yet
    have a compiler.h, introduced by commit
    b1b4e89a0f3b75854c39a62cae41bad56d210adf "Add LZO decompressor support".

    Signed-off-by: Kim Phillips

    Kim Phillips
     
  • include/linux/compat.h:4:9: warning: preprocessor token __user redefined
    include/linux/compiler.h:7:10: this was the original definition
    include/linux/compat.h:5:9: warning: preprocessor token __iomem redefined
    include/linux/compiler.h:12:10: this was the original definition

    fixup __iomem, __user definitions in compat.h code appears to be placed
    there as a cover up from a code import from linux when u-boot didn't yet
    have a compiler.h, introduced by commit
    932394ac43e2e778e664eeb6e456fecd0fae6e59 "Rewrite of NAND code based on
    what is in 2.6.12 Linux kernel".

    Signed-off-by: Kim Phillips

    Kim Phillips