24 Aug, 2017
8 commits
-
This reverts commit 6822cf3ec7c8768b8727573b8f4b2cb3d870b881.
As Bin Meng has tested and pointed out, we don't need the RX interrupt
for the RX buffer support at all. Just reading all available characters
into a buffer is sufficient to solve the problem with the dropped
characters upon long lines pasted into the U-Boot prompt. Since this
RX buffer support can be implemented in a generic way, without any
device specifica (e.g. for the ns16550), I'll post a new patch with
a new serial RX buffer support for DM, which all DM based serial
drivers can use.Signed-off-by: Stefan Roese
Cc: Simon Glass
Cc: Bin Meng
Cc: Tom Rini
Reviewed-by: Bin Meng -
With DM video, this is not used any more. Drop it.
Signed-off-by: Bin Meng
-
Let's imply the 'pci' command to access the de facto interconnect
bus in an x86 system.Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese -
Some Intel FSP (like Braswell) does SPI lock-down during the call
to fsp_notify(INIT_PHASE_BOOT). But before SPI lock-down is done,
it's bootloader's responsibility to configure the SPI controller's
opcode registers properly otherwise SPI controller driver doesn't
know how to communicate with the SPI flash device.This introduces a Kconfig option CONFIG_FSP_LOCKDOWN_SPI for such
FSPs. When it is on, U-Boot will configure the SPI opcode registers
before the lock-down.Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese -
At present the ICH SPI opcode registers configuration is done in the
ich_spi_remove() routine, a little bit weird but that's how current.
Linux MTD driver works. This changes to move the opcode registers
configuration to a separate routine ich_spi_config_opcode() which
might be called by U-Boot itself as well.Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese -
At present the ICH SPI controller driver reads the controller lock
status from its register in the probe routine and saves the lock
status to a member of priv. Later the driver uses the cached status
from priv to judge whether the controller setting is locked and do
different setup.But such logic is only valid when there is only the SPI controller
driver that touches the SPI hardware. In fact the lock status change
can be trigged outside the driver, eg: during the fsp_notify() call
when Intel FSP is used.This changes the driver to read the lock status every time when an
SPI transfer is initiated instead of reading the cached one.Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese -
There is no need to do another assignment to ich7_spi.
Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese -
This routine is not called anywhere.
Signed-off-by: Bin Meng
Reviewed-by: Stefan Roese
22 Aug, 2017
1 commit
-
Otherwise:
drivers/usb/gadget/f_fastboot.c:564:32: warning: format "%lx" expects
argument of type "long unsigned int", but argument 3 has type "unsigned
int" [-Wformat=]Signed-off-by: Tom Rini
21 Aug, 2017
13 commits
-
- Fix unmet direct dependencies warning
- Remove old sLD3 SoC support
- Update reset data
- Add dr_mode DT property to avoid warning -
The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
DRAM. Update the board_topology_map to reflect the correct
configuration.Signed-off-by: Chris Packham
Reviewed-by: Stefan Roese
Signed-off-by: Stefan Roese -
Signed-off-by: Lukasz Majewski
-
The function blk_dread will return -ENOSYS on failure or on success the
number of blocks read, which must be the number asked to read (otherwise
it failed somewhere). Correct this check.Cc: Lukasz Majewski
Signed-off-by: Tom Rini -
When building the flash zImage code on aarch64 we see warnings about
pointer size casts. Use uintptr_t instead to correct these.Cc: Sam Protsenko
Signed-off-by: Tom Rini
Reviewed-By: Sam Protsenko -
There is no guarantee that commands are null-terminated in the USB
request buffer, so limit the length of data that is printed.Signed-off-by: John Keeping
Tested-by: Steve Rae -
Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently
tells do_bootm() to look for an image at $loadaddr. This breaks if
CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set
loadaddr.Instead, tell do_bootm() to pick up the image where it was laoded.
Signed-off-by: Peter Chubb
Reviewed-by: Tom Rini
Acked-by: Steve Rae -
This converts CONFIG_USB_EHCI_PCI to a Kconfig option, and updates
all boards that use it.Signed-off-by: Bin Meng
-
Some of these were missed in the conversion.
Signed-off-by: Simon Glass -
Now that we have errors available in the environment driver's load()
method, check the return valid.Signed-off-by: Simon Glass
-
With the change to the environment code to remove the common init stage
of pointing to the default environment and setting it as valid, combined
with the change to switch gd->env_valid from 0/1/2 to an enum we now
must set env_valid to one of the enum values rather than an int. And in
this case, not only was setting it to an int wrong, it was now the wrong
value. Finally, in the case of ENV_IS_NOWHERE we must still say that
our envionrment is invalid after init for things to continue to
function.Fixes: 7938822a6b75 ("env: Drop common init() functions")
Tested-by: Marek Vasut
Reported-by: Marek Vasut
Reported-by: Andy Shevchenko
Signed-off-by: Tom Rini
---
Changes in v3:
- Actually include changes for env/nowhere.c
20 Aug, 2017
18 commits
-
Since commit 576e3cc700c5 ("usb: host: xhci-dwc3: Add dual role mode
support from DT"), warning is displayed if dr_mode is not specified.Signed-off-by: Masahiro Yamada
-
- Merge sys_reset data of LD4, Pro4, sLD8 and Pro5
- Merge sys_reset data of LD11 and LD20
- Use primitive UNIPHIER_RESETX() macro because bit assignments for
system reset will be changed for every SoC in the future- Add NAND and eMMC resets
Signed-off-by: Masahiro Yamada
-
This reverts commit 82d075e79fa509ffb8ecd8dd2dc216929d6e8289.
Commit 82d075e79fa5 ("ARM: uniphier: fix ROM boot mode for PH1-sLD3")
was a workaround for sLD3. Now the sLD3 SoC support has been removed.Revert it to allow to simplify the init code.
Signed-off-by: Masahiro Yamada
-
This reverts commit bcc51c1512a3deb6a9fdd37362c6dde32ad3da23.
Commit bcc51c1512a3 ("ARM: uniphier: move lowlevel debug init code
after page table switch") was intended to support lowlevel debug for
sLD3. Now the sLD3 SoC support has been removed.Revert it to allow to enable lowlevel debug earlier.
Signed-off-by: Masahiro Yamada
-
This SoC is too old. It is difficult to maintain any longer.
Signed-off-by: Masahiro Yamada
-
Since commit f0776a551764 ("spl: dm: Kconfig: SPL_CLK depends on
SPL_DM"), the following warning is displayed:$ make uniphier_v8_defconfig
warning: (ARCH_ZYNQ && ARCH_ZYNQMP && STM32F7 && CLK_UNIPHIER) selects
SPL_CLK which has unmet direct dependencies (CLK && SPL_DM)While I am here, I am removing the prompt to make it user-unconfigurable
option so that "select CLK_UNIPHIER" can be omitted.Signed-off-by: Masahiro Yamada
-
s/notes/nodes
Signed-off-by: Anatolij Gustschin
-
It would be easier to catch out which platform is using which default.
Signed-off-by: Andy Shevchenko
-
since commit: b529993e0222 "spl: add hierarchical defaults for SPL_LDSCRIPT"
taurus board stopped working. Use the ldscript from
arch/arm/cpu/u-boot-spl.lds (as before this patch) fixed it.Signed-off-by: Heiko Schocher
Reviewed-by: Philipp Tomsich -
CONFIG_SYS_GENERIC_GLOBAL_DATA is no longer used by any board or
platform, so support for it can be dropped.Signed-off-by: Thomas Petazzoni
Reviewed-by: Vladimir Zapolskiy
Reviewed-by: Simon Glass -
ATF can leave the MMC IP in a state where U-Boot mmc driver
can't enumerate the eMMC.This patch provides a mmc0_reset_clk() function like we
already so do sd card controller which resets the IP
when entering U-Boot.With this patch applied eMMC partitions are successfully
enumerated again.=> mmc dev 0
switch to partitions #0, OK
mmc0(part 0) is current device
=> mmc partPartition Map for MMC device 0 -- Partition Type: EFI
Part Start LBA End LBA Name
Attributes
Type GUID
Partition GUID
1 0x00000800 0x00000fff "vrl"
attrs: 0x0000000000000000
type: ebd0a0a2-b9e5-4433-87c0-68b6b72699c7
guid: 496847ab-56a1-4cd5-a1ad-47f4acf055c9
2 0x00001000 0x000017ff "vrl_backup"
attrs: 0x0000000000000000
type: ebd0a0a2-b9e5-4433-87c0-68b6b72699c7
guid: 61a36fc1-8efb-4899-84d8-b61642efa723
3 0x00001800 0x00001fff "mcuimage"Signed-off-by: Peter Griffin
-
The function blk_dread will return -ENOSYS on failure or on success the
number of blocks read, which must be the number asked to read (otherwise
it failed somewhere). Correct this check.Signed-off-by: Tom Rini
-
The function blk_dread will return -ENOSYS on failure or on success the
number of blocks read, which must be the number asked to read (otherwise
it failed somewhere). Correct this check.Signed-off-by: Tom Rini
-
The function blk_dread will return -ENOSYS on failure or on success the
number of blocks read, which must be the number asked to read (otherwise
it failed somewhere). Correct this check.Reported-by: Coverity (CID: 166335)
Cc: Philipp Tomsich
Cc: Simon Glass
Cc: Bin Meng
Signed-off-by: Tom Rini -
Now that sandbox is building cmd/mtdparts.c Coverity has looked at the
code and found a number of issues. In index_partitions() it is possible
that part will be NULL, so re-work the checks and debug statements to
take this into account. We have a number of string buffers that we
print to in the exact size of, and use string functions on, so we need
to ensure they are large enough to be NULL terminated. In
device_parse() it is not possible for num_partitions to be 0 (we would
have hit a different error first) so remove logically dead code.
Finally, in parse_mtdparts() if we have an error we need to free the
memory allocated to dev.Cc: Lothar Waßmann
Cc: Maxime Ripard
Reported-by: Coverity (CID: 166334, 166333, 166332, 166329, 166328)
Signed-off-by: Tom Rini -
Commit 089df18bfe9d ("lib: move hash CONFIG options to Kconfig") moved
CONFIG_SHA1, CONFIG_SHA256, CONFIG_SHA_HW_ACCEL, and
CONFIG_SHA_PROG_HW_ACCEL config options to Kconfig. So in the case of
SPL, CONFIG_SPL_HASH_SUPPORT enables CONFIG_SHA1 and CONFIG_SHA256 which
enables SHA SW library by default. But in the case of platforms with
SHA HW library support, SHA SW library becomes redundant and increases
size of SPL by approx 18K. Rework the code so that we have named
members and only have either software or hardware versions of the
algorithm, depending on the relevant config options. Update the comment
around hash_algo to reflect this as well.Reported-by: Sumit Garg
Cc: Sumit Garg
Signed-off-by: Tom Rini
Reviewed-by: Sumit Garg -
On some systems `python` is `python3` (for instance, Archlinux). The
`PYTHON` variable can be used to point to `python2` to have a successful
build.The use of `PYTHON` is currently limited in the Makefile and needs to be
extended in other places:First, pylibfdt is required to be a Python 2 binding (binman imports
pylibfdt and is only compatible Python 2), so its setup.py needs to be
called accordingly. An alternative would be to change the libfdt
setup.py shebang to python2, but the binding is actually portable. Also,
it would break on system where there is no such thing as `python2`.Secondly, the libfdt import checks need to be done against Python 2 as
well since the Python 2 compiled modules (in this case _libdft.so) can
not be imported from Python 3.Note on the libfdt imports: "@if ! PYTHONPATH=tools $(PYTHON) -c 'import
libfdt'; then..." is probably simpler than the currently sub-optimal
pipe.
Reviewed-by: Jonathan Gray
