24 Mar, 2014
3 commits
-
The way that struct mmc was implemented was a bit of a mess;
configuration and internal state all jumbled up in a single structure.On top of that the way initialization is done with mmc_register leads
to a lot of duplicated code in drivers.Typically the initialization got something like this in every driver.
struct mmc *mmc = malloc(sizeof(struct mmc));
memset(mmc, 0, sizeof(struct mmc);
/* fill in fields of mmc struct */
/* store private data pointer */
mmc_register(mmc);By using the new mmc_create call one just passes an mmc config struct
and an optional private data pointer like this:struct mmc = mmc_create(&cfg, priv);
All in tree drivers have been updated to the new form, and expect
mmc_register to go away before long.Changes since v1:
* Use calloc instead of manually calling memset.
* Mark mmc_register as deprecated.Signed-off-by: Pantelis Antoniou
-
Using an array is pointless; even more pointless (and scary) is using
sprintf to fill it without a format string.Signed-off-by: Pantelis Antoniou
-
Remove the in-structure ops and put them in mmc_ops with
a constant pointer to it.This makes the mmc structure smaller as well as conserving
code space (in theory).All in-tree drivers are converted as well; this is done in a
single patch in order to not break git bisect.Changes since V1:
Fix compilation b0rked issue on omap platforms where OMAP_GPIO was
not set.Signed-off-by: Pantelis Antoniou
24 Jul, 2013
1 commit
-
Signed-off-by: Wolfgang Denk
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini
09 Mar, 2013
1 commit
-
Add generic mmc write protection functionality.
Signed-off-by: Nikita Kiryanov
Signed-off-by: Igor Grinberg
07 Sep, 2012
1 commit
-
There were a couple of drivers that were actually using the flags
field of the cmd structure, despite the fact that no one ever
*set* that field. When we removed the field, those drivers failed
to compile. Replaced the references with the correct usage of
resp_type.Signed-off-by: Andy Fleming
01 Sep, 2012
1 commit
-
Configuration in vexpress and u8500.v1 is different from what
is needed in u8500.v2. As such, card configuration specifics need
to reside in the board file rather than the driver.Signed-off-by: John Rigby
Signed-off-by: Mathieu Poirier
Signed-off-by: Tom Rini
09 Jan, 2012
1 commit
-
Check for card detect each time an MMC/SD device is initialized. If card
detection is not implemented, this code behaves as before and continues
assuming a card is present. If no card is detected, has_init is reset
for the MMC/SD device (to force initialization next time) and an error
is returned.Signed-off-by: Thierry Reding
Tested-by: Jason Liu
09 Nov, 2011
1 commit
-
The new IO FPGA implementation for Versatile Express contains an MMCI
(PL180) cell with the FIFO extended to 128 words. This causes the
read_bytes() function to go into an infinite loop; as it will wait for
for the half-full signal (SDI_STA_RXFIFOBR) if there are more than 8
words remaining (SDI_FIFO_BURST_SIZE), but it won't receive this signal
once there are fewer than 64 words left to transfer.One possible fix is to add some build time configuration to change
SDI_FIFO_BURST_SIZE for the new implementation. However, the problematic
code only seems to exist as a small performance optimisation, so the
solution implemented by this patch is to simply remove it. The error
checking following the loop is also removed as this will be handled by
code further down the function.Cc: Andy Fleming
Signed-off-by: Jon Medhurst
29 Apr, 2011
2 commits
-
Make existing field b_max field in struct mmc unconditional
and use it instead of CONFIG_SYS_MMC_MAX_BLK_COUNT in mmc_bread
and mmc_bwrite.Initialize b_max to CONFIG_SYS_MMC_MAX_BLK_COUNT in mmc_register
if it has not been initialized by the hw driver.Initialize b_max to 0 in all callers to mmc_register.
Signed-off-by: John Rigby
Signed-off-by: Andy Fleming -
Add support for the ARM PrimeCell MultiMedia Interface - PL180.
Ported from original device driver written by ST-Ericsson.Signed-off-by: Matt Waddel
