25 Sep, 2014
3 commits
-
This tools is unnecessary since commit f6c8f38ec601
(tools/genboardscfg.py: improve performance more with Kconfiglib).Signed-off-by: Masahiro Yamada
-
We are still keeping invalid email addressed in MAINTAINERS
because they carry information.The problem is that scripts/get_maintainer.pl adds emails in the
"M:" field including invalid ones.We want to comment out invalid email addresses in MAINTAINERS
to prevent scripts/get_maintainer.pl from picking them up.
On the other hand, we want to collect them for boards.cfg
to know the last known maintainer of each board.This commit adjusts tools/genboardscfg.py to parse also
the commented "M:" fields, which is useful for the next commit.Signed-off-by: Masahiro Yamada
-
When building the U-Boot tools for non-ELF platforms (such as Blackfin
FLAT), since commit 79fc0c5f498c3982aa4740c273ab1a9255063d9c
("tools/env: cross-compile fw_printenv without setting HOSTCC"), the
build fails because it tries to strip a FLAT binary, which does not
make sense.This commit solves this by changing the stripping logic in
tools/env/Makefile to be similar to the one in tools/Makefile. This
logic continues to apply strip to the final binary, but does not abort
the build if it fails, and does the stripping in place on the final
binary. This allows the logic to work fine if stripping doesn't work,
as it leaves the final binary untouched.Signed-off-by: Thomas Petazzoni
Cc: Masahiro Yamada
Cc: Sonic Zhang
Reviewed-by: Masahiro Yamada
Reviewed-by: Sonic Zhang
22 Sep, 2014
2 commits
-
The get_maintainers script is a useful default, but sometimes is copies
too many people, or takes a long time to run.Add an option to disable it and update the README.
Signed-off-by: Simon Glass
-
This check should now be done whatever mode buildman is running in, since
we may be displaying information while building.Signed-off-by: Simon Glass
18 Sep, 2014
2 commits
-
Commit f219e01311b2 (tools: Import Kconfiglib)
added SPDX GPL-2.0+ to this library by mistake.
It should be ISC.Signed-off-by: Masahiro Yamada
Cc: Ulf Magnusson
17 Sep, 2014
2 commits
-
The idea of using Kconfiglib was given by Tom Rini.
It allows us to scan lots of defconfigs very quickly.
This commit also uses multiprocessing for further acceleration.Signed-off-by: Masahiro Yamada
Suggested-by: Tom Rini
Acked-by: Simon Glass -
Kconfiglib is the flexible Python Kconfig parser and library
created by Ulf Magnusson.
(https://github.com/ulfalizer/Kconfiglib)This commit imports kconfiglib.py from
commit ce84c22e58fa59cb93679d4ead03c3cd1387965e,
with ISC SPDX-License-Identifier.Signed-off-by: Masahiro Yamada
Signed-off-by: Ulf Magnusson
Cc: Ulf Magnusson
Cc: Wolfgang Denk
10 Sep, 2014
21 commits
-
try run => dry run
no nothing => do nothing
"..." => '...'The last one is for consistency with the other option helps.
Change-Id: I1d69047d1fae6ef095a18f69f44ee13c448db9b7
Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
When creating build directories also create parents as necessary. This
fixes a failure when building a hierarchical branch (i.e. foo/bar).Signed-off-by: Thierry Reding
Acked-by: Simon Glass
Tested-by: Tom Rini -
For an occasional user of patman some failures are not obvious: for
instance when checkpatch reports warnings, the dry run still reports
that the email would be sent. If it is not dry run, the warnings are
shown on the screen, but it is not clear that the email was not sent.Add some code to report failure to send email explicitly.
Tested by running the script on a patch with style violations,
observed error messages in the script output.Signed-off-by: Vadim Bendebury
Reviewed-by: Doug Anderson
Acked-by: Simon Glass -
Tags like Series-version are normally expected to appear once, and with a
unique value. But buildman doesn't actually look at these tags. So ignore
conflicts.This allows bulidman to build a branch containing multiple patman series.
Reported-by: Steve Rae
Signed-off-by: Simon Glass -
At present buildman naively uses the branch name as part of its directory
path, which causes problems if the name has an embedded '/'.Replace these with '_' to fix the problem.
Reported-by: Steve Rae
Signed-off-by: Simon Glass -
Now that buildman supports removing the build directory prefix from output,
add a test for it. Also ensure that output directories are removed when the
test completes.Signed-off-by: Simon Glass
-
This adds coverage of core features of the builder, including the
command-line options which affect building.Signed-off-by: Simon Glass
-
For reasons that are not well-understood, GetMetaDataForList() can end up
adding to an existing series even when it appears that it should be
starting a new one.Change from using a default constructor parameter to an explicit one, to
work around this problem.Signed-off-by: Simon Glass
-
For testing it is useful to clean the output directory before running a
test. This avoids a test interfering with the results of a subsequent
test by leaving data around.Add this feature as an optional parameter to the control logic.
Signed-off-by: Simon Glass
-
When a build is to be performed, buildman checks to see if it has already
been done. In most cases it will not bother trying again. However, it was
not reading the return code from the 'done' file, so if the result was a
failure, it would not be counted. This depresses the 'failure' count stats
that buildman prints in this case.Fix this bug by always reading the return code.
Signed-off-by: Simon Glass
-
Rather than reading boards.cfg, which may take time to generate and is not
necessarily suitable for running tests, create our own list of boards.Signed-off-by: Simon Glass
-
These files may not exist in the environment, or may not be suitable for
testing. Provide our own config file and our own toolchains when running
tests.Signed-off-by: Simon Glass
-
Move the bsettings code back to the main buildman.py file, so we can do
something different when testing.Signed-off-by: Simon Glass
-
Buildman currently lacks testing in many areas, including its use of git,
make and many command-line flags.Add a functional test which covers some of these areas. So far it does
a fake 'build' of all boards for the current source tree.This version reads the real ~/.buildman and boards.cfg files. Future work
will improve this.Signed-off-by: Simon Glass
-
Add a test point for the command module. This allows tests to emulate
the execution of commands. This provides more control (since we can make
the fake 'commands' do whatever we like), makes it faster to write tests
since we don't need to set up as much environment, and speeds up test
execution.Signed-off-by: Simon Glass
-
There is no good reason to keep this code separate. Move it into control.py
so it is easier to test.Signed-off-by: Simon Glass
-
We want to be able to issue parser commands from within buildman for test
purposes. Move the parser code into its own file so we don't end up needing
the buildman and test modules to reference each other.Signed-off-by: Simon Glass
-
RunPipe() currently pipes the output of stdout and stderr to a pty, but
this is not the intended behaviour. Fix it.Signed-off-by: Simon Glass
-
Adjust the basic test so that it checks all console output. This will help
to ensure that the builder is behaving correctly with printing summary
information.Signed-off-by: Simon Glass
-
To allow us to verify the builder's console output, send it through a
function which can collect it when running in test mode.Signed-off-by: Simon Glass
-
When running unit tests we don't want output to go to the terminal.
Provide a way of collecting it so that it can be examined by test code
later.Signed-off-by: Simon Glass
09 Sep, 2014
2 commits
-
The load region size of EIM-NOR are defined to 0. For this case,
the parameter "imximage_init_loadsize" must be calculated.
The imximage tool implements the calculation in the "imximage_generate"
function, but the following function "imximage_set_header" resets the value
and not calculate. This bug cause some fields of IVT head are not
correct, for example the boot_data and DCD overlay the application area.Signed-off-by: Ye.Li
-
According to mx53 and mx6 reference manuals:
"The maximum size of the DCD limited to 1768 bytes."
As each DCD entry consists of 8 bytes, we have a total of 1768 / 8 = 221, and
excluding the first entry, which is the header leads to 220 as the maximum
number for DCD size.Reported-by: Jonas Karlsson
Signed-off-by: Fabio Estevam
Acked-by: Nitin Garg
Acked-by: Nitin Garg
06 Sep, 2014
8 commits
-
A missing 'global' declaration means that this feature does not currently
work. Fix it.Signed-off-by: Simon Glass
-
Some boards unfortunately build with warnings and it is useful to be able
to easily distinguish the warnings from the errors.Use a simple pattern match to categorise gcc output into warnings and
errors, and display each separately. New warnings are shown in magenta (with
a w+ prefix) and fixed warnings are shown in yellow with a w- prefix.Signed-off-by: Simon Glass
-
Add a -l option to display a list of offending boards against each
error/warning line. The information will be shown in brackets as below:02: wip
sandbox: + sandbox
arm: + seaboard
+(sandbox) arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
+(sandbox) arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]
+(seaboard) board/nvidia/seaboard/seaboard.c: In function 'pin_mux_mmc':
+(seaboard) board/nvidia/seaboard/seaboard.c:36:9: warning: unused variable 'fred' [-Wunused-variable]
+(seaboard) int fred;
+(seaboard) ^Signed-off-by: Simon Glass
-
The full path is long and also includes buildman private directories.
Clean this up, so that only a relative U-Boot path is shown.This will change warnings like these:
/home/sjg/c/src/third_party/u-boot/buildman5/.bm-work/00/arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
/home/sjg/c/src/third_party/u-boot/buildman5/.bm-work/00/arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]/home/sjg/c/src/third_party/u-boot/files/arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
/home/sjg/c/src/third_party/u-boot/files/arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]to:
arch/sandbox/cpu/cpu.c: In function 'timer_get_us':
arch/sandbox/cpu/cpu.c:40:9: warning: unused variable 'i' [-Wunused-variable]Signed-off-by: Simon Glass
-
Some boards are known to be broken and it is convenient to be able to
exclude them from the build.Add an --exclude option to specific boards to exclude. This uses the
same matching rules as the normal 'include' arguments, and is a comma-
separated list of regular expressions.Suggested-by: York Sun
Signed-off-by: Simon Glass -
These characters are commonly used in variables, so permit them. Also
document the permitted characters.Reported-by: Tom Rini
Signed-off-by: Simon Glass -
When buildman finds errors/warnings when building, set the return code to
indicate this.Suggested-by: York Sun
Signed-off-by: Simon Glass -
patman collects tags that it sees in the commit and places them nicely
sorted at the end of the patch. However, this is not really necessary and
in fact is apparently not desirable.Suggested-by: Masahiro Yamada
Signed-off-by: Simon Glass
Tested-by: Masahiro Yamada