19 Jun, 2014
28 commits
-
This typo makes the comment confusing. Fix it.
Signed-off-by: Simon Glass
-
A small change allows this to operate on sandbox.
Signed-off-by: Simon Glass
-
This can be obtained by looking up the image type, so is redundant. It is
better to centralise this lookup to avoid errors.Signed-off-by: Simon Glass
-
This file has code in three different categories:
- Command processing
- OS-specific boot code
- Locating images and setting up to bootOnly the first category really belongs in a file called cmd_bootm.c.
Leave the command processing code where it is. Split out the OS-specific
boot code into bootm_os.c. Split out the other code into bootm.cHeader files and extern declarations are tidied but otherwise no code
changes are made, to make it easier to review.Signed-off-by: Simon Glass
-
It is more common to have 0 mean OK, and -ve mean error. Change this
function to work the same way to avoid confusion.Signed-off-by: Simon Glass
-
These tools crash if no arguments are provided. Add checks to avoid this.
Signed-off-by: Simon Glass
Acked-by: Heiko Schocher -
This seems like a better name. This is a patch-up to the earlier commit
63b4b5b, and also removes a redundant Makefile change.Signed-off-by: Simon Glass
-
The original code did not cover every case and there was a missing negative
sign in one case. Expand the coverage and fix the bug.Signed-off-by: Simon Glass
-
This type is more readily available on the host compiler, so use it instead.
Signed-off-by: Simon Glass
-
We don't make use of the device tree otherwise yet (and will need to
think how to not break the current multi-board support) and this causes
further breakage with additional changes.Signed-off-by: Tom Rini
-
Commit 7d89982b stopped creating symbolic link
arch/${arch}/include/asm/proc.arch/.gitignore should be updated.
Signed-off-by: Masahiro Yamada
Cc: Vasili Galka -
ext4fs_allocate_blocks() always allocates at least one block for a file.
If the file size is zero, this causes total_remaining_blocks to
underflow, which then causes an apparent hang while 2^32 blocks are
allocated.To solve this, check that total_remaining_blocks is non-zero as part of
the loop condition (i.e. before each loop) rather than at the end of
the loop.Signed-off-by: Stephen Warren
-
Before this commit, fdt_initrd() just returned if initrd
start address is zero.
But it is possible if the RAM is located at address 0.This commit makes the return condition more reasonable:
Just return if the size of initrd is zero.Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
Data written to DTB must be converted to big endian order.
It is usually done by using cpu_to_fdt32(), cpu_to_fdt64(), etc.fdt_initrd() invoked write_cell(), which always swaps byte order.
It means the function only worked on little endian architectures.
(On big endian architectures, the byte order should be kept as it is)This commit uses cpu_to_fdt32() and cpu_to_fdt64()
and deletes write_cell().Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
Data written to DTB must be converted to big endian order.
It is usually done by using cpu_to_fdt32(), cpu_to_fdt64(), etc.fdt_fixup_memory_banks() invoked write_cell(), which always
swaps byte order.
It means the function only worked on little endian architectures.This commit adds and uses a new helper function, fdt_pack_reg(),
which works on both big endian and little endian architrectures.Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
In the next commit, I will add a new function, fdt_pack_reg()
which uses get_cells_len().Beforehand, this commit adds 'const' qualifier to get_cells_len().
Otherwise, a warning message will appear:
warning: passing argument 1 of 'get_cells_len' discards 'const'
qualifier from pointer target type [enabled by default]Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
- Do not use a deep indentation. We have only 80-character
on each line and 1 indentation consumes 8 spaces. Before the
code moves far to the right, you should consider to
fix your code. See Linux Documentation/CodingStyle.- Add CONFIG_OF_STDOUT_VIA_ALIAS and OF_STDOUT_PATH macros
only to their definition. Do not add them to both
callee and caller. This is a tip to avoid using #ifdef
everywhere.- OF_STDOUT_PATH and CONFIG_OF_STDOUT_VIA_ALIAS are exclusive.
If both are defined, the former takes precedence.
Do not try to fix-up "linux,stdout-path" property twice.Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
After all, we have realized "force" argument is completely
useless. fdt_chosen() was always called with force = 1.We should always want to do the same thing
(set appropriate value to the property)
even if the property already exists.Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
After all, we have realized "force" argument is completely
useless. fdt_initrd() was always called with force = 1.We should always want to do the same thing
(set appropriate value to the property)
even if the property already exists.Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
Some functions in fdt_support.c do the same routine:
search a node with a given name ("chosen", "memory", etc.)
or newly create it if it does not exist.So this commit makes that routine to a helper function.
Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
gd->bd is not used in fdt_support.c.
Signed-off-by: Masahiro Yamada
Acked-by: Simon Glass -
Fix the following warning messages:
In function 'flash_erase': 180:21:
warning: variable 'last' set but not used [-Wunused-but-set-variable]
In function 'write_buff': 322:10:
warning: variable 'port_width' set but not used [-Wunused-but-set-variable]Signed-off-by: Masahiro Yamada
Cc: TsiChung Liew -
It has been observed that fit_check_format() will fail when passed a
corrupt FIT image. This was tracked down to _fdt_string_eq():
return (strlen(p) == len) && (memcmp(p, s, len) == 0);In the case of a corrupt FIT image one can't depend on 'p' being NULL
terminated. I changed it to use strnlen() to fix the issue.Signed-off-by: Tom Rini
-
M68k is big endian cpu ,so use be_out and be_in in big endian.
Signed-off-by: Chao Fu
-
Signed-off-by: Masahiro Yamada
-
A board that has a USB ethernet device only may set the usbetheraddr
and not the ethaddr.
ethaddr will be the default MAC address that is chosen and if that
is not populated then the usbethaddr is looked at. If neither are set
then then device tree blob is not modified.Signed-off-by: Dan Murphy
-
From comparison of current logic and the logic that was prior to commit
aba27ac, we see that first parameter of FPGA_GET_REG() shall be the
FPGA index and not channel number. The re-factoring in commit aba27ac
accidentally changed that.Cc: Stefan Roese
Acked-by: Dirk Eibach
Signed-off-by: Vasili Galka -
This is a MIME GnuPG-signed message. If you see this text, it means that
your E-mail or Usenet software does not support MIME signed messages.
The Internet standard for MIME PGP messages, RFC 2015, was published in 1996.
To open this message correctly you will need to install E-mail or Usenet
software that supports modern Internet standards.Revert changes in iocon.h config file caused by
these two commits:
"configs: iocom: Fix typo on CMD_FPGA command"
(sha1: d0db28f94034ef02c1d6737895766fb3c19de47f)
and
"fpga: Guard the LOADMK functionality with CMD_FPGA_LOADMK"
(sha1: 64e809afeaf1572c3246a5bca198a77d0498fd89)CONFIG_CMD_FPGAD is own command.
Reported-by: Dirk Eibach
Signed-off-by: Michal Simek
12 Jun, 2014
12 commits
-
Cleanup to balance malloc/free calls.
Signed-off-by: Darwin Rambo
Reviewed-by: Steve Rae
Acked-by: Pantelis Antoniou -
Currently, U-Boot behaves as follows:
- Begin with no SD card inserted in "mmc 1"
- Execute: mmc dev 1
- This fails, since there is no card
- User plugs in an SD card
- Execute: mmc dev 1
- This still fails, since the HW isn't reprobed.With this change, U-Boot behaves as follows:
- Begin with no SD card inserted in "mmc 1"
- Execute: mmc dev 1
- This fails, since there is no card
- User plugs in an SD card
- Execute: mmc dev 1
- The newly present SD card is detectedI know that "mmc rescan" will force the HW to be reprobed, but I feel it
makes more sense if "mmc dev" always reprobes the HW after selecting the
current MMC device. This allows scripts to just execute "mmc dev", and
not have to also execute "mmc rescan" to check for media presense.Signed-off-by: Stephen Warren
Acked-by: Pantelis Antoniou -
The body of init_mmc_device() is now identical to that of do_mmc_rescan()
except for the error codes returned. Modify do_mmc_rescan() to simply
call init_mmc_device() and convert the error codes, to avoid code
duplication.Signed-off-by: Stephen Warren
Acked-by: Pantelis Antoniou -
This allows callers to inject mmc->has_init = 0 between finding the
MMC device, and calling mmc_init(), which forces mmc_init() to rescan
the HW. Future changes will use this feature.Signed-off-by: Stephen Warren
Acked-by: Jaehoon Chung
Acked-by: Pantelis Antoniou -
Currently, get_device()/get_dev_hwpart() for MMC devices does not select
an explicit HW partition unless the user explicitly requests one, i.e. by
requesting device "mmc 0.0" rather than just "mmc 0". I think it makes
more sense if the default is to select HW partition 0 (main data area)
if the user didn't request a specific partition. Otherwise, the following
happens, which feels wrong:Select HW partition 1 (boot0):
mmc dev 0 1Attempts to access SW partition 1 on HW partition 1 (boot0), rather than
SW partition 1 on HW partition 0 (main data area):
ls mmc 0:1 /With this patch, the second command above re-selects the main data area.
Many device types don't support HW partitions at all, so if HW partition
0 is selected (either explicitly or as the default) and there's no
select_hwpart function, we simply skip attempting to select a HW
partition.Some MMC devices (i.e. SD cards) don't support HW partitions. However,
this patch still works, since mmc_start_init() sets the current
partition number to 0, and mmc_select_hwpart() succeeds if the requested
partition is already selected.Signed-off-by: Stephen Warren
Acked-by: Pantelis Antoniou -
Currently, "mmc dev 0" does not change the selected HW partition. I
think it makes more sense if "mmc dev 0" is an alias for "mmc dev 0 0",
i.e. that HW partition 0 (main data area) is always selected by default
if the user didn't request a specific partition. Otherwise, the following
happens, which feels wrong:Select HW partition 1 (boot0):
mmc dev 0 1Doesn't change the HW partition, so it's still 1 (boot0):
mmc dev 0With this patch, the second command above re-selects the main data area.
Note that some MMC devices (i.e. SD cards) don't support HW partitions.
However, this patch still works, since mmc_start_init() sets the current
partition number to 0, and mmc_select_hwpart() succeeds if the requested
partition is already selected.Signed-off-by: Stephen Warren
Acked-by: Pantelis Antoniou -
Rather than just returning -1 everywhere, try to return something
meaningful from mmc_select_hwpart(). Note that most other MMC functions
don't do this, including functions called from mmc_select_hwpart(), so
I'm not sure how effective this will be. Still, it's one less place with
hard-coded -1.Suggested-by: Pantelis Antoniou
Signed-off-by: Stephen Warren
Acked-by: Pantelis Antoniou -
- "i2c mw" command hangs (with some compilers)
Signed-off-by: Steve Rae
-
To prevent a warning for clang the loop without a body
is made more clear by moving it to a line of its own.
This prevents a clang warning.cc: sbabic@denx.de
Signed-off-by: Jeroen Hofstee -
Clang interpretes an if condition like "if ((a = b) == NULL)
as it tries to assign a value in a statement. Hence if you do
"if ((something)) it warns you that you might be confused.
Hence drop the double braces for plane if statements.Signed-off-by: Jeroen Hofstee
-
Clang interpretes an if condition like "if ((a = b) == NULL)
as it tries to assign a value in a statement. Hence if you do
"if ((something)) it warns you that you might be confused.
Hence drop the double braces for plane if statements.cc: Holger Brunck
Signed-off-by: Jeroen Hofstee
