03 Dec, 2019

2 commits

  • Drop inclusion of crc.h in common.h and use the correct header directly
    instead.

    With this we can drop the conflicting definition in fw_env.h and rely on
    the crc.h header, which is already included.

    Signed-off-by: Simon Glass
    Reviewed-by: Tom Rini

    Simon Glass
     
  • Some of these have a space before the bracket. Drop it to fix the style.
    Add some missing function comments while here.

    Note that u32 and u8 cannot be used here since crc.h is included on the
    host side.

    Signed-off-by: Simon Glass
    Reviewed-by: Tom Rini

    Simon Glass
     

21 Nov, 2019

1 commit

  • We have CONFIG_ENV_SIZE_IS_REDUND but don't really use it. We have one
    board where we can simply multiple CONFIG_ENV_SIZE by two for the same
    result. The other place where we could but were not previously using
    this is for where env_internal.h checks for if we should set
    ENV_IS_EMBEDDED. This seems like the most likely use, historically, of
    the variable, but it was not used. Add logic to check for this now.

    Cc: Wolfgang Denk
    Cc: Joe Hershberger
    Signed-off-by: Tom Rini
    Reviewed-by: Simon Glass
    Acked-by: Joe Hershberger

    Tom Rini
     

13 Nov, 2019

1 commit


12 Aug, 2019

2 commits

  • This file contains lots of internal details about the environment. Most
    code can include env.h instead, calling the functions there as needed.

    Rename this file and add a comment at the top to indicate its internal
    nature.

    Signed-off-by: Simon Glass
    Acked-by: Joe Hershberger
    Reviewed-by: Simon Goldschmidt
    [trini: Fixup apalis-tk1.c]
    Signed-off-by: Tom Rini

    Simon Glass
     
  • The name 'environment' is widely used in U-Boot so is not a very useful
    name of a variable. Rename it to better indicate its purpose.

    Signed-off-by: Simon Glass
    Acked-by: Joe Hershberger
    Reviewed-by: Simon Goldschmidt

    Simon Glass
     

07 May, 2018

1 commit

  • When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

24 Nov, 2016

1 commit


24 Jul, 2013

1 commit


05 Jan, 2012

1 commit


07 Dec, 2011

1 commit

  • When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set,
    the environment.h file does not get included resulting in unrecognized
    env_t type.
    Fix this by moving the include directive.

    Reported-by: Mike Frysinger
    Signed-off-by: Igor Grinberg
    Tested-by: Mike Frysinger

    Igor Grinberg
     

22 Nov, 2011

1 commit


26 Jul, 2011

1 commit


28 Oct, 2009

1 commit


19 Oct, 2009

2 commits

  • Newer toolchains will often complain about unchecked fwrite():
    envcrc.c:117: warning: ignoring return value of `fwrite´, declared
    with attribute warn_unused_result

    So check the return value to silence the warnings.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     
  • The env code is protected by the ENV_IS_EMBEDDED define, so attempting to
    compile the code when this isn't defined is pointless. Now that the env
    headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build
    system to only build the env objects when this is enabled. And now that
    the env code is conditionally compiled, we can drop the source code checks.

    For people who want to extract the environment manually, add a new option
    CONFIG_BUILD_ENVCRC that only enables the envcrc utility.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

13 Jun, 2009

1 commit


19 Oct, 2008

1 commit


11 Sep, 2008

2 commits


24 Apr, 2008

1 commit

  • The envcrc.c does sizeof(unsigned long) when calculating the crc, but
    this is done with the build toolchain instead of the target tool
    chain, so if the build is a 64bit system but the target is 32bits,
    the size will obviously be wrong. This converts all unsigned long
    stuff related to crc32 to uint32_t types. Compile tested only: output
    of ./tools/envcrc when run on a 32bit build system matches that of a
    64bit build system.

    Signed-off-by: Mike Frysinger
    Acked-by: Jean-Christophe PLAGNIOL-VILLARD

    Mike Frysinger
     

04 Aug, 2005

1 commit


28 Jun, 2003

1 commit

  • - remove trailing white space, trailing empty lines, C++ comments, etc.
    - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)

    * Patches by Kenneth Johansson, 25 Jun 2003:
    - major rework of command structure
    (work done mostly by Michal Cendrowski and Joakim Kristiansen)

    wdenk
     

06 Mar, 2003

1 commit

  • - Add support for Innokom board
    - Don't complain if "install" fails
    - README cleanup (remove duplicated lines)
    - Update PXA header files

    * Add documentation for existing POST code (doc/README.POST)

    * Patch by Laudney Ren, 15 Jan 2003:
    Fix handling of redundand environment in "tools/envcrc.c"

    * Patch by Detlev Zundel, 28 Feb 2003:
    Add bedbug support for 824x systems

    * Add support for 16 MB flash configuration of TRAB board

    * Patch by Erwin Rol, 27 Feb 2003:
    Add support for RTEMS

    * Add image information to README

    * Fix dual PCMCIA slot support (when running with just one
    slot populated)

    * Add VFD type detection to trab board

    * extend drivers/cs8900.c driver to synchronize ethaddr environment
    variable with value in the EEPROM

    wdenk
     

18 Sep, 2002

1 commit