18 Jan, 2020
3 commits
-
These three globals relate to image handling. Move them to the image
header file.Signed-off-by: Simon Glass
-
These global variables are quite short and generic. In fact the same name
is more often used locally for struct members and function arguments.Add a image_ prefix to make them easier to distinguish.
Signed-off-by: Simon Glass
-
This function belongs more in flash.h than common.h so move it.
Also remove the space before the bracket in some calls.
Signed-off-by: Simon Glass
03 Dec, 2019
1 commit
-
This function belongs in time.h so move it over and add a comment.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
05 Sep, 2019
5 commits
-
rpc_pkt.u.call.data is an array of uint32_t. There is no need to convert
it to uint32_t *.memcpy() expects void * as it 1st and 2nd argument. There is no point in
converting pointers to char * before passing them to memcpy().In ntohl(data[1]) != 0 calling ntohl() is superfluous. If the value is
zero, does not depend on the byte order.Signed-off-by: Heinrich Schuchardt
Reviewed-by: Bin Meng
Acked-by: Joe Hershberger -
This patch adds a check to rpc_pkt.u.reply.data at nfs_lookup_reply.
Signed-off-by: Cheng Liu
Reported-by: Fermín Serna
Acked-by: Joe Hershberger -
This patch adds a check to rpc_pkt.u.reply.data at nfs_readlink_reply.
Signed-off-by: Cheng Liu
Reported-by: Fermín Serna
Acked-by: Joe Hershberger -
…eck at nfs_read_reply
This patch adds a check to rpc_pkt.u.reply.data at nfs_read_reply.
Signed-off-by: Cheng Liu <liucheng32@huawei.com>
Reported-by: Fermín Serna <fermin@semmle.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com> -
This patch adds a check to nfs_handler to fix buffer overflow for CVE-2019-14197,
CVE-2019-14200, CVE-2019-14201, CVE-2019-14202, CVE-2019-14203 and CVE-2019-14204.Signed-off-by: Cheng Liu
Reported-by: Fermín Serna
Acked-by: Joe Hershberger
27 Jul, 2018
3 commits
-
The same basic parsing was implemented in tftp and nfs, so add a helper
function to do the work once.Signed-off-by: Joe Hershberger
-
nfs was only printing basic info about the transfer in the case of a
DEBUG build. Print the same level of detail as tftp always.Signed-off-by: Joe Hershberger
-
The check for sending to the gateway was not using the correct variable
for comparison, so it was reporting that packets are sent to the gateway
when they were not.Signed-off-by: Joe Hershberger
14 Jun, 2018
1 commit
-
That can happen if duplicate UDP packet arrived, and that's not uncommon.
Anyway, we ignore packets with rpc_id lower than last we sent for other
requests, so it makes sense to do that for read request as well.Signed-off-by: Vasily Khoruzhick
Acked-by: Joe Hershberger
10 Sep, 2016
1 commit
-
This reverts commit 998372b4798fd7ebb666f571950df925b8d80f69.
This caused a data abort on some platform.
Signed-off-by: Joe Hershberger
Reported-by: Guillaume GARDET
23 Aug, 2016
10 commits
-
We use an empty hostname, so remove all the "processing" of the
known-to-be-empty hostname and just write 0's where needed.Signed-off-by: Joe Hershberger
-
Instead of always allocating a huge temporary buffer on the stack and
then memcpy()ing the result into the transmit buffer, simply figure out
where in the transmit buffer the bytes will belong and write them there
directly as each message is built.Signed-off-by: Joe Hershberger
-
Much of the information is verbose and derived directly from the
environment. Only output in debug mode. This also saves about 300 bytes
from the code size.Signed-off-by: Joe Hershberger
-
Use the same name throughout the nfs code and use the same member of the
union to avoid casts.Signed-off-by: Joe Hershberger
-
The buffer is of 32-bit elements, not bytes.
Signed-off-by: Joe Hershberger
-
Instead of repeating the same large snippet for dealing with attributes
it should be shared with a helper function.Signed-off-by: Joe Hershberger
-
Fix complaints from checkpatch.pl.
Signed-off-by: Joe Hershberger
-
The v3 handles can be larger than v2, but that doesn't mean we need a
separate buffer. Reuse the same (larger) buffer for both.Signed-off-by: Joe Hershberger
-
This patch enables NFSv3 support.
If NFSv2 is available use it as usual.
If NFSv2 is not available, but NFSv3 is available, use NFSv3.
If NFSv2 and NFSv3 are not available, print an error message since NFSv4 is not supported.Tested on iMX6 sabrelite with 4 Linux NFS servers:
* NFSv2 + NFSv3 + NFSv4 server: use NFSv2 protocol
* NFSv2 + NFSv3 server: use NFSv2 protocol
* NFSv3 + NFSv4 server: use NFSv3 protocol
* NFSv3 server: use NFSv3 protocolSigned-off-by: Guillaume GARDET
Cc: Tom Rini
Cc: joe.hershberger@ni.com
Acked-by: Joe Hershberger -
There is no reason to store the default filename in a separate buffer
only to immediately copy it to the main name buffer. Just write it there
directly and remove the other buffer.Signed-off-by: Joe Hershberger
06 Jul, 2016
1 commit
-
This patch fixes incorrect RPC packet layout caused by
'long' type size difference on 64 and 32-bit architectures.Signed-off-by: Ralf Hubert
Acked-by: Joe Hershberger
22 Jun, 2016
1 commit
-
Signed-off-by: Guillaume GARDET
Cc: joe.hershberger@ni.com
Acked-by: Joe Hershberger
19 Apr, 2015
7 commits
-
Finish eliminating CamelCase from net.c and other failures
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within nfs.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch cleans up the names of internal packet buffer names that are
used within the network stack and the functions that use them.Signed-off-by: Joe Hershberger
-
Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
The variables around the bootfile were inconsistent and used CamelCase.
Update them to make the code more readable.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Previously the net functions would access memory assuming physmem did
not need to be mapped. In sandbox, that's not the case.Now we map the physmem specified by the user in loadaddr to the buffer
that represents that space.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
25 Jun, 2013
1 commit
-
This patch tackles the time out problem which leads to break the
boot process, when loading file over nfs. The patch does two things.First of all, we just ignore messages that arrive with a rpc_id smaller
then the client id. We just interpret this messages as answers to
formaly timed out messages.Second, when a time out occurs we double the time to wait, so that we
do not stress the server resending the last message.Signed-off-by: Matthias Brugger
Tested-by: Enric Balletbo i Serra
13 Jul, 2012
1 commit
-
NFS_TIMEOUT is constant value defined in net/nfs.c. But sometimes it needs to adjust.
This patch enables to override NFS_TIMEOUT by defining CONFIG_NFS_TIMEOUT in a board specific config file.Signed-off-by: Tetsuyuki Kobayashi
24 May, 2012
3 commits
-
Call a built-in dummy if none is registered... don't require
protocols to register a handler (eliminating dummies)
NetConsole now uses the ARP handler when waiting on arp
(instead of needing a #define hack in arp.c)
Clear handlers at the end of net loopSigned-off-by: Joe Hershberger
Acked-by: Simon Glass -
Changes to NetState now go through an accessor function called
net_set_state()Signed-off-by: Joe Hershberger
-
Rename IP header related things to IP_UDP. The existing definition
of IP_t includes UDP header, so name it to accurately describe the
structure.Signed-off-by: Joe Hershberger
16 May, 2012
1 commit
-
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
07 Dec, 2011
1 commit
-
When building u-boot as 64 bit application (e.g. sandbox) ulong might be
64 bits in size. This breaks network code as IPaddr_t is 64 bytes in
size then and an IPv4 address is 32 bits in size. This patch makes sure
that IPaddr_t is always 32 bits in size. Also some warnings introduced
by this patch are fixed.Signed-off-by: Matthias Weisser
Acked-by: Mike Frysinger
