16 Aug, 2017

2 commits

  • We are now using an env_ prefix for environment functions. Rename these
    two functions for consistency. Also add function comments in common.h.

    Quite a few places use getenv() in a condition context, provoking a
    warning from checkpatch. These are fixed up in this patch also.

    Suggested-by: Wolfgang Denk
    Signed-off-by: Simon Glass

    Simon Glass
     
  • We are now using an env_ prefix for environment functions. Rename these
    commonly used functions, for consistency. Also add function comments in
    common.h.

    Suggested-by: Wolfgang Denk
    Signed-off-by: Simon Glass

    Simon Glass
     

12 Jul, 2017

2 commits


10 Jul, 2017

1 commit

  • If the value of either "nand options" or "bbt options" has a zero in
    the most significant nibble, the '0x' prefix will be isolated from the
    value like shown below:
    |Device 0: nand0, sector size 128 KiB
    | Page size 2048 b
    | OOB size 64 b
    | Erase size 131072 b
    | subpagesize 2048 b
    | options 0x40000200
    | bbt options 0x 60000

    Change the format string to produce leading zeroes filling the gap.

    Signed-off-by: Lothar Waßmann

    Lothar Waßmann
     

02 Sep, 2016

2 commits

  • Now that nand_info[] is an array of pointers we need to test the
    pointer itself rather than using name as a proxy for NULLness.

    Fixes: b616d9b0a708eb9 ("nand: Embed mtd_info in struct nand_chip")
    Signed-off-by: Scott Wood
    Cc: Lukasz Majewski
    Cc: Tony Lindgren
    Acked-by: Tony Lindgren

    Scott Wood
     
  • Looks like we have few more places where we're testing for
    nand_info[i]->name. We can now use just test for nand_info[i]
    instead.

    This fixes a data abort on devices with no NAND when doing
    nand info.

    Signed-off-by: Tony Lindgren
    Reviewed-by: Tom Rini

    Tony Lindgren
     

27 Aug, 2016

1 commit

  • If we do nand device 0 command in u-boot on a device that has NAND support
    enabled but no NAND chip, we can get data abort at least on omaps.

    Fix the issue by replacing the check with nand_info[dev] as
    suggested by Scott Wood. The check for name existed before because before
    the array-to-pointer conversion there was no way to directly test
    nand_info[dev] for emptiness.

    Signed-off-by: Tony Lindgren

    Tony Lindgren
     

25 Jul, 2016

1 commit

  • Modern NANDs do not guarantee that data written in raw mode will not
    contain bitflips just after writing them. This is fine since the number
    of bitflips should be rather low and thus fixable by the ECC engine,
    but since we are reading data in raw mode to verify if they match the
    input data we cannot prevent failures if some bits are flipped.

    The option of using standard mode to verify the data is not acceptable
    either, since one of the usage of raw mode is to allow flashing images
    that do not respect the standard NAND page layout or the default ECC
    config (this is the case on Allwinner platforms, where the ROM code
    tests several hardcoded configs, which are not necessarily matching the
    NAND characteristics).

    Add an extension to the nand write.raw command allowing one to disable
    the verification step.

    Signed-off-by: Boris Brezillon
    Reviewed-by: Tom Rini

    Boris Brezillon
     

20 Jun, 2016

1 commit

  • nand torture currently works on exactly one nand block which is specified
    by giving the byteoffset to the beginning of the block.

    Extend this by allowing for a second parameter specifying the byte size
    to be tested.

    e.g.
    ==> nand torture 1000000

    NAND torture: device 0 offset 0x1000000 size 0x20000 (block size 0x20000)
    Passed: 1, failed: 0

    ==> nand torture 1000000 40000

    NAND torture: device 0 offset 0x1000000 size 0x40000 (block size 0x20000)
    Passed: 2, failed: 0

    Signed-off-by: Max Krummenacher
    Reviewed-by: Benoît Thébaudeau
    [scottwood: fix usage to show size as optional, and add misssing braces]
    Signed-off-by: Scott Wood

    Max Krummenacher
     

04 Jun, 2016

3 commits


25 Jan, 2016

1 commit

  • Now that they are in their own directory, we can remove this prefix.
    This makes it easier to find a file since the prefix does not get in the
    way.

    Signed-off-by: Simon Glass
    Reviewed-by: Bin Meng
    Reviewed-by: Heiko Schocher
    Acked-by: Stefan Roese
    Acked-by: Przemyslaw Marczak

    Simon Glass