Eric Lee / smarc-uboot

14 Sep, 2014

1 commit

  • 461be2f96   kconfig: remove redundant "string" type in arch and board Kconfigs ... Browse Code »
    43

    Now the types of CONFIG_SYS_{ARCH, CPU, SOC, VENDOR, BOARD, CONFIG_NAME}
    are specified in arch/Kconfig.

    We can delete the ones in arch and board Kconfig files.

    This commit can be easily reproduced by the following command:

    find . -name Kconfig -a ! -path ./arch/Kconfig | xargs sed -i -e '
    /config[[:space:]]SYS_\(ARCH\|CPU\|SOC\|\VENDOR\|BOARD\|CONFIG_NAME\)/ {
    N
    s/\n[[:space:]]*string//
    }
    '

    Signed-off-by: Masahiro Yamada

    Masahiro Yamada
     

30 Jul, 2014

2 commits

  • 93d4334f7   Add board MAINTAINERS files ... Browse Code »

    We have switched to Kconfig and the boards.cfg file is going to
    be removed. We have to retrieve the board status and maintainers
    information from it.

    The MAINTAINERS format as in Linux Kernel would be nice
    because we can crib the scripts/get_maintainer.pl script.

    After some discussion, we chose to put a MAINTAINERS file under each
    board directory, not the top-level one because we want to collect
    relevant information for a board into a single place.

    TODO:
    Modify get_maintainer.pl to scan multiple MAINTAINERS files.

    Signed-off-by: Masahiro Yamada
    Suggested-by: Tom Rini
    Acked-by: Simon Glass

    Masahiro Yamada
     
  • dd84058d2   kconfig: add board Kconfig and defconfig files ... Browse Code »

    This commit adds:
    - arch/${ARCH}/Kconfig
    provide a menu to select target boards
    - board/${VENDOR}/${BOARD}/Kconfig or board/${BOARD}/Kconfig
    set CONFIG macros to the appropriate values for each board
    - configs/${TARGET_BOARD}_defconfig
    default setting of each board

    (This commit was automatically generated by a conversion script
    based on boards.cfg)

    In Linux Kernel, defconfig files are located under
    arch/${ARCH}/configs/ directory.
    It works in Linux Kernel since ARCH is always given from the
    command line for cross compile.

    But in U-Boot, ARCH is not given from the command line.
    Which means we cannot know ARCH until the board configuration is done.
    That is why all the "*_defconfig" files should be gathered into a
    single directory ./configs/.

    Signed-off-by: Masahiro Yamada
    Acked-by: Simon Glass

    Masahiro Yamada
     

01 Nov, 2013

1 commit

24 Jul, 2013

1 commit

16 Oct, 2012

1 commit

29 Jul, 2012

1 commit

22 Nov, 2011

1 commit

16 Oct, 2011

1 commit

  • 464c79207   punt unused clean/distclean targets ... Browse Code »

    The top level Makefile does not do any recursion into subdirs when
    cleaning, so these clean/distclean targets in random arch/board dirs
    never get used. Punt them all.

    MAKEALL didn't report any errors related to this that I could see.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

13 May, 2011

1 commit

  • f0c0b3a9e   Fix incorrect use of getenv() before relocation ... Browse Code »

    A large number of boards incorrectly used getenv() in their board init
    code running before relocation. In some cases this caused U-Boot to
    hang when certain environment variables grew too long.
    Fix the code to use getenv_r().

    Signed-off-by: Wolfgang Denk
    Cc: Stefan Roese
    Cc: The LEOX team
    Cc: Michael Schwingen
    Cc: Georg Schardt
    Cc: Werner Pfister
    Cc: Dirk Eibach
    Cc: Peter De Schrijver
    Cc: John Zhan
    Cc: Rishi Bhattacharya
    Cc: Peter Tyser

    Wolfgang Denk
     

29 Nov, 2010

1 commit

18 Nov, 2010

1 commit

  • 6d8962e81   Switch from archive libraries to partial linking ... Browse Code »

    Before this commit, weak symbols were not overridden by non-weak symbols
    found in archive libraries when linking with recent versions of
    binutils. As stated in the System V ABI, "the link editor does not
    extract archive members to resolve undefined weak symbols".

    This commit changes all Makefiles to use partial linking (ld -r) instead
    of creating library archives, which forces all symbols to participate in
    linking, allowing non-weak symbols to override weak symbols as intended.
    This approach is also used by Linux, from which the gmake function
    cmd_link_o_target (defined in config.mk and used in all Makefiles) is
    inspired.

    The name of each former library archive is preserved except for
    extensions which change from ".a" to ".o". This commit updates
    references accordingly where needed, in particular in some linker
    scripts.

    This commit reveals board configurations that exclude some features but
    include source files that depend these disabled features in the build,
    resulting in undefined symbols. Known such cases include:
    - disabling CMD_NET but not CMD_NFS;
    - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.

    Signed-off-by: Sebastien Carlier

    Sebastien Carlier
     

19 Oct, 2010

2 commits

  • 2ae182419   Makefile: move all Power Architecture boards into boards.cfg ... Browse Code »

    Clean up Makefile, and drop a lot of the config.mk files on the way.

    We now also automatically pick all boards that are listed in
    boards.cfg (and with all configurations), so we can drop the redundant
    entries from MAKEALL to avoid building these twice.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     
  • 14d0a02a1   Rename TEXT_BASE into CONFIG_SYS_TEXT_BASE ... Browse Code »

    The change is currently needed to be able to remove the board
    configuration scripting from the top level Makefile and replace it by
    a simple, table driven script.

    Moving this configuration setting into the "CONFIG_*" name space is
    also desirable because it is needed if we ever should move forward to
    a Kconfig driven configuration system.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

23 Sep, 2010

1 commit

20 Sep, 2010

1 commit

  • ea882baf9   New implementation for internal handling of environment variables. ... Browse Code »

    Motivation:

    * Old environment code used a pessimizing implementation:
    - variable lookup used linear search => slow
    - changed/added variables were added at the end, i. e. most
    frequently used variables had the slowest access times => slow
    - each setenv() would calculate the CRC32 checksum over the whole
    environment block => slow
    * "redundant" envrionment was locked down to two copies
    * No easy way to implement features like "reset to factory defaults",
    or to select one out of several pre-defined (previously saved) sets
    of environment settings ("profiles")
    * No easy way to import or export environment settings

    ======================================================================

    API Changes:

    - Variable names starting with '#' are no longer allowed

    I didn't find any such variable names being used; it is highly
    recommended to follow standard conventions and start variable names
    with an alphanumeric character

    - "printenv" will now print a backslash at the end of all but the last
    lines of a multi-line variable value.

    Multi-line variables have never been formally defined, allthough
    there is no reason not to use them. Now we define rules how to deal
    with them, allowing for import and export.

    - Function forceenv() and the related code in saveenv() was removed.
    At the moment this is causing build problems for the only user of
    this code (schmoogie - which has no entry in MAINTAINERS); may be
    fixed later by implementing the "env set -f" feature.

    Inconsistencies:

    - "printenv" will '\\'-escape the '\n' in multi-line variables, while
    "printenv var" will not do that.

    ======================================================================

    Advantages:

    - "printenv" output much better readable (sorted)
    - faster!
    - extendable (additional variable properties can be added)
    - new, powerful features like "factory reset" or easy switching
    between several different environment settings ("profiles")

    Disadvantages:

    - Image size grows by typically 5...7 KiB (might shrink a bit again on
    systems with redundant environment with a following patch series)

    ======================================================================

    Implemented:

    - env command with subcommands:

    - env print [arg ...]

    same as "printenv": print environment

    - env set [-f] name [arg ...]

    same as "setenv": set (and delete) environment variables

    ["-f" - force setting even for read-only variables - not
    implemented yet.]

    - end delete [-f] name

    not implemented yet

    ["-f" - force delete even for read-only variables]

    - env save

    same as "saveenv": save environment

    - env export [-t | -b | -c] addr [size]

    export internal representation (hash table) in formats usable for
    persistent storage or processing:

    -t: export as text format; if size is given, data will be
    padded with '\0' bytes; if not, one terminating '\0'
    will be added (which is included in the "filesize"
    setting so you can for exmple copy this to flash and
    keep the termination).
    -b: export as binary format (name=value pairs separated by
    '\0', list end marked by double "\0\0")
    -c: export as checksum protected environment format as
    used for example by "saveenv" command
    addr: memory address where environment gets stored
    size: size of output buffer

    With "-c" and size is NOT given, then the export command will
    format the data as currently used for the persistent storage,
    i. e. it will use CONFIG_ENV_SECT_SIZE as output block size and
    prepend a valid CRC32 checksum and, in case of resundant
    environment, a "current" redundancy flag. If size is given, this
    value will be used instead of CONFIG_ENV_SECT_SIZE; again, CRC32
    checksum and redundancy flag will be inserted.

    With "-b" and "-t", always only the real data (including a
    terminating '\0' byte) will be written; here the optional size
    argument will be used to make sure not to overflow the user
    provided buffer; the command will abort if the size is not
    sufficient. Any remainign space will be '\0' padded.

    On successful return, the variable "filesize" will be set.
    Note that filesize includes the trailing/terminating '\0'
    byte(s).

    Usage szenario: create a text snapshot/backup of the current
    settings:

    => env export -t 100000
    => era ${backup_addr} +${filesize}
    => cp.b 100000 ${backup_addr} ${filesize}

    Re-import this snapshot, deleting all other settings:

    => env import -d -t ${backup_addr}

    - env import [-d] [-t | -b | -c] addr [size]

    import external format (text or binary) into hash table,
    optionally deleting existing values:

    -d: delete existing environment before importing;
    otherwise overwrite / append to existion definitions
    -t: assume text format; either "size" must be given or the
    text data must be '\0' terminated
    -b: assume binary format ('\0' separated, "\0\0" terminated)
    -c: assume checksum protected environment format
    addr: memory address to read from
    size: length of input data; if missing, proper '\0'
    termination is mandatory

    - env default -f

    reset default environment: drop all environment settings and load
    default environment

    - env ask name [message] [size]

    same as "askenv": ask for environment variable

    - env edit name

    same as "editenv": edit environment variable

    - env run

    same as "run": run commands in an environment variable

    ======================================================================

    TODO:

    - drop default env as implemented now; provide a text file based
    initialization instead (eventually using several text files to
    incrementally build it from common blocks) and a tool to convert it
    into a binary blob / object file.

    - It would be nice if we could add wildcard support for environment
    variables; this is needed for variable name auto-completion,
    but it would also be nice to be able to say "printenv ip*" or
    "printenv *addr*"

    - Some boards don't link any more due to the grown code size:
    DU405, canyonlands, sequoia, socrates.

    => cc: Matthias Fuchs ,
    Stefan Roese ,
    Heiko Schocher

    - Dropping forceenv() causes build problems on schmoogie

    => cc: Sergey Kubushyn

    - Build tested on PPC and ARM only; runtime tested with NOR and NAND
    flash only => needs testing!!

    Signed-off-by: Wolfgang Denk
    Cc: Matthias Fuchs ,
    Cc: Stefan Roese ,
    Cc: Heiko Schocher
    Cc: Sergey Kubushyn

    Wolfgang Denk
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

02 Nov, 2009

1 commit

03 Oct, 2009

1 commit

  • 858290178   ppc: Enable full relocation to RAM ... Browse Code »

    The following changes allow U-Boot to fully relocate from flash to
    RAM:
    - Remove linker scripts' .fixup sections from the .text section
    - Add -mrelocatable to PLATFORM_RELFLAGS for all boards
    - Define CONFIG_RELOC_FIXUP_WORKS for all boards

    Previously, U-Boot would partially relocate, but statically initialized
    pointers needed to be manually relocated.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

28 Sep, 2009

1 commit

11 Sep, 2009

1 commit

  • d1c3b2752   ppc4xx: Big cleanup of PPC4xx defines ... Browse Code »

    This patch cleans up multiple issues of the 4xx register (mostly
    DCR, SDR, CPR, etc) definitions:

    - Change lower case defines to upper case (plb4_acr -> PLB4_ACR)
    - Change the defines to better match the names from the
    user's manuals (e.g. cprpllc -> CPR0_PLLC)
    - Removal of some unused defines

    Please test this patch intensive on your PPC4xx platform. Even though
    I tried not to break anything and tested successfully on multiple
    4xx AMCC platforms, testing on custom platforms is recommended.

    Signed-off-by: Stefan Roese

    Stefan Roese
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

21 Mar, 2009

1 commit

  • f62fb9994   Fix all linker script to handle all rodata sections ... Browse Code »

    A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
    which needs to be added the the linker script. Instead of just adding this
    one section, we use a wildcard ".rodata*" to get all rodata linker section
    gcc has now and might add in the future.

    However, '*(.rodata*)' by itself will result in sub-optimal section
    ordering. The sections will be sorted by object file, which causes extra
    padding between the unaligned rodata.str.1.1 of one object file and the
    aligned rodata of the next object file. This is easy to fix by using the
    SORT_BY_ALIGNMENT command.

    This patch has not be tested one most of the boards modified. Some boards
    have a linker script that looks something like this:

    *(.text)
    . = ALIGN(16);
    *(.rodata)
    *(.rodata.str1.4)
    *(.eh_frame)

    I change this to:

    *(.text)
    . = ALIGN(16);
    *(.eh_frame)
    *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))

    This means the start of rodata will no longer be 16 bytes aligned.
    However, the boundary between text and rodata/eh_frame is still aligned to
    16 bytes, which is what I think the real purpose of the ALIGN call is.

    Signed-off-by: Trent Piepho

    Trent Piepho
     

28 Jan, 2009

1 commit

  • 2fb2604d5   Command usage cleanup ... Browse Code »

    Remove command name from all command "usage" fields and update
    common/command.c to display "name - usage" instead of
    just "usage". Also remove newlines from command usage fields.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

19 Nov, 2008

1 commit

  • 9b827cf17   Align end of bss by 4 bytes ... Browse Code »

    Most of the bss initialization loop increments 4 bytes
    at a time. And the loop end is checked for an 'equal'
    condition. Make the bss end address aligned by 4, so
    that the loop will end as expected.

    Signed-off-by: Selvamuthukumar
    Signed-off-by: Wolfgang Denk

    Selvamuthukumar
     

19 Oct, 2008

1 commit

12 Sep, 2008

2 commits

11 Sep, 2008

1 commit

10 Jul, 2008

1 commit

03 Jul, 2008

1 commit

12 Jun, 2008

1 commit

  • 9973e3c61   Change initdram() return type to phys_size_t ... Browse Code »

    This patch changes the return type of initdram() from long int to phys_size_t.
    This is required for a couple of reasons: long int limits the amount of dram
    to 2GB, and u-boot in general is moving over to phys_size_t to represent the
    size of physical memory. phys_size_t is defined as an unsigned long on almost
    all current platforms.

    This patch *only* changes the return type of the initdram function (in
    include/common.h, as well as in each board's implementation of initdram). It
    does not actually modify the code inside the function on any of the platforms;
    platforms which wish to support more than 2GB of DRAM will need to modify
    their initdram() function code.

    Build tested with MAKEALL for ppc, arm, mips, mips-el. Booted on powerpc
    MPC8641HPCN.

    Signed-off-by: Becky Bruce

    Becky Bruce
     

04 Jun, 2008

1 commit

21 May, 2008

1 commit

  • 53677ef18   Big white-space cleanup. ... Browse Code »

    This commit gets rid of a huge amount of silly white-space issues.
    Especially, all sequences of SPACEs followed by TAB characters get
    removed (unless they appear in print statements).

    Also remove all embedded "vim:" and "vi:" statements which hide
    indentation problems.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

18 Apr, 2008

1 commit

13 Jan, 2008

1 commit

  • 64134f011   Fix linker scripts: add NOLOAD atribute to .bss/.sbss sections ... Browse Code »
    20

    With recent toolchain versions, some boards would not build because
    or errors like this one (here for ocotea board when building with
    ELDK 4.2 beta):
    ppc_4xx-ld: section .bootpg [fffff000 -> fffff23b] overlaps section .bss [fffee900 -> fffff8ab]

    For many boards, the .bss section is big enough that it wraps around
    at the end of the address space (0xFFFFFFFF), so the problem will not
    be visible unless you use a 64 bit tool chain for development. On
    some boards however, changes to the code size (due to different
    optimizations) we bail out with section overlaps like above.

    The fix is to add the NOLOAD attribute to the .bss and .sbss
    sections, telling the linker that .bss does not consume any space in
    the image.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

14 Aug, 2007

1 commit